From: Pavel Shilovsky <piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
Cc: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>,
Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: linux-next: build warning after merge of the cifs tree
Date: Mon, 31 Jan 2011 14:38:52 +0300 [thread overview]
Message-ID: <AANLkTikcAEdFLwhcGC8uqRQAYVCCzR4Bz06Qr5ZdvyLd@mail.gmail.com> (raw)
In-Reply-To: <4D4693CF.9090903-l3A5Bk7waGM@public.gmane.org>
2011/1/31 Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>:
> On 01/31/2011 08:00 AM, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the cifs tree, today's linux-next build (powerpc
>> ppc64_defconfig) produced this warning:
>>
>> fs/cifs/file.c: In function 'cifs_iovec_write':
>> fs/cifs/file.c:1740: warning: passing argument 6 of 'CIFSSMBWrite2' from incompatible pointer type
>> fs/cifs/cifsproto.h:343: note: expected 'unsigned int *' but argument is of type 'size_t *'
>>
>> Introduced by commit 72432ffcf555decbbae47f1be338e1d2f210aa69 ("CIFS:
>> Implement cifs_strict_writev (try #4)").
>>
>
> The following patch should silence that warning.
>
> From: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
> Subject: [PATCH] cifs: fix compiler warning about incompatible pointer type
>
> fs/cifs/file.c: In function ‘cifs_iovec_write’:
> fs/cifs/file.c:1740:9: warning: passing argument 6 of ‘CIFSSMBWrite2’ from incompatible pointer type
> fs/cifs/cifsproto.h:343:12: note: expected ‘unsigned int *’ but argument is of type ‘size_t *’
>
> Cc: Pavel Shilovsky <piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
> ---
> fs/cifs/file.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/cifs/file.c b/fs/cifs/file.c
> index 0de17c1..2a3c5d8 100644
> --- a/fs/cifs/file.c
> +++ b/fs/cifs/file.c
> @@ -1667,7 +1667,7 @@ static ssize_t
> cifs_iovec_write(struct file *file, const struct iovec *iov,
> unsigned long nr_segs, loff_t *poffset)
> {
> - size_t total_written = 0, written = 0;
> + unsigned int total_written = 0, written = 0;
> unsigned long num_pages, npages;
> size_t copied, len, cur_len, i;
> struct kvec *to_send;
>
I've just noriced another bug: that 'i' variable should be unsigned
long. I will recreate the patch with this fix.
--
Best regards,
Pavel Shilovsky.
next prev parent reply other threads:[~2011-01-31 11:38 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 2:30 linux-next: build warning after merge of the cifs tree Stephen Rothwell
2011-01-31 10:49 ` Suresh Jayaraman
[not found] ` <4D4693CF.9090903-l3A5Bk7waGM@public.gmane.org>
2011-01-31 11:38 ` Pavel Shilovsky [this message]
2011-01-31 11:41 ` [PATCH] cifs: fix compiler warning about incompatible pointer type (try #2) Pavel Shilovsky
2011-01-31 12:09 ` [PATCH] cifs: fix compiler warning about incompatible pointer type (try #3) Pavel Shilovsky
2011-01-31 12:52 ` Pavel Shilovsky
2011-01-31 12:29 ` linux-next: build warning after merge of the cifs tree Jeff Layton
-- strict thread matches above, loose matches on Subject: below --
2024-01-19 1:47 Stephen Rothwell
2024-01-19 3:02 ` Steve French
2022-05-23 0:57 Stephen Rothwell
2022-05-23 2:29 ` Steve French
2021-02-04 22:51 Stephen Rothwell
2019-07-18 23:16 Stephen Rothwell
2019-07-18 23:38 ` Steve French
2018-01-03 22:33 Stephen Rothwell
2018-01-03 22:44 ` Steve French
[not found] ` <CAH2r5mvgtC3Y_aLxk7-_R8E=ohR1LoFSkiqZZ6rhn9azXY05xw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-04 5:52 ` Stephen Rothwell
2017-11-20 23:19 Stephen Rothwell
[not found] ` <20171121101916.4970d5f9-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2017-11-20 23:37 ` Steve French
2017-06-26 0:07 Stephen Rothwell
[not found] ` <20170626100728.0494601c-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2017-06-26 16:57 ` Steve French
2011-01-31 2:27 Stephen Rothwell
[not found] ` <20110131132743.4ae5d4ae.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2011-01-31 3:25 ` Steve French
2011-01-31 2:25 Stephen Rothwell
2011-01-21 1:05 Stephen Rothwell
2011-01-21 1:20 ` Jeff Layton
2010-09-24 3:55 Stephen Rothwell
[not found] ` <20100924135531.96e5ac72.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2010-10-19 5:21 ` Stephen Rothwell
2010-10-19 13:13 ` Jeff Layton
[not found] ` <20101019091339.38e45faa-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-10-19 15:48 ` Shirish Pargaonkar
2010-09-24 3:48 Stephen Rothwell
2010-09-24 11:13 ` Jeff Layton
2010-08-26 1:02 Stephen Rothwell
[not found] ` <20100826110229.931ab5bf.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2010-08-26 2:07 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikcAEdFLwhcGC8uqRQAYVCCzR4Bz06Qr5ZdvyLd@mail.gmail.com \
--to=piastryyy-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org \
--cc=sjayaraman-l3A5Bk7waGM@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).