query fs info level 0x100

query fs info level 0x100

[Steve French]

Trying some xfstests to current Samba (master branch, Samba 4.21),
they fail because query fs info (level 0x100) is returning
STATUS_INVALID_INFO_CLASS) - this works to ksmbd and I thought it used
to work to Samba.   I do see the SMB3.1.1 opens with the POSIX open
context works - but the query fs info failing causes xfstests to fail.

Is that missing rom current mainline Samba?

-- 
Thanks,

Steve

Re: query fs info level 0x100

[Ralph Boehme]

[-- Attachment #1.1: Type: text/plain, Size: 533 bytes --]

On 4/29/24 1:27 AM, Steve French wrote:
> Trying some xfstests to current Samba (master branch, Samba 4.21),
> they fail because query fs info (level 0x100) is returning
> STATUS_INVALID_INFO_CLASS) - this works to ksmbd and I thought it used
> to work to Samba.   I do see the SMB3.1.1 opens with the POSIX open
> context works - but the query fs info failing causes xfstests to fail.
> 
> Is that missing rom current mainline Samba?

have you enabled SMB3 UNIX Extensions?

smb3 unix extensions = yes

Cheers!
-slow

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

Re: query fs info level 0x100

[Steve French]

On Mon, Apr 29, 2024 at 12:31 AM Ralph Boehme <slow@samba.org> wrote:
>
> On 4/29/24 1:27 AM, Steve French wrote:
> > Trying some xfstests to current Samba (master branch, Samba 4.21),
> > they fail because query fs info (level 0x100) is returning
> > STATUS_INVALID_INFO_CLASS) - this works to ksmbd and I thought it used
> > to work to Samba.   I do see the SMB3.1.1 opens with the POSIX open
> > context works - but the query fs info failing causes xfstests to fail.
> >
> > Is that missing rom current mainline Samba?
>
> have you enabled SMB3 UNIX Extensions?
>
> smb3 unix extensions = yes

Yes - it is set to yes in the smb.conf for both the global section and
the per share section

I also see that POSIX extensions in:
1) the server returns posix negotiation context in the SMB3.1.1
negotiate protocol response
2) the server returns the level 100 (FILE_POSIX_INFO) query info responses

But the (current Samba) server fails the level 100 (level 0x64 in hex)
FS_POSIX_INFO with "STATUS_INVALID_ERROR_CLASS"
which causes all xfstests to break since they can't verify the mount
(e.g. with "stat -f").
Nothing related to this on the client has changed, and ksmbd has
always supported this so works fine there.


-- 
Thanks,

Steve

Re: query fs info level 0x100

[Stefan Metzmacher]

Am 29.04.24 um 18:13 schrieb Steve French via samba-technical:
> On Mon, Apr 29, 2024 at 12:31 AM Ralph Boehme <slow@samba.org> wrote:
>>
>> On 4/29/24 1:27 AM, Steve French wrote:
>>> Trying some xfstests to current Samba (master branch, Samba 4.21),
>>> they fail because query fs info (level 0x100) is returning
>>> STATUS_INVALID_INFO_CLASS) - this works to ksmbd and I thought it used
>>> to work to Samba.   I do see the SMB3.1.1 opens with the POSIX open
>>> context works - but the query fs info failing causes xfstests to fail.
>>>
>>> Is that missing rom current mainline Samba?
>>
>> have you enabled SMB3 UNIX Extensions?
>>
>> smb3 unix extensions = yes
> 
> Yes - it is set to yes in the smb.conf for both the global section and
> the per share section
> 
> I also see that POSIX extensions in:
> 1) the server returns posix negotiation context in the SMB3.1.1
> negotiate protocol response
> 2) the server returns the level 100 (FILE_POSIX_INFO) query info responses
> 
> But the (current Samba) server fails the level 100 (level 0x64 in hex)
> FS_POSIX_INFO with "STATUS_INVALID_ERROR_CLASS"
> which causes all xfstests to break since they can't verify the mount
> (e.g. with "stat -f").
> Nothing related to this on the client has changed, and ksmbd has
> always supported this so works fine there.

I guess fsinfo_unix_valid_level() needs
fsp->posix_flags & FSP_POSIX_FLAGS_OPEN
instead of
fsp->posix_flags == FSP_POSIX_FLAGS_OPEN

In smbd_do_qfilepathinfo() we do the check with '&' instead of '=='.

metze

Re: query fs info level 0x100

[Ralph Boehme]

[-- Attachment #1.1.1: Type: text/plain, Size: 445 bytes --]

On 4/29/24 6:13 PM, Steve French wrote:
> But the (current Samba) server fails the level 100 (level 0x64 in hex)
> FS_POSIX_INFO with "STATUS_INVALID_ERROR_CLASS"
> which causes all xfstests to break since they can't verify the mount
> (e.g. with "stat -f").
> Nothing related to this on the client has changed, and ksmbd has
> always supported this so works fine there.

ah, I broke it. Fix attached. Really embarrassing...

-slow


[-- Attachment #1.1.2: bug15639-master.patch --]
[-- Type: text/x-patch, Size: 989 bytes --]

From 3862563582683f86a1fd5d25422b3137f1b05141 Mon Sep 17 00:00:00 2001
From: Ralph Boehme <slow@samba.org>
Date: Mon, 29 Apr 2024 18:38:10 +0200
Subject: [PATCH] smbd: SMB3 POSIX Extensions statfs() is broken

Regression introduced by 55d98b29eb294542cc4947573f233e0d5e6966cb. D'oh!

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15639

Signed-off-by: Ralph Boehme <slow@samba.org>
---
 source3/smbd/smb2_trans2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source3/smbd/smb2_trans2.c b/source3/smbd/smb2_trans2.c
index 5198a04a74c6..8e122025d283 100644
--- a/source3/smbd/smb2_trans2.c
+++ b/source3/smbd/smb2_trans2.c
@@ -1991,7 +1991,7 @@ static bool fsinfo_unix_valid_level(connection_struct *conn,
 				    uint16_t info_level)
 {
 	if (conn_using_smb2(conn->sconn) &&
-	    fsp->posix_flags == FSP_POSIX_FLAGS_OPEN &&
+	    (fsp->posix_flags & FSP_POSIX_FLAGS_OPEN) &&
 	    info_level == SMB2_FS_POSIX_INFORMATION_INTERNAL)
 	{
 		return true;
-- 
2.44.0


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

Re: query fs info level 0x100

[Jeremy Allison]

On Mon, Apr 29, 2024 at 06:44:39PM +0200, Ralph Boehme wrote:
>On 4/29/24 6:13 PM, Steve French wrote:
>>But the (current Samba) server fails the level 100 (level 0x64 in hex)
>>FS_POSIX_INFO with "STATUS_INVALID_ERROR_CLASS"
>>which causes all xfstests to break since they can't verify the mount
>>(e.g. with "stat -f").
>>Nothing related to this on the client has changed, and ksmbd has
>>always supported this so works fine there.
>
>ah, I broke it. Fix attached. Really embarrassing...

Double embarrassing, I +1 reviewed it. So sorry for the bug :-(.

Re: query fs info level 0x100

[Steve French]

Worked for me.  You can add my Reviewed-by and Tested-by if you want.

On Mon, Apr 29, 2024 at 12:11 PM Jeremy Allison <jra@samba.org> wrote:
>
> On Mon, Apr 29, 2024 at 06:44:39PM +0200, Ralph Boehme wrote:
> >On 4/29/24 6:13 PM, Steve French wrote:
> >>But the (current Samba) server fails the level 100 (level 0x64 in hex)
> >>FS_POSIX_INFO with "STATUS_INVALID_ERROR_CLASS"
> >>which causes all xfstests to break since they can't verify the mount
> >>(e.g. with "stat -f").
> >>Nothing related to this on the client has changed, and ksmbd has
> >>always supported this so works fine there.
> >
> >ah, I broke it. Fix attached. Really embarrassing...
>
> Double embarrassing, I +1 reviewed it. So sorry for the bug :-(.



-- 
Thanks,

Steve