* [PATCH 1/1] clk: ti: clkctrl: Fix Bad of_node_put within clkctrl_get_name
@ 2020-04-24 12:47 Tero Kristo
2020-04-24 15:36 ` Tony Lindgren
2020-05-13 3:16 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Tero Kristo @ 2020-04-24 12:47 UTC (permalink / raw)
To: linux-clk, sboyd, mturquette; +Cc: tony, linux-omap
clkctrl_get_name incorrectly calls of_node_put when it is not really
doing of_node_get. This causes a boot time warning later on:
[ 0.000000] OF: ERROR: Bad of_node_put() on /ocp/interconnect@4a000000/segmen
t@0/target-module@5000/cm_core_aon@0/ipu-cm@500/ipu1-clkctrl@20
Fix by dropping the of_node_put from the function.
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Fixes: 6c3090520554 ("clk: ti: clkctrl: Fix hidden dependency to node name")
Signed-off-by: Tero Kristo <t-kristo@ti.com>
---
drivers/clk/ti/clkctrl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clk/ti/clkctrl.c b/drivers/clk/ti/clkctrl.c
index 062266034d84..9019624e37bc 100644
--- a/drivers/clk/ti/clkctrl.c
+++ b/drivers/clk/ti/clkctrl.c
@@ -461,7 +461,6 @@ static char * __init clkctrl_get_name(struct device_node *np)
return name;
}
}
- of_node_put(np);
return NULL;
}
--
2.17.1
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] clk: ti: clkctrl: Fix Bad of_node_put within clkctrl_get_name
2020-04-24 12:47 [PATCH 1/1] clk: ti: clkctrl: Fix Bad of_node_put within clkctrl_get_name Tero Kristo
@ 2020-04-24 15:36 ` Tony Lindgren
2020-05-13 3:16 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2020-04-24 15:36 UTC (permalink / raw)
To: Tero Kristo; +Cc: linux-clk, sboyd, mturquette, linux-omap
* Tero Kristo <t-kristo@ti.com> [200424 12:48]:
> clkctrl_get_name incorrectly calls of_node_put when it is not really
> doing of_node_get. This causes a boot time warning later on:
>
> [ 0.000000] OF: ERROR: Bad of_node_put() on /ocp/interconnect@4a000000/segmen
> t@0/target-module@5000/cm_core_aon@0/ipu-cm@500/ipu1-clkctrl@20
>
> Fix by dropping the of_node_put from the function.
>
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Fixes: 6c3090520554 ("clk: ti: clkctrl: Fix hidden dependency to node name")
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
Acked-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] clk: ti: clkctrl: Fix Bad of_node_put within clkctrl_get_name
2020-04-24 12:47 [PATCH 1/1] clk: ti: clkctrl: Fix Bad of_node_put within clkctrl_get_name Tero Kristo
2020-04-24 15:36 ` Tony Lindgren
@ 2020-05-13 3:16 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2020-05-13 3:16 UTC (permalink / raw)
To: Tero Kristo, linux-clk, mturquette; +Cc: tony, linux-omap
Quoting Tero Kristo (2020-04-24 05:47:25)
> clkctrl_get_name incorrectly calls of_node_put when it is not really
> doing of_node_get. This causes a boot time warning later on:
>
> [ 0.000000] OF: ERROR: Bad of_node_put() on /ocp/interconnect@4a000000/segmen
> t@0/target-module@5000/cm_core_aon@0/ipu-cm@500/ipu1-clkctrl@20
>
> Fix by dropping the of_node_put from the function.
>
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Fixes: 6c3090520554 ("clk: ti: clkctrl: Fix hidden dependency to node name")
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> ---
Applied to clk-fixes
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-13 3:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-24 12:47 [PATCH 1/1] clk: ti: clkctrl: Fix Bad of_node_put within clkctrl_get_name Tero Kristo
2020-04-24 15:36 ` Tony Lindgren
2020-05-13 3:16 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).