linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	Jiancheng Xue <xuejiancheng@hisilicon.com>,
	Leo Yan <leo.yan@linaro.org>,
	Jianguo Sun <sunjianguo1@huawei.com>,
	Wei Yongjun <weiyongjun1@huawei.com>
Subject: [PATCH 5/8] clk: hisilicon: Remove usage of CLK_IS_BASIC
Date: Thu,  6 Dec 2018 13:58:55 -0800	[thread overview]
Message-ID: <20181206215858.3880-6-sboyd@kernel.org> (raw)
In-Reply-To: <20181206215858.3880-1-sboyd@kernel.org>

This flag doesn't look to be used by any code, just set in various clk
init structures and then never tested again. Remove it from these
drivers as it doesn't provide any benefit.

Cc: Jiancheng Xue <xuejiancheng@hisilicon.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Jianguo Sun <sunjianguo1@huawei.com>
Cc: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
---
 drivers/clk/hisilicon/clk-hi3620.c        | 2 +-
 drivers/clk/hisilicon/clk-hisi-phase.c    | 2 +-
 drivers/clk/hisilicon/clk-hix5hd2.c       | 2 +-
 drivers/clk/hisilicon/clkgate-separated.c | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/clk/hisilicon/clk-hi3620.c b/drivers/clk/hisilicon/clk-hi3620.c
index 77072c7778b9..2eda9bdf6d03 100644
--- a/drivers/clk/hisilicon/clk-hi3620.c
+++ b/drivers/clk/hisilicon/clk-hi3620.c
@@ -435,7 +435,7 @@ static struct clk *hisi_register_clk_mmc(struct hisi_mmc_clock *mmc_clk,
 
 	init.name = mmc_clk->name;
 	init.ops = &clk_mmc_ops;
-	init.flags = mmc_clk->flags | CLK_IS_BASIC;
+	init.flags = mmc_clk->flags;
 	init.parent_names = (mmc_clk->parent_name ? &mmc_clk->parent_name : NULL);
 	init.num_parents = (mmc_clk->parent_name ? 1 : 0);
 	mclk->hw.init = &init;
diff --git a/drivers/clk/hisilicon/clk-hisi-phase.c b/drivers/clk/hisilicon/clk-hisi-phase.c
index 5bce9297b78b..5fdc267bb2da 100644
--- a/drivers/clk/hisilicon/clk-hisi-phase.c
+++ b/drivers/clk/hisilicon/clk-hisi-phase.c
@@ -103,7 +103,7 @@ struct clk *clk_register_hisi_phase(struct device *dev,
 
 	init.name = clks->name;
 	init.ops = &clk_phase_ops;
-	init.flags = clks->flags | CLK_IS_BASIC;
+	init.flags = clks->flags;
 	init.parent_names = clks->parent_names ? &clks->parent_names : NULL;
 	init.num_parents = clks->parent_names ? 1 : 0;
 
diff --git a/drivers/clk/hisilicon/clk-hix5hd2.c b/drivers/clk/hisilicon/clk-hix5hd2.c
index 9584f0c32dda..659bd5f493b8 100644
--- a/drivers/clk/hisilicon/clk-hix5hd2.c
+++ b/drivers/clk/hisilicon/clk-hix5hd2.c
@@ -274,7 +274,7 @@ hix5hd2_clk_register_complex(struct hix5hd2_complex_clock *clks, int nums,
 		else
 			init.ops = &clk_complex_ops;
 
-		init.flags = CLK_IS_BASIC;
+		init.flags = 0;
 		init.parent_names =
 			(clks[i].parent_name ? &clks[i].parent_name : NULL);
 		init.num_parents = (clks[i].parent_name ? 1 : 0);
diff --git a/drivers/clk/hisilicon/clkgate-separated.c b/drivers/clk/hisilicon/clkgate-separated.c
index f36bdef91831..ae84884dc749 100644
--- a/drivers/clk/hisilicon/clkgate-separated.c
+++ b/drivers/clk/hisilicon/clkgate-separated.c
@@ -110,7 +110,7 @@ struct clk *hisi_register_clkgate_sep(struct device *dev, const char *name,
 
 	init.name = name;
 	init.ops = &clkgate_separated_ops;
-	init.flags = flags | CLK_IS_BASIC;
+	init.flags = flags;
 	init.parent_names = (parent_name ? &parent_name : NULL);
 	init.num_parents = (parent_name ? 1 : 0);
 
-- 
Sent by a computer through tubes


  parent reply	other threads:[~2018-12-06 21:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-06 21:58 [PATCH 0/8] Remove CLK_IS_BASIC usage from clk drivers Stephen Boyd
2018-12-06 21:58 ` [PATCH 1/8] clk: renesas: Remove usage of CLK_IS_BASIC Stephen Boyd
2018-12-07  8:27   ` Geert Uytterhoeven
2018-12-07 20:41     ` Stephen Boyd
2018-12-13 19:48   ` Stephen Boyd
2018-12-06 21:58 ` [PATCH 2/8] clk: st: " Stephen Boyd
2018-12-13 19:49   ` Stephen Boyd
2018-12-06 21:58 ` [PATCH 3/8] clk: axm5516: " Stephen Boyd
2018-12-13 19:49   ` Stephen Boyd
2018-12-06 21:58 ` [PATCH 4/8] clk: h8300: " Stephen Boyd
2018-12-13 19:49   ` Stephen Boyd
2018-12-06 21:58 ` Stephen Boyd [this message]
2018-12-13 19:49   ` [PATCH 5/8] clk: hisilicon: " Stephen Boyd
2018-12-06 21:58 ` [PATCH 6/8] clk: versatile: sp810: " Stephen Boyd
2018-12-06 22:03   ` Linus Walleij
2018-12-13 19:49   ` Stephen Boyd
2018-12-06 21:58 ` [PATCH 7/8] clk: samsung: s3c2410: " Stephen Boyd
2018-12-07  8:45   ` Krzysztof Kozlowski
2018-12-13 19:49   ` Stephen Boyd
2018-12-06 21:58 ` [PATCH 8/8] clk: Loongson1: " Stephen Boyd
2018-12-13 19:49   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181206215858.3880-6-sboyd@kernel.org \
    --to=sboyd@kernel.org \
    --cc=leo.yan@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sunjianguo1@huawei.com \
    --cc=weiyongjun1@huawei.com \
    --cc=xuejiancheng@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).