From: Linus Walleij <linus.walleij@linaro.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>
Subject: Re: [PATCH 6/8] clk: versatile: sp810: Remove usage of CLK_IS_BASIC
Date: Thu, 6 Dec 2018 23:03:19 +0100 [thread overview]
Message-ID: <CACRpkdbNs81HKTdtmVpo6swQj8Nc1dSutbyaDeJ1GsuDWzQToA@mail.gmail.com> (raw)
In-Reply-To: <20181206215858.3880-7-sboyd@kernel.org>
On Thu, Dec 6, 2018 at 10:59 PM Stephen Boyd <sboyd@kernel.org> wrote:
> This flag doesn't look to be used by any code, just set in the clk init
> structure and then never tested again. Remove it from this driver as it
> doesn't provide any benefit.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Can't help but wonder what semantic it was supposed to have.
It seems a bit vague now.
Yours,
Linus Walleij
next prev parent reply other threads:[~2018-12-06 22:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 21:58 [PATCH 0/8] Remove CLK_IS_BASIC usage from clk drivers Stephen Boyd
2018-12-06 21:58 ` [PATCH 1/8] clk: renesas: Remove usage of CLK_IS_BASIC Stephen Boyd
2018-12-07 8:27 ` Geert Uytterhoeven
2018-12-07 20:41 ` Stephen Boyd
2018-12-13 19:48 ` Stephen Boyd
2018-12-06 21:58 ` [PATCH 2/8] clk: st: " Stephen Boyd
2018-12-13 19:49 ` Stephen Boyd
2018-12-06 21:58 ` [PATCH 3/8] clk: axm5516: " Stephen Boyd
2018-12-13 19:49 ` Stephen Boyd
2018-12-06 21:58 ` [PATCH 4/8] clk: h8300: " Stephen Boyd
2018-12-13 19:49 ` Stephen Boyd
2018-12-06 21:58 ` [PATCH 5/8] clk: hisilicon: " Stephen Boyd
2018-12-13 19:49 ` Stephen Boyd
2018-12-06 21:58 ` [PATCH 6/8] clk: versatile: sp810: " Stephen Boyd
2018-12-06 22:03 ` Linus Walleij [this message]
2018-12-13 19:49 ` Stephen Boyd
2018-12-06 21:58 ` [PATCH 7/8] clk: samsung: s3c2410: " Stephen Boyd
2018-12-07 8:45 ` Krzysztof Kozlowski
2018-12-13 19:49 ` Stephen Boyd
2018-12-06 21:58 ` [PATCH 8/8] clk: Loongson1: " Stephen Boyd
2018-12-13 19:49 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbNs81HKTdtmVpo6swQj8Nc1dSutbyaDeJ1GsuDWzQToA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).