* [RESEND][PATCH] clk: at91: generated: Truncate divisor to GENERATED_MAX_DIV + 1
@ 2019-06-25 9:10 Codrin Ciubotariu
2019-07-03 15:05 ` Nicolas.Ferre
2019-07-22 21:32 ` Stephen Boyd
0 siblings, 2 replies; 4+ messages in thread
From: Codrin Ciubotariu @ 2019-06-25 9:10 UTC (permalink / raw)
To: sboyd, nicolas.ferre, alexandre.belloni, ludovic.desroches
Cc: linux-clk, linux-arm-kernel, linux-kernel, Codrin Ciubotariu
In clk_generated_determine_rate(), if the divisor is greater than
GENERATED_MAX_DIV + 1, then the wrong best_rate will be returned.
If clk_generated_set_rate() will be called later with this wrong
rate, it will return -EINVAL, so the generated clock won't change
its value. Do no let the divisor be greater than GENERATED_MAX_DIV + 1.
Fixes: 8c7aa6328947 ("clk: at91: clk-generated: remove useless divisor loop")
Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
---
- The email-server was converting my patches to base64, so I resend it
using another server;
- Added acked-bys from Nicolas and Ludovic;
drivers/clk/at91/clk-generated.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/clk/at91/clk-generated.c b/drivers/clk/at91/clk-generated.c
index 5f18847965c1..290cffe35deb 100644
--- a/drivers/clk/at91/clk-generated.c
+++ b/drivers/clk/at91/clk-generated.c
@@ -146,6 +146,8 @@ static int clk_generated_determine_rate(struct clk_hw *hw,
continue;
div = DIV_ROUND_CLOSEST(parent_rate, req->rate);
+ if (div > GENERATED_MAX_DIV + 1)
+ div = GENERATED_MAX_DIV + 1;
clk_generated_best_diff(req, parent, parent_rate, div,
&best_diff, &best_rate);
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RESEND][PATCH] clk: at91: generated: Truncate divisor to GENERATED_MAX_DIV + 1
2019-06-25 9:10 [RESEND][PATCH] clk: at91: generated: Truncate divisor to GENERATED_MAX_DIV + 1 Codrin Ciubotariu
@ 2019-07-03 15:05 ` Nicolas.Ferre
2019-07-22 21:31 ` Stephen Boyd
2019-07-22 21:32 ` Stephen Boyd
1 sibling, 1 reply; 4+ messages in thread
From: Nicolas.Ferre @ 2019-07-03 15:05 UTC (permalink / raw)
To: Codrin.Ciubotariu, sboyd, alexandre.belloni, Ludovic.Desroches
Cc: linux-clk, linux-arm-kernel, linux-kernel
On 25/06/2019 at 11:10, Codrin Ciubotariu wrote:
> In clk_generated_determine_rate(), if the divisor is greater than
> GENERATED_MAX_DIV + 1, then the wrong best_rate will be returned.
> If clk_generated_set_rate() will be called later with this wrong
> rate, it will return -EINVAL, so the generated clock won't change
> its value. Do no let the divisor be greater than GENERATED_MAX_DIV + 1.
>
> Fixes: 8c7aa6328947 ("clk: at91: clk-generated: remove useless divisor loop")
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
> ---
>
> - The email-server was converting my patches to base64, so I resend it
> using another server;
> - Added acked-bys from Nicolas and Ludovic;
Stephen,
I don't see this patch in linux-next and we're already late in the
development cycle: aka ping...
Best regards,
Nicolas
>
> drivers/clk/at91/clk-generated.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/at91/clk-generated.c b/drivers/clk/at91/clk-generated.c
> index 5f18847965c1..290cffe35deb 100644
> --- a/drivers/clk/at91/clk-generated.c
> +++ b/drivers/clk/at91/clk-generated.c
> @@ -146,6 +146,8 @@ static int clk_generated_determine_rate(struct clk_hw *hw,
> continue;
>
> div = DIV_ROUND_CLOSEST(parent_rate, req->rate);
> + if (div > GENERATED_MAX_DIV + 1)
> + div = GENERATED_MAX_DIV + 1;
>
> clk_generated_best_diff(req, parent, parent_rate, div,
> &best_diff, &best_rate);
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RESEND][PATCH] clk: at91: generated: Truncate divisor to GENERATED_MAX_DIV + 1
2019-07-03 15:05 ` Nicolas.Ferre
@ 2019-07-22 21:31 ` Stephen Boyd
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2019-07-22 21:31 UTC (permalink / raw)
To: Codrin.Ciubotariu, Ludovic.Desroches, Nicolas.Ferre, alexandre.belloni
Cc: linux-clk, linux-arm-kernel, linux-kernel
Quoting Nicolas.Ferre@microchip.com (2019-07-03 08:05:24)
> On 25/06/2019 at 11:10, Codrin Ciubotariu wrote:
> > In clk_generated_determine_rate(), if the divisor is greater than
> > GENERATED_MAX_DIV + 1, then the wrong best_rate will be returned.
> > If clk_generated_set_rate() will be called later with this wrong
> > rate, it will return -EINVAL, so the generated clock won't change
> > its value. Do no let the divisor be greater than GENERATED_MAX_DIV + 1.
> >
> > Fixes: 8c7aa6328947 ("clk: at91: clk-generated: remove useless divisor loop")
> > Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> > Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> > Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
> > ---
> >
> > - The email-server was converting my patches to base64, so I resend it
> > using another server;
> > - Added acked-bys from Nicolas and Ludovic;
>
> Stephen,
>
> I don't see this patch in linux-next and we're already late in the
> development cycle: aka ping...
>
Sorry. I dropped this one. Will pick it up into fixes.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RESEND][PATCH] clk: at91: generated: Truncate divisor to GENERATED_MAX_DIV + 1
2019-06-25 9:10 [RESEND][PATCH] clk: at91: generated: Truncate divisor to GENERATED_MAX_DIV + 1 Codrin Ciubotariu
2019-07-03 15:05 ` Nicolas.Ferre
@ 2019-07-22 21:32 ` Stephen Boyd
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2019-07-22 21:32 UTC (permalink / raw)
To: Codrin Ciubotariu, alexandre.belloni, ludovic.desroches, nicolas.ferre
Cc: linux-clk, linux-arm-kernel, linux-kernel, Codrin Ciubotariu
Quoting Codrin Ciubotariu (2019-06-25 02:10:02)
> In clk_generated_determine_rate(), if the divisor is greater than
> GENERATED_MAX_DIV + 1, then the wrong best_rate will be returned.
> If clk_generated_set_rate() will be called later with this wrong
> rate, it will return -EINVAL, so the generated clock won't change
> its value. Do no let the divisor be greater than GENERATED_MAX_DIV + 1.
>
> Fixes: 8c7aa6328947 ("clk: at91: clk-generated: remove useless divisor loop")
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
> ---
Applied to clk-fixes
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-22 21:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-25 9:10 [RESEND][PATCH] clk: at91: generated: Truncate divisor to GENERATED_MAX_DIV + 1 Codrin Ciubotariu
2019-07-03 15:05 ` Nicolas.Ferre
2019-07-22 21:31 ` Stephen Boyd
2019-07-22 21:32 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).