linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: renesas: rcar-usb2-clock-sel: Use devm_platform_ioremap_resource() helper
@ 2019-08-07  8:49 Geert Uytterhoeven
  2019-08-08  1:58 ` Yoshihiro Shimoda
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2019-08-07  8:49 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd
  Cc: Yoshihiro Shimoda, linux-renesas-soc, linux-clk, Geert Uytterhoeven

Use the devm_platform_ioremap_resource() helper instead of open-coding
the same operation.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
To be queued in clk-renesas-for-v5.4.

 drivers/clk/renesas/rcar-usb2-clock-sel.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/clk/renesas/rcar-usb2-clock-sel.c b/drivers/clk/renesas/rcar-usb2-clock-sel.c
index cc90b11a9c250a0a..b97f5f9326cfc709 100644
--- a/drivers/clk/renesas/rcar-usb2-clock-sel.c
+++ b/drivers/clk/renesas/rcar-usb2-clock-sel.c
@@ -117,7 +117,6 @@ static int rcar_usb2_clock_sel_probe(struct platform_device *pdev)
 	struct device *dev = &pdev->dev;
 	struct device_node *np = dev->of_node;
 	struct usb2_clock_sel_priv *priv;
-	struct resource *res;
 	struct clk *clk;
 	struct clk_init_data init;
 
@@ -125,8 +124,7 @@ static int rcar_usb2_clock_sel_probe(struct platform_device *pdev)
 	if (!priv)
 		return -ENOMEM;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	priv->base = devm_ioremap_resource(dev, res);
+	priv->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(priv->base))
 		return PTR_ERR(priv->base);
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [PATCH] clk: renesas: rcar-usb2-clock-sel: Use devm_platform_ioremap_resource() helper
  2019-08-07  8:49 [PATCH] clk: renesas: rcar-usb2-clock-sel: Use devm_platform_ioremap_resource() helper Geert Uytterhoeven
@ 2019-08-08  1:58 ` Yoshihiro Shimoda
  0 siblings, 0 replies; 2+ messages in thread
From: Yoshihiro Shimoda @ 2019-08-08  1:58 UTC (permalink / raw)
  To: Geert Uytterhoeven, Michael Turquette, Stephen Boyd
  Cc: linux-renesas-soc, linux-clk

Hi Geert-san,

> From: Geert Uytterhoeven, Sent: Wednesday, August 7, 2019 5:49 PM
> 
> Use the devm_platform_ioremap_resource() helper instead of open-coding
> the same operation.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-08-08  1:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-07  8:49 [PATCH] clk: renesas: rcar-usb2-clock-sel: Use devm_platform_ioremap_resource() helper Geert Uytterhoeven
2019-08-08  1:58 ` Yoshihiro Shimoda

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).