linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Loic Poulain <loic.poulain@linaro.org>,
	bjorn.andersson@linaro.org, Mark Rutland <mark.rutland@arm.com>,
	mturquette@baylibre.com, linux-arm-msm@vger.kernel.org,
	linux-clk@vger.kernel.org, Ilia Lin <ilialin@codeaurora.org>
Subject: Re: [PATCH v2 1/4] soc: qcom: Separate kryo l2 accessors from PMU driver
Date: Fri, 3 Jul 2020 14:18:17 +0100	[thread overview]
Message-ID: <20200703131816.GC18953@willie-the-truck> (raw)
In-Reply-To: <159261263640.62212.5877307994739570385@swboyd.mtv.corp.google.com>

On Fri, Jun 19, 2020 at 05:23:56PM -0700, Stephen Boyd wrote:
> Quoting Loic Poulain (2020-06-04 03:35:24)
> > From: Ilia Lin <ilialin@codeaurora.org>
> > 
> > The driver provides kernel level API for other drivers
> > to access the MSM8996 L2 cache registers.
> > Separating the L2 access code from the PMU driver and
> > making it public to allow other drivers use it.
> > The accesses must be separated with a single spinlock,
> > maintained in this driver.
> > 
> > Signed-off-by: Ilia Lin <ilialin@codeaurora.org>
> > Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> > ---
> 
> This needs an ack from perf maintainers. Leaving the rest of the patch
> intact to help provide context.

Looks fine to me:

Acked-by: Will Deacon <will@kernel.org>

(I can't get my head round the MSR; ISB; spin_unlock() ordering, but this
is just moving code so I don't want to open that box of fun here).

Will

  reply	other threads:[~2020-07-03 13:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04 10:35 [PATCH v2 0/4] msm8996 CPU scaling support Loic Poulain
2020-06-04 10:35 ` [PATCH v2 1/4] soc: qcom: Separate kryo l2 accessors from PMU driver Loic Poulain
2020-06-20  0:23   ` Stephen Boyd
2020-07-03 13:18     ` Will Deacon [this message]
2020-06-04 10:35 ` [PATCH v2 2/4] clk: qcom: Add CPU clock driver for msm8996 Loic Poulain
2020-06-20  0:27   ` Stephen Boyd
2020-06-21  6:59     ` Bjorn Andersson
2020-06-04 10:35 ` [PATCH v2 3/4] dt-bindings: clk: qcom: Add bindings for CPU clock " Loic Poulain
2020-06-20  0:24   ` Stephen Boyd
2020-06-04 10:35 ` [PATCH v2 4/4] arch: arm64: dts: msm8996: Add opp and thermal Loic Poulain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200703131816.GC18953@willie-the-truck \
    --to=will@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=ilialin@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).