From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Rudy Lo <luhuadong@163.com>
Cc: Abel Vesa <abel.vesa@nxp.com>, Stephen Boyd <sboyd@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: imx8: Unified initcall function
Date: Thu, 8 Jul 2021 10:22:48 +0200 [thread overview]
Message-ID: <d5493844-cc7f-b432-c724-c0af97ff28eb@pengutronix.de> (raw)
In-Reply-To: <20210708081543.186820-1-luhuadong@163.com>
Hello Rudy,
On 08.07.21 10:15, Rudy Lo wrote:
> It is better to use builtin_platform_driver initcall for clk driver
> rather then module_platform_driver, refer to clk-imx8qxp.c file.
Commit messages should spell out why the change is needed, so
why do you think it's better to revert
9a976cd278ea ("clk: imx8m: Support module build")?
Cheers,
Ahmad
>
> Signed-off-by: Rudy Lo <luhuadong@163.com>
> ---
> drivers/clk/imx/clk-imx8mm.c | 2 +-
> drivers/clk/imx/clk-imx8mn.c | 2 +-
> drivers/clk/imx/clk-imx8mp.c | 2 +-
> drivers/clk/imx/clk-imx8mq.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c
> index f1919fafb124..fa20b08e64f1 100644
> --- a/drivers/clk/imx/clk-imx8mm.c
> +++ b/drivers/clk/imx/clk-imx8mm.c
> @@ -654,7 +654,7 @@ static struct platform_driver imx8mm_clk_driver = {
> .of_match_table = imx8mm_clk_of_match,
> },
> };
> -module_platform_driver(imx8mm_clk_driver);
> +builtin_platform_driver(imx8mm_clk_driver);
>
> MODULE_AUTHOR("Bai Ping <ping.bai@nxp.com>");
> MODULE_DESCRIPTION("NXP i.MX8MM clock driver");
> diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
> index 88f6630cd472..67b9ded112e4 100644
> --- a/drivers/clk/imx/clk-imx8mn.c
> +++ b/drivers/clk/imx/clk-imx8mn.c
> @@ -605,7 +605,7 @@ static struct platform_driver imx8mn_clk_driver = {
> .of_match_table = imx8mn_clk_of_match,
> },
> };
> -module_platform_driver(imx8mn_clk_driver);
> +builtin_platform_driver(imx8mn_clk_driver);
>
> MODULE_AUTHOR("Anson Huang <Anson.Huang@nxp.com>");
> MODULE_DESCRIPTION("NXP i.MX8MN clock driver");
> diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c
> index 12837304545d..cdb40e61cef0 100644
> --- a/drivers/clk/imx/clk-imx8mp.c
> +++ b/drivers/clk/imx/clk-imx8mp.c
> @@ -735,7 +735,7 @@ static struct platform_driver imx8mp_clk_driver = {
> .of_match_table = imx8mp_clk_of_match,
> },
> };
> -module_platform_driver(imx8mp_clk_driver);
> +builtin_platform_driver(imx8mp_clk_driver);
>
> MODULE_AUTHOR("Anson Huang <Anson.Huang@nxp.com>");
> MODULE_DESCRIPTION("NXP i.MX8MP clock driver");
> diff --git a/drivers/clk/imx/clk-imx8mq.c b/drivers/clk/imx/clk-imx8mq.c
> index c491bc9c61ce..54f17de30935 100644
> --- a/drivers/clk/imx/clk-imx8mq.c
> +++ b/drivers/clk/imx/clk-imx8mq.c
> @@ -630,7 +630,7 @@ static struct platform_driver imx8mq_clk_driver = {
> .of_match_table = imx8mq_clk_of_match,
> },
> };
> -module_platform_driver(imx8mq_clk_driver);
> +builtin_platform_driver(imx8mq_clk_driver);
>
> MODULE_AUTHOR("Abel Vesa <abel.vesa@nxp.com>");
> MODULE_DESCRIPTION("NXP i.MX8MQ clock driver");
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2021-07-08 8:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 8:15 [PATCH] clk: imx8: Unified initcall function Rudy Lo
2021-07-08 8:22 ` Ahmad Fatoum [this message]
2021-07-20 8:15 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5493844-cc7f-b432-c724-c0af97ff28eb@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=abel.vesa@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luhuadong@163.com \
--cc=mturquette@baylibre.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).