* [PATCH] clk: imx8: Unified initcall function
@ 2021-07-08 8:15 Rudy Lo
2021-07-08 8:22 ` Ahmad Fatoum
2021-07-20 8:15 ` Abel Vesa
0 siblings, 2 replies; 3+ messages in thread
From: Rudy Lo @ 2021-07-08 8:15 UTC (permalink / raw)
Cc: luhuadong, Abel Vesa, Michael Turquette, Stephen Boyd, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, linux-clk, linux-arm-kernel, linux-kernel
It is better to use builtin_platform_driver initcall for clk driver
rather then module_platform_driver, refer to clk-imx8qxp.c file.
Signed-off-by: Rudy Lo <luhuadong@163.com>
---
drivers/clk/imx/clk-imx8mm.c | 2 +-
drivers/clk/imx/clk-imx8mn.c | 2 +-
drivers/clk/imx/clk-imx8mp.c | 2 +-
drivers/clk/imx/clk-imx8mq.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c
index f1919fafb124..fa20b08e64f1 100644
--- a/drivers/clk/imx/clk-imx8mm.c
+++ b/drivers/clk/imx/clk-imx8mm.c
@@ -654,7 +654,7 @@ static struct platform_driver imx8mm_clk_driver = {
.of_match_table = imx8mm_clk_of_match,
},
};
-module_platform_driver(imx8mm_clk_driver);
+builtin_platform_driver(imx8mm_clk_driver);
MODULE_AUTHOR("Bai Ping <ping.bai@nxp.com>");
MODULE_DESCRIPTION("NXP i.MX8MM clock driver");
diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
index 88f6630cd472..67b9ded112e4 100644
--- a/drivers/clk/imx/clk-imx8mn.c
+++ b/drivers/clk/imx/clk-imx8mn.c
@@ -605,7 +605,7 @@ static struct platform_driver imx8mn_clk_driver = {
.of_match_table = imx8mn_clk_of_match,
},
};
-module_platform_driver(imx8mn_clk_driver);
+builtin_platform_driver(imx8mn_clk_driver);
MODULE_AUTHOR("Anson Huang <Anson.Huang@nxp.com>");
MODULE_DESCRIPTION("NXP i.MX8MN clock driver");
diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c
index 12837304545d..cdb40e61cef0 100644
--- a/drivers/clk/imx/clk-imx8mp.c
+++ b/drivers/clk/imx/clk-imx8mp.c
@@ -735,7 +735,7 @@ static struct platform_driver imx8mp_clk_driver = {
.of_match_table = imx8mp_clk_of_match,
},
};
-module_platform_driver(imx8mp_clk_driver);
+builtin_platform_driver(imx8mp_clk_driver);
MODULE_AUTHOR("Anson Huang <Anson.Huang@nxp.com>");
MODULE_DESCRIPTION("NXP i.MX8MP clock driver");
diff --git a/drivers/clk/imx/clk-imx8mq.c b/drivers/clk/imx/clk-imx8mq.c
index c491bc9c61ce..54f17de30935 100644
--- a/drivers/clk/imx/clk-imx8mq.c
+++ b/drivers/clk/imx/clk-imx8mq.c
@@ -630,7 +630,7 @@ static struct platform_driver imx8mq_clk_driver = {
.of_match_table = imx8mq_clk_of_match,
},
};
-module_platform_driver(imx8mq_clk_driver);
+builtin_platform_driver(imx8mq_clk_driver);
MODULE_AUTHOR("Abel Vesa <abel.vesa@nxp.com>");
MODULE_DESCRIPTION("NXP i.MX8MQ clock driver");
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] clk: imx8: Unified initcall function
2021-07-08 8:15 [PATCH] clk: imx8: Unified initcall function Rudy Lo
@ 2021-07-08 8:22 ` Ahmad Fatoum
2021-07-20 8:15 ` Abel Vesa
1 sibling, 0 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2021-07-08 8:22 UTC (permalink / raw)
To: Rudy Lo
Cc: Abel Vesa, Stephen Boyd, Fabio Estevam, Michael Turquette,
linux-kernel, linux-clk, NXP Linux Team, Pengutronix Kernel Team,
Shawn Guo, Sascha Hauer, linux-arm-kernel
Hello Rudy,
On 08.07.21 10:15, Rudy Lo wrote:
> It is better to use builtin_platform_driver initcall for clk driver
> rather then module_platform_driver, refer to clk-imx8qxp.c file.
Commit messages should spell out why the change is needed, so
why do you think it's better to revert
9a976cd278ea ("clk: imx8m: Support module build")?
Cheers,
Ahmad
>
> Signed-off-by: Rudy Lo <luhuadong@163.com>
> ---
> drivers/clk/imx/clk-imx8mm.c | 2 +-
> drivers/clk/imx/clk-imx8mn.c | 2 +-
> drivers/clk/imx/clk-imx8mp.c | 2 +-
> drivers/clk/imx/clk-imx8mq.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c
> index f1919fafb124..fa20b08e64f1 100644
> --- a/drivers/clk/imx/clk-imx8mm.c
> +++ b/drivers/clk/imx/clk-imx8mm.c
> @@ -654,7 +654,7 @@ static struct platform_driver imx8mm_clk_driver = {
> .of_match_table = imx8mm_clk_of_match,
> },
> };
> -module_platform_driver(imx8mm_clk_driver);
> +builtin_platform_driver(imx8mm_clk_driver);
>
> MODULE_AUTHOR("Bai Ping <ping.bai@nxp.com>");
> MODULE_DESCRIPTION("NXP i.MX8MM clock driver");
> diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
> index 88f6630cd472..67b9ded112e4 100644
> --- a/drivers/clk/imx/clk-imx8mn.c
> +++ b/drivers/clk/imx/clk-imx8mn.c
> @@ -605,7 +605,7 @@ static struct platform_driver imx8mn_clk_driver = {
> .of_match_table = imx8mn_clk_of_match,
> },
> };
> -module_platform_driver(imx8mn_clk_driver);
> +builtin_platform_driver(imx8mn_clk_driver);
>
> MODULE_AUTHOR("Anson Huang <Anson.Huang@nxp.com>");
> MODULE_DESCRIPTION("NXP i.MX8MN clock driver");
> diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c
> index 12837304545d..cdb40e61cef0 100644
> --- a/drivers/clk/imx/clk-imx8mp.c
> +++ b/drivers/clk/imx/clk-imx8mp.c
> @@ -735,7 +735,7 @@ static struct platform_driver imx8mp_clk_driver = {
> .of_match_table = imx8mp_clk_of_match,
> },
> };
> -module_platform_driver(imx8mp_clk_driver);
> +builtin_platform_driver(imx8mp_clk_driver);
>
> MODULE_AUTHOR("Anson Huang <Anson.Huang@nxp.com>");
> MODULE_DESCRIPTION("NXP i.MX8MP clock driver");
> diff --git a/drivers/clk/imx/clk-imx8mq.c b/drivers/clk/imx/clk-imx8mq.c
> index c491bc9c61ce..54f17de30935 100644
> --- a/drivers/clk/imx/clk-imx8mq.c
> +++ b/drivers/clk/imx/clk-imx8mq.c
> @@ -630,7 +630,7 @@ static struct platform_driver imx8mq_clk_driver = {
> .of_match_table = imx8mq_clk_of_match,
> },
> };
> -module_platform_driver(imx8mq_clk_driver);
> +builtin_platform_driver(imx8mq_clk_driver);
>
> MODULE_AUTHOR("Abel Vesa <abel.vesa@nxp.com>");
> MODULE_DESCRIPTION("NXP i.MX8MQ clock driver");
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clk: imx8: Unified initcall function
2021-07-08 8:15 [PATCH] clk: imx8: Unified initcall function Rudy Lo
2021-07-08 8:22 ` Ahmad Fatoum
@ 2021-07-20 8:15 ` Abel Vesa
1 sibling, 0 replies; 3+ messages in thread
From: Abel Vesa @ 2021-07-20 8:15 UTC (permalink / raw)
To: Rudy Lo
Cc: Michael Turquette, Stephen Boyd, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
linux-clk, linux-arm-kernel, linux-kernel
On 21-07-08 16:15:42, Rudy Lo wrote:
> It is better to use builtin_platform_driver initcall for clk driver
> rather then module_platform_driver, refer to clk-imx8qxp.c file.
>
NAK for now. I think this would break GKI.
> Signed-off-by: Rudy Lo <luhuadong@163.com>
> ---
> drivers/clk/imx/clk-imx8mm.c | 2 +-
> drivers/clk/imx/clk-imx8mn.c | 2 +-
> drivers/clk/imx/clk-imx8mp.c | 2 +-
> drivers/clk/imx/clk-imx8mq.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c
> index f1919fafb124..fa20b08e64f1 100644
> --- a/drivers/clk/imx/clk-imx8mm.c
> +++ b/drivers/clk/imx/clk-imx8mm.c
> @@ -654,7 +654,7 @@ static struct platform_driver imx8mm_clk_driver = {
> .of_match_table = imx8mm_clk_of_match,
> },
> };
> -module_platform_driver(imx8mm_clk_driver);
> +builtin_platform_driver(imx8mm_clk_driver);
>
> MODULE_AUTHOR("Bai Ping <ping.bai@nxp.com>");
> MODULE_DESCRIPTION("NXP i.MX8MM clock driver");
> diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
> index 88f6630cd472..67b9ded112e4 100644
> --- a/drivers/clk/imx/clk-imx8mn.c
> +++ b/drivers/clk/imx/clk-imx8mn.c
> @@ -605,7 +605,7 @@ static struct platform_driver imx8mn_clk_driver = {
> .of_match_table = imx8mn_clk_of_match,
> },
> };
> -module_platform_driver(imx8mn_clk_driver);
> +builtin_platform_driver(imx8mn_clk_driver);
>
> MODULE_AUTHOR("Anson Huang <Anson.Huang@nxp.com>");
> MODULE_DESCRIPTION("NXP i.MX8MN clock driver");
> diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c
> index 12837304545d..cdb40e61cef0 100644
> --- a/drivers/clk/imx/clk-imx8mp.c
> +++ b/drivers/clk/imx/clk-imx8mp.c
> @@ -735,7 +735,7 @@ static struct platform_driver imx8mp_clk_driver = {
> .of_match_table = imx8mp_clk_of_match,
> },
> };
> -module_platform_driver(imx8mp_clk_driver);
> +builtin_platform_driver(imx8mp_clk_driver);
>
> MODULE_AUTHOR("Anson Huang <Anson.Huang@nxp.com>");
> MODULE_DESCRIPTION("NXP i.MX8MP clock driver");
> diff --git a/drivers/clk/imx/clk-imx8mq.c b/drivers/clk/imx/clk-imx8mq.c
> index c491bc9c61ce..54f17de30935 100644
> --- a/drivers/clk/imx/clk-imx8mq.c
> +++ b/drivers/clk/imx/clk-imx8mq.c
> @@ -630,7 +630,7 @@ static struct platform_driver imx8mq_clk_driver = {
> .of_match_table = imx8mq_clk_of_match,
> },
> };
> -module_platform_driver(imx8mq_clk_driver);
> +builtin_platform_driver(imx8mq_clk_driver);
>
> MODULE_AUTHOR("Abel Vesa <abel.vesa@nxp.com>");
> MODULE_DESCRIPTION("NXP i.MX8MQ clock driver");
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-20 8:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-08 8:15 [PATCH] clk: imx8: Unified initcall function Rudy Lo
2021-07-08 8:22 ` Ahmad Fatoum
2021-07-20 8:15 ` Abel Vesa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).