From: Jeffrey Hugo <jhugo@codeaurora.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-clk <linux-clk@vger.kernel.org>,
MSM <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v1] clk: qcom: Skip halt checks on gcc_pcie_0_pipe_clk for 8998
Date: Tue, 9 Apr 2019 07:25:01 -0600 [thread overview]
Message-ID: <e88ab0f4-1b9c-78c1-7bc3-39ef6ef82aa9@codeaurora.org> (raw)
In-Reply-To: <a7e27415-02d9-bfe9-c0ea-59dc236a7f91@free.fr>
On 3/25/2019 7:49 AM, Marc Gonzalez wrote:
> See similar issue solved by commit 5f2420ed2189
> ("clk: qcom: Skip halt checks on gcc_usb3_phy_pipe_clk for 8998")
>
> Without this patch, PCIe PHY init fails:
>
> qcom-qmp-phy 1c06000.phy: pipe_clk enable failed err=-16
> phy phy-1c06000.phy.0: phy init failed --> -16
>
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
Reviewed-by: Jeffrey Hugo <jhugo@codeaurora.org>
> ---
> drivers/clk/qcom/gcc-msm8998.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/gcc-msm8998.c b/drivers/clk/qcom/gcc-msm8998.c
> index c240fba794c7..033688264c7b 100644
> --- a/drivers/clk/qcom/gcc-msm8998.c
> +++ b/drivers/clk/qcom/gcc-msm8998.c
> @@ -2161,7 +2161,7 @@ static struct clk_branch gcc_pcie_0_mstr_axi_clk = {
>
> static struct clk_branch gcc_pcie_0_pipe_clk = {
> .halt_reg = 0x6b018,
> - .halt_check = BRANCH_HALT,
> + .halt_check = BRANCH_HALT_SKIP,
> .clkr = {
> .enable_reg = 0x6b018,
> .enable_mask = BIT(0),
>
--
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2019-04-09 13:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 13:49 [PATCH v1] clk: qcom: Skip halt checks on gcc_pcie_0_pipe_clk for 8998 Marc Gonzalez
2019-03-28 16:26 ` Marc Gonzalez
2019-03-29 22:32 ` Stephen Boyd
2019-04-01 8:48 ` Marc Gonzalez
2019-10-09 8:31 ` Manu Gautam
2019-10-10 4:15 ` Stephen Boyd
2019-10-10 7:33 ` Manu Gautam
2019-10-10 19:48 ` Stephen Boyd
2019-10-11 3:47 ` Manu Gautam
2019-10-17 17:49 ` Stephen Boyd
2019-04-05 12:29 ` Marc Gonzalez
2019-04-09 13:25 ` Jeffrey Hugo [this message]
2019-04-11 20:38 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e88ab0f4-1b9c-78c1-7bc3-39ef6ef82aa9@codeaurora.org \
--to=jhugo@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).