From: Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>
To: Milan Broz <gmazyland@gmail.com>,
Pascal van Leeuwen <pascalvanl@gmail.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Cc: "rsnel@cube.dyndns.org" <rsnel@cube.dyndns.org>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: RE: [PATCH] crypto: xts - Add support for Cipher Text Stealing
Date: Wed, 7 Aug 2019 11:27:53 +0000 [thread overview]
Message-ID: <MN2PR20MB297333F0024F94C647D71AA2CAD40@MN2PR20MB2973.namprd20.prod.outlook.com> (raw)
In-Reply-To: <a0e3ce44-3e47-b8d9-2152-3fd8ba99f09a@gmail.com>
Milan,
> -----Original Message-----
> From: Milan Broz <gmazyland@gmail.com>
> Sent: Wednesday, August 7, 2019 1:20 PM
> To: Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>; Pascal van Leeuwen
> <pascalvanl@gmail.com>; linux-crypto@vger.kernel.org
> Cc: rsnel@cube.dyndns.org; herbert@gondor.apana.org.au; davem@davemloft.net
> Subject: Re: [PATCH] crypto: xts - Add support for Cipher Text Stealing
>
> Hi,
>
> On 07/08/2019 10:15, Pascal Van Leeuwen wrote:
> > I went through the code a couple of times, but I cannot spot any mistakes in
> > the lengths I'm using. Is it possible that your application is supplying a
> > buffer that is just not large enough?
>
> Seems there is no mistake in your code, it is some bug in aesni_intel implementation.
> If I disable this module, it works as expected (with aes generic and aes_i586).
>
That's odd though, considering there is a dedicated xts-aes-ni implementation,
i.e. I would not expect that to end up at the generic xts wrapper at all?
> Seems something is rewritten in call
> crypto_skcipher_encrypt(subreq);
>
> (after that call, I see rctx->rem_bytes set to 32, that does not make sense...)
>
Eh ... no, it should never become > 15 ... if it gets set to 32 somehow,
then I can at least explain why that would result in a buffer overflow :-)
> I'll check that, but not sure that understand that optimized code :)
>
> Milan
Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
www.insidesecure.com
next prev parent reply other threads:[~2019-08-07 11:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 6:55 [PATCH] crypto: xts - Add support for Cipher Text Stealing Pascal van Leeuwen
2019-08-06 18:34 ` Milan Broz
2019-08-06 19:36 ` Pascal Van Leeuwen
2019-08-07 8:15 ` Pascal Van Leeuwen
2019-08-07 11:19 ` Milan Broz
2019-08-07 11:27 ` Pascal Van Leeuwen [this message]
2019-08-07 11:41 ` Milan Broz
2019-08-07 15:13 ` Pascal Van Leeuwen
2019-08-07 17:24 ` Milan Broz
2019-08-07 20:26 ` Pascal Van Leeuwen
2019-08-07 20:32 ` Ondrej Mosnáček
2019-08-07 21:13 ` Pascal Van Leeuwen
2019-08-08 4:35 ` Milan Broz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR20MB297333F0024F94C647D71AA2CAD40@MN2PR20MB2973.namprd20.prod.outlook.com \
--to=pvanleeuwen@verimatrix.com \
--cc=davem@davemloft.net \
--cc=gmazyland@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=pascalvanl@gmail.com \
--cc=rsnel@cube.dyndns.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).