linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Milan Broz <gmazyland@gmail.com>
To: Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>,
	Pascal van Leeuwen <pascalvanl@gmail.com>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Cc: "rsnel@cube.dyndns.org" <rsnel@cube.dyndns.org>,
	"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
	"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH] crypto: xts - Add support for Cipher Text Stealing
Date: Wed, 7 Aug 2019 13:19:43 +0200	[thread overview]
Message-ID: <a0e3ce44-3e47-b8d9-2152-3fd8ba99f09a@gmail.com> (raw)
In-Reply-To: <MN2PR20MB2973A38A300804281CA6A109CAD40@MN2PR20MB2973.namprd20.prod.outlook.com>

Hi,

On 07/08/2019 10:15, Pascal Van Leeuwen wrote:
> I went through the code a couple of times, but I cannot spot any mistakes in
> the lengths I'm using. Is it possible that your application is supplying a
> buffer that is just not large enough?

Seems there is no mistake in your code, it is some bug in aesni_intel implementation.
If I disable this module, it works as expected (with aes generic and aes_i586).

Seems something is rewritten in call
  crypto_skcipher_encrypt(subreq);

(after that call, I see rctx->rem_bytes set to 32, that does not make sense...)

I'll check that, but not sure that understand that optimized code :)

Milan

  reply	other threads:[~2019-08-07 11:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-06  6:55 [PATCH] crypto: xts - Add support for Cipher Text Stealing Pascal van Leeuwen
2019-08-06 18:34 ` Milan Broz
2019-08-06 19:36   ` Pascal Van Leeuwen
2019-08-07  8:15     ` Pascal Van Leeuwen
2019-08-07 11:19       ` Milan Broz [this message]
2019-08-07 11:27         ` Pascal Van Leeuwen
2019-08-07 11:41           ` Milan Broz
2019-08-07 15:13             ` Pascal Van Leeuwen
2019-08-07 17:24               ` Milan Broz
2019-08-07 20:26                 ` Pascal Van Leeuwen
2019-08-07 20:32                 ` Ondrej Mosnáček
2019-08-07 21:13                   ` Pascal Van Leeuwen
2019-08-08  4:35                     ` Milan Broz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0e3ce44-3e47-b8d9-2152-3fd8ba99f09a@gmail.com \
    --to=gmazyland@gmail.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=pascalvanl@gmail.com \
    --cc=pvanleeuwen@verimatrix.com \
    --cc=rsnel@cube.dyndns.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).