From: Guo Ren <guoren@kernel.org>
To: Mao Han <han_mao@c-sky.com>
Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org
Subject: Re: [PATCH V4 2/6] csky: Add count-width property for csky pmu
Date: Tue, 4 Jun 2019 13:35:45 +0800 [thread overview]
Message-ID: <CAJF2gTTKg_q6muyXMUW-5rUKOAnfQfY_suAKDJE3VbNHT4Vy9w@mail.gmail.com> (raw)
In-Reply-To: <d38f72230b838419a1ef829dcb27373807d697b5.1559614824.git.han_mao@c-sky.com>
Hi Mao,
On Tue, Jun 4, 2019 at 10:25 AM Mao Han <han_mao@c-sky.com> wrote:
>
> The csky pmu counter may have different io width. When the counter is
> smaller then 64 bits and counter value is smaller than the old value, it
> will result to a extremely large delta value. So the sampled value should
> be extend to 64 bits to avoid this, the extension bits base on the
> count-width property from dts.
>
> Signed-off-by: Mao Han <han_mao@c-sky.com>
> Cc: Guo Ren <guoren@kernel.org>
> ---
> arch/csky/kernel/perf_event.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/arch/csky/kernel/perf_event.c b/arch/csky/kernel/perf_event.c
> index c022acc..36f7f20 100644
> --- a/arch/csky/kernel/perf_event.c
> +++ b/arch/csky/kernel/perf_event.c
> @@ -9,6 +9,7 @@
> #include <linux/platform_device.h>
>
> #define CSKY_PMU_MAX_EVENTS 32
> +#define DEFAULT_COUNT_WIDTH 48
>
> #define HPCR "<0, 0x0>" /* PMU Control reg */
> #define HPCNTENR "<0, 0x4>" /* Count Enable reg */
> @@ -18,6 +19,7 @@ static void (*hw_raw_write_mapping[CSKY_PMU_MAX_EVENTS])(uint64_t val);
>
> struct csky_pmu_t {
> struct pmu pmu;
> + uint32_t count_width;
> uint32_t hpcr;
> } csky_pmu;
>
> @@ -806,7 +808,12 @@ static void csky_perf_event_update(struct perf_event *event,
> struct hw_perf_event *hwc)
> {
> uint64_t prev_raw_count = local64_read(&hwc->prev_count);
> - uint64_t new_raw_count = hw_raw_read_mapping[hwc->idx]();
> + /*
> + * Sign extend count value to 64bit, otherwise delta calculation
> + * would be incorrect when overflow occurs.
> + */
> + uint64_t new_raw_count = sign_extend64(
> + hw_raw_read_mapping[hwc->idx](), csky_pmu.count_width);
csky_pmu.count_width - 1 ? we need index here.
Best Regards
Guo Ren
next prev parent reply other threads:[~2019-06-04 5:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 2:23 [PATCH V4 0/6] csky: Add pmu hardware sampling support Mao Han
2019-06-04 2:23 ` [PATCH V4 1/6] csky: Init pmu as a device Mao Han
2019-06-04 5:50 ` Guo Ren
2019-06-04 2:23 ` [PATCH V4 2/6] csky: Add count-width property for csky pmu Mao Han
2019-06-04 5:35 ` Guo Ren [this message]
2019-06-04 2:23 ` [PATCH V4 3/6] csky: Add pmu interrupt support Mao Han
2019-06-04 6:31 ` Guo Ren
2019-06-04 2:23 ` [PATCH V4 4/6] dt-bindings: csky: Add csky PMU bindings Mao Han
2019-06-04 5:38 ` Guo Ren
2019-06-04 2:23 ` [PATCH V4 5/6] csky: Fixup some error count in 810 & 860 Mao Han
2019-06-04 2:24 ` [PATCH V4 6/6] csky: Fix perf record in kernel/user space Mao Han
2019-06-04 6:36 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJF2gTTKg_q6muyXMUW-5rUKOAnfQfY_suAKDJE3VbNHT4Vy9w@mail.gmail.com \
--to=guoren@kernel.org \
--cc=han_mao@c-sky.com \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).