From: Guo Ren <guoren@kernel.org>
To: Mao Han <han_mao@c-sky.com>
Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org
Subject: Re: [PATCH V4 1/6] csky: Init pmu as a device
Date: Tue, 4 Jun 2019 13:50:03 +0800 [thread overview]
Message-ID: <CAJF2gTTV5byJkCU4Z-NMvD+W8K7J56mmYNaXdchb+z-rbQm+1w@mail.gmail.com> (raw)
In-Reply-To: <40e0b27c342458360f9f30ef16026cb63e792850.1559614824.git.han_mao@c-sky.com>
Hello Mao,
On Tue, Jun 4, 2019 at 10:25 AM Mao Han <han_mao@c-sky.com> wrote:
>
> This patch change the csky pmu initialization from arch init to
> device init. The pmu can be configued with information from
> device tree(pmu device name, irq number and etc.).
>
> Signed-off-by: Mao Han <han_mao@c-sky.com>
> Cc: Guo Ren <guoren@kernel.org>
> ---
> arch/csky/kernel/perf_event.c | 58 ++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 57 insertions(+), 1 deletion(-)
>
> diff --git a/arch/csky/kernel/perf_event.c b/arch/csky/kernel/perf_event.c
> index 376c972..c022acc 100644
> --- a/arch/csky/kernel/perf_event.c
> +++ b/arch/csky/kernel/perf_event.c
> @@ -21,6 +21,8 @@ struct csky_pmu_t {
> uint32_t hpcr;
> } csky_pmu;
>
> +typedef int (*csky_pmu_init)(struct csky_pmu_t *);
Is the type of csky_pmu_init() the same with init_hw_perf_events ?
And I also think you should remove the hook style, because there
is only one init for the driver.
> +
> #define cprgr(reg) \
> ({ \
> unsigned int tmp; \
> @@ -1028,4 +1030,58 @@ int __init init_hw_perf_events(void)
>
> return perf_pmu_register(&csky_pmu.pmu, "cpu", PERF_TYPE_RAW);
> }
> -arch_initcall(init_hw_perf_events);
> +
> +int csky_pmu_device_probe(struct platform_device *pdev,
> + const struct of_device_id *of_table)
> +{
> + const struct of_device_id *of_id;
> + csky_pmu_init init_fn;
> + struct device_node *node = pdev->dev.of_node;
> + int ret = -ENODEV;
> +
> + of_id = of_match_node(of_table, pdev->dev.of_node);
> + if (node && of_id) {
> + init_fn = of_id->data;
> + ret = init_fn(&csky_pmu);
> + }
Ditto, all 7 lines above should be removed and use directly like:
ret = init_hw_perf_events();
> + if (ret) {
> + pr_notice("[perf] failed to probe PMU!\n");
> + return ret;
> + }
> +
> + return ret;
> +}
> +
> +const static struct of_device_id csky_pmu_of_device_ids[] = {
> + {.compatible = "csky,csky-pmu", .data = init_hw_perf_events},
Ditto, Nothing for .data.
Best Regards
Guo Ren
next prev parent reply other threads:[~2019-06-04 5:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 2:23 [PATCH V4 0/6] csky: Add pmu hardware sampling support Mao Han
2019-06-04 2:23 ` [PATCH V4 1/6] csky: Init pmu as a device Mao Han
2019-06-04 5:50 ` Guo Ren [this message]
2019-06-04 2:23 ` [PATCH V4 2/6] csky: Add count-width property for csky pmu Mao Han
2019-06-04 5:35 ` Guo Ren
2019-06-04 2:23 ` [PATCH V4 3/6] csky: Add pmu interrupt support Mao Han
2019-06-04 6:31 ` Guo Ren
2019-06-04 2:23 ` [PATCH V4 4/6] dt-bindings: csky: Add csky PMU bindings Mao Han
2019-06-04 5:38 ` Guo Ren
2019-06-04 2:23 ` [PATCH V4 5/6] csky: Fixup some error count in 810 & 860 Mao Han
2019-06-04 2:24 ` [PATCH V4 6/6] csky: Fix perf record in kernel/user space Mao Han
2019-06-04 6:36 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJF2gTTV5byJkCU4Z-NMvD+W8K7J56mmYNaXdchb+z-rbQm+1w@mail.gmail.com \
--to=guoren@kernel.org \
--cc=han_mao@c-sky.com \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).