From: sibis@codeaurora.org
To: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Jeffrey Hugo <jhugo@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>,
Jonathan Marek <jonathan@marek.ca>,
Ohad Ben-Cohen <ohad@wizery.com>,
Mark Rutland <mark.rutland@arm.com>,
p.zabel@pengutronix.de, MSM <linux-arm-msm@vger.kernel.org>,
linux-remoteproc@vger.kernel.org,
DTML <devicetree@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Andy Gross <agross@kernel.org>,
linux-remoteproc-owner@vger.kernel.org
Subject: Re: [PATCH 13/16] arm64: dts: qcom: msm8998: Update reserved memory map
Date: Tue, 19 Nov 2019 12:28:29 +0000 [thread overview]
Message-ID: <0101016e83a2b64f-7d9f9170-7720-4198-adae-7f39a846c432-000000@us-west-2.amazonses.com> (raw)
In-Reply-To: <CAOCk7NogQY3Vjo+cL5_0anVO=K1LfTqG69b8AGi9HQsTMEsCug@mail.gmail.com>
Hey Jeff,
Thanks for taking time to review
the series.
On 2019-11-19 03:34, Jeffrey Hugo wrote:
> On Mon, Nov 18, 2019 at 2:45 PM Sibi Sankar <sibis@codeaurora.org>
> wrote:
>>
>> Update existing and add missing regions to the reserved memory map, as
>> described in version 7.1
>>
>> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>> ---
>> arch/arm64/boot/dts/qcom/msm8998.dtsi | 62
>> ++++++++++++++++++++++++---
>> 1 file changed, 55 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> b/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> index fc7838ea9a010..707673e3cf28a 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> @@ -28,8 +28,13 @@
>> #size-cells = <2>;
>> ranges;
>>
>> - memory@85800000 {
>> - reg = <0x0 0x85800000 0x0 0x800000>;
>> + hyp_mem: memory@85800000 {
>> + reg = <0x0 0x85800000 0x0 0x600000>;
>> + no-map;
>> + };
>> +
>> + xbl_mem: memory@85e00000 {
>
> Are we ever going to use this label?
just leaving it here for info with the
added benefit of being deleteable
if MSM8998 uses a different boot chain
where xbl_mem/tz_mem remains unused as
in the case of Cheza
>
>> + reg = <0x0 0x85e00000 0x0 0x100000>;
>> no-map;
>> };
>>
>> @@ -38,21 +43,64 @@
>> no-map;
>> };
>>
>> - memory@86200000 {
>> + tz_mem: memory@86200000 {
>
> Again, are we ever going to use this?
ditto
>
>> reg = <0x0 0x86200000 0x0 0x2d00000>;
>> no-map;
>> };
>>
>> - rmtfs {
>> + rmtfs_mem: memory@88f00000 {
>> compatible = "qcom,rmtfs-mem";
>> -
>> - size = <0x0 0x200000>;
>> - alloc-ranges = <0x0 0xa0000000 0x0 0x2000000>;
>> + reg = <0x0 0x88f00000 0x0 0x200000>;
>
> This seems to overlap with a defined region in the memory map.
> 0x9fa00000 seems to be a better address.
just following the what we did
for SDM845 SoC 0x88f00000 should
be safe to use.
>
>> no-map;
>>
>> qcom,client-id = <1>;
>> qcom,vmid = <15>;
>> };
>> +
>> + spss_mem: memory@8ab00000 {
>> + reg = <0x0 0x8ab00000 0x0 0x700000>;
>> + no-map;
>> + };
>> +
>> + adsp_mem: memory@8b200000 {
>> + reg = <0x0 0x8b200000 0x0 0x1a00000>;
>> + no-map;
>> + };
>> +
>> + mpss_mem: memory@8cc00000 {
>> + reg = <0x0 0x8cc00000 0x0 0x7000000>;
>> + no-map;
>> + };
>> +
>> + venus_mem: memory@93c00000 {
>> + reg = <0x0 0x93c00000 0x0 0x500000>;
>> + no-map;
>> + };
>> +
>> + mba_mem: memory@94100000 {
>> + reg = <0x0 0x94100000 0x0 0x200000>;
>> + no-map;
>> + };
>> +
>> + slpi_mem: memory@94300000 {
>> + reg = <0x0 0x94300000 0x0 0xf00000>;
>> + no-map;
>> + };
>> +
>> + ipa_fw_mem: memory@95200000 {
>> + reg = <0x0 0x95200000 0x0 0x10000>;
>> + no-map;
>> + };
>> +
>> + ipa_gsi_mem: memory@95210000 {
>> + reg = <0x0 0x95210000 0x0 0x5000>;
>> + no-map;
>> + };
>> +
>> + gpu_mem: memory@95215000 {
>> + reg = <0x0 0x95215000 0x0 0x1000>;
>
> This is the wrong size for the zap region.
double checked the memory maps,
gpu mem size is mentioned as 4kb
is that not the case?
>
>> + no-map;
>> + };
>> };
>>
>> clocks {
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum,
>> a Linux Foundation Collaborative Project
>>
next prev parent reply other threads:[~2019-11-19 12:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191118214250.14002-1-sibis@codeaurora.org>
2019-11-18 21:43 ` [PATCH 01/16] remoteproc: q6v5-mss: fixup MSM8998 MSS out of reset sequence Sibi Sankar
2019-11-18 21:54 ` Jeffrey Hugo
2019-11-19 15:25 ` Sibi Sankar
[not found] ` <0101016e844504f1-d8bd27a5-c0bf-4b0b-8301-7bd8a890be80-000000@us-west-2.amazonses.com>
2019-11-19 15:43 ` Jeffrey Hugo
2019-11-20 12:01 ` Sibi Sankar
2019-11-18 21:43 ` [PATCH 02/16] remoteproc: q6v5-mss: Streamline the " Sibi Sankar
2019-11-18 21:43 ` [PATCH 03/16] dt-bindings: remoteproc: qcom: Add Q6V5 Modem PIL binding for SC7180 Sibi Sankar
2019-11-22 23:12 ` Rob Herring
2019-11-18 21:43 ` [PATCH 04/16] remoteproc: mss: q6v5-mss: Add modem support on SC7180 Sibi Sankar
2019-11-18 21:43 ` [PATCH 05/16] remoteproc: qcom: pas: Disable interrupt on clock enable failure Sibi Sankar
2019-11-18 21:43 ` [PATCH 06/16] dt-bindings: remoteproc: qcom: Add power-domain bindings for Q6V5 PAS Sibi Sankar
2019-11-22 23:15 ` Rob Herring
2019-11-18 21:43 ` [PATCH 07/16] remoteproc: qcom: pas: Vote for active/proxy power domains Sibi Sankar
2019-11-18 21:43 ` [PATCH 08/16] dt-bindings: remoteproc: qcom: Add ADSP and SLPI support for MSM8998 SoC Sibi Sankar
2019-12-03 22:01 ` Rob Herring
2019-11-18 21:43 ` [PATCH 09/16] remoteproc: qcom: pas: Add MSM8998 ADSP and SLPI support Sibi Sankar
2019-11-18 21:43 ` [PATCH 10/16] dt-bindings: remoteproc: qcom: SM8150 Add ADSP, CDSP, MPSS " Sibi Sankar
2019-12-03 22:02 ` Rob Herring
2019-11-18 21:43 ` [PATCH 11/16] remoteproc: qcom: pas: Add SM8150 ADSP, CDSP, Modem " Sibi Sankar
2019-11-18 21:44 ` [PATCH 12/16] remoteproc: qcom: pas: Add auto_boot flag Sibi Sankar
2019-11-18 21:44 ` [PATCH 13/16] arm64: dts: qcom: msm8998: Update reserved memory map Sibi Sankar
2019-11-18 22:04 ` Jeffrey Hugo
2019-11-19 12:28 ` sibis [this message]
2019-11-18 21:44 ` [PATCH 14/16] arm64: dts: qcom: msm8998: Add ADSP, MPSS and SLPI nodes Sibi Sankar
2019-11-18 22:07 ` Jeffrey Hugo
2019-11-19 12:29 ` sibis
2019-11-18 21:44 ` [PATCH 15/16] arm64: dts: qcom: sm8150: Add ADSP, CDSP, MPSS and SLPI smp2p Sibi Sankar
2019-11-18 21:44 ` [PATCH 16/16] arm64: dts: qcom: sm8150: Add ADSP, CDSP, MPSS and SLPI remoteprocs Sibi Sankar
2019-12-17 0:19 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0101016e83a2b64f-7d9f9170-7720-4198-adae-7f39a846c432-000000@us-west-2.amazonses.com \
--to=sibis@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=jhugo@codeaurora.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc-owner@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ohad@wizery.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).