From: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
To: Sibi Sankar <sibis@codeaurora.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Jeffrey Hugo <jhugo@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>,
Jonathan Marek <jonathan@marek.ca>,
Ohad Ben-Cohen <ohad@wizery.com>,
Mark Rutland <mark.rutland@arm.com>,
p.zabel@pengutronix.de, MSM <linux-arm-msm@vger.kernel.org>,
linux-remoteproc@vger.kernel.org,
DTML <devicetree@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Andy Gross <agross@kernel.org>
Subject: Re: [PATCH 01/16] remoteproc: q6v5-mss: fixup MSM8998 MSS out of reset sequence
Date: Tue, 19 Nov 2019 08:43:45 -0700 [thread overview]
Message-ID: <CAOCk7NpVDNRxkPUTHbsG_WC4MrjU8_JcdgiuyYbb36RPTMrOWQ@mail.gmail.com> (raw)
In-Reply-To: <0101016e844504f1-d8bd27a5-c0bf-4b0b-8301-7bd8a890be80-000000@us-west-2.amazonses.com>
On Tue, Nov 19, 2019 at 8:25 AM Sibi Sankar <sibis@codeaurora.org> wrote:
>
> Hey Jeff,
>
> On 11/19/19 3:24 AM, Jeffrey Hugo wrote:
> > On Mon, Nov 18, 2019 at 2:43 PM Sibi Sankar <sibis@codeaurora.org> wrote:
> >>
> >> Fixup the following in the MSS out of reset sequence on MSM8998:
> >> * skip ACC override on MSM8998.
> >> * wait for BHS_EN_REST_ACK to be set before setting the LDO to bypass.
> >> * remove "mem" clock from the active pool.
> >
> > Why any of this is necessary isn't explained.
>
> Honestly the above two fixes didn't seem to have any impact when I
> tested it on MSM8998 MTP just making sure that we allign with the
> out of reset sequence found on msm-4.4.
That should be mentioned in the commit text then.
>
> > Seems like it should be 3 separate patches.
> > Regarding the mem clock change, wouldn't it be an issue if we don't
> > vote for that?
>
> we already proxy vote for it though.
Ah, so we do. That should be mentioned in the commit text.
>
> >
> >>
> >> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> >> ---
> >> drivers/remoteproc/qcom_q6v5_mss.c | 23 ++++++++++++++++++++---
> >> 1 file changed, 20 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
> >> index 471128a2e7239..2becf6dade936 100644
> >> --- a/drivers/remoteproc/qcom_q6v5_mss.c
> >> +++ b/drivers/remoteproc/qcom_q6v5_mss.c
> >> @@ -100,6 +100,11 @@
> >> #define QDSP6SS_XO_CBCR 0x0038
> >> #define QDSP6SS_ACC_OVERRIDE_VAL 0x20
> >>
> >> +/* QDSP6v62 parameters */
> >> +#define QDSP6SS_BHS_EN_REST_ACK BIT(0)
> >> +#define BHS_CHECK_MAX_LOOPS 200
> >> +#define QDSP6SS_BHS_STATUS 0x0C4
> >> +
> >> /* QDSP6v65 parameters */
> >> #define QDSP6SS_SLEEP 0x3C
> >> #define QDSP6SS_BOOT_CORE_START 0x400
> >> @@ -505,8 +510,9 @@ static int q6v5proc_reset(struct q6v5 *qproc)
> >> int mem_pwr_ctl;
> >>
> >> /* Override the ACC value if required */
> >> - writel(QDSP6SS_ACC_OVERRIDE_VAL,
> >> - qproc->reg_base + QDSP6SS_STRAP_ACC);
> >> + if (qproc->version == MSS_MSM8996)
> >> + writel(QDSP6SS_ACC_OVERRIDE_VAL,
> >> + qproc->reg_base + QDSP6SS_STRAP_ACC);
> >>
> >> /* Assert resets, stop core */
> >> val = readl(qproc->reg_base + QDSP6SS_RESET_REG);
> >> @@ -534,6 +540,18 @@ static int q6v5proc_reset(struct q6v5 *qproc)
> >> val |= readl(qproc->reg_base + QDSP6SS_PWR_CTL_REG);
> >> udelay(1);
> >>
> >> + /* wait for BHS_EN_REST_ACK to be set */
> >> + if (qproc->version == MSS_MSM8998) {
> >> + ret = readl_poll_timeout(qproc->reg_base + QDSP6SS_BHS_STATUS,
> >> + val, (val & QDSP6SS_BHS_EN_REST_ACK),
> >> + 1, BHS_CHECK_MAX_LOOPS);
> >> + if (ret) {
> >> + dev_err(qproc->dev,
> >> + "QDSP6SS_BHS_EN_REST_ACK timedout\n");
> >> + return -ETIMEDOUT;
> >> + }
> >> + }
> >> +
> >> /* Put LDO in bypass mode */
> >> val |= QDSP6v56_LDO_BYP;
> >> writel(val, qproc->reg_base + QDSP6SS_PWR_CTL_REG);
> >> @@ -1594,7 +1612,6 @@ static const struct rproc_hexagon_res msm8998_mss = {
> >> .active_clk_names = (char*[]){
> >> "iface",
> >> "bus",
> >> - "mem",
> >> "gpll0_mss",
> >> "mnoc_axi",
> >> "snoc_axi",
> >> --
> >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> >> a Linux Foundation Collaborative Project
> >>
> >
>
> --
> Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc, is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2019-11-19 15:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191118214250.14002-1-sibis@codeaurora.org>
2019-11-18 21:43 ` [PATCH 01/16] remoteproc: q6v5-mss: fixup MSM8998 MSS out of reset sequence Sibi Sankar
2019-11-18 21:54 ` Jeffrey Hugo
2019-11-19 15:25 ` Sibi Sankar
[not found] ` <0101016e844504f1-d8bd27a5-c0bf-4b0b-8301-7bd8a890be80-000000@us-west-2.amazonses.com>
2019-11-19 15:43 ` Jeffrey Hugo [this message]
2019-11-20 12:01 ` Sibi Sankar
2019-11-18 21:43 ` [PATCH 02/16] remoteproc: q6v5-mss: Streamline the " Sibi Sankar
2019-11-18 21:43 ` [PATCH 03/16] dt-bindings: remoteproc: qcom: Add Q6V5 Modem PIL binding for SC7180 Sibi Sankar
2019-11-22 23:12 ` Rob Herring
2019-11-18 21:43 ` [PATCH 04/16] remoteproc: mss: q6v5-mss: Add modem support on SC7180 Sibi Sankar
2019-11-18 21:43 ` [PATCH 05/16] remoteproc: qcom: pas: Disable interrupt on clock enable failure Sibi Sankar
2019-11-18 21:43 ` [PATCH 06/16] dt-bindings: remoteproc: qcom: Add power-domain bindings for Q6V5 PAS Sibi Sankar
2019-11-22 23:15 ` Rob Herring
2019-11-18 21:43 ` [PATCH 07/16] remoteproc: qcom: pas: Vote for active/proxy power domains Sibi Sankar
2019-11-18 21:43 ` [PATCH 08/16] dt-bindings: remoteproc: qcom: Add ADSP and SLPI support for MSM8998 SoC Sibi Sankar
2019-12-03 22:01 ` Rob Herring
2019-11-18 21:43 ` [PATCH 09/16] remoteproc: qcom: pas: Add MSM8998 ADSP and SLPI support Sibi Sankar
2019-11-18 21:43 ` [PATCH 10/16] dt-bindings: remoteproc: qcom: SM8150 Add ADSP, CDSP, MPSS " Sibi Sankar
2019-12-03 22:02 ` Rob Herring
2019-11-18 21:43 ` [PATCH 11/16] remoteproc: qcom: pas: Add SM8150 ADSP, CDSP, Modem " Sibi Sankar
2019-11-18 21:44 ` [PATCH 12/16] remoteproc: qcom: pas: Add auto_boot flag Sibi Sankar
2019-11-18 21:44 ` [PATCH 13/16] arm64: dts: qcom: msm8998: Update reserved memory map Sibi Sankar
2019-11-18 22:04 ` Jeffrey Hugo
2019-11-19 12:28 ` sibis
2019-11-18 21:44 ` [PATCH 14/16] arm64: dts: qcom: msm8998: Add ADSP, MPSS and SLPI nodes Sibi Sankar
2019-11-18 22:07 ` Jeffrey Hugo
2019-11-19 12:29 ` sibis
2019-11-18 21:44 ` [PATCH 15/16] arm64: dts: qcom: sm8150: Add ADSP, CDSP, MPSS and SLPI smp2p Sibi Sankar
2019-11-18 21:44 ` [PATCH 16/16] arm64: dts: qcom: sm8150: Add ADSP, CDSP, MPSS and SLPI remoteprocs Sibi Sankar
2019-12-17 0:19 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOCk7NpVDNRxkPUTHbsG_WC4MrjU8_JcdgiuyYbb36RPTMrOWQ@mail.gmail.com \
--to=jeffrey.l.hugo@gmail.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jhugo@codeaurora.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ohad@wizery.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).