* [PATCH v5 00/27] clk: bcm: rpi: Add support for BCM2711 firmware clocks
@ 2020-06-15 8:40 Maxime Ripard
2020-06-15 8:40 ` [PATCH v5 02/27] dt-bindings: clock: Add a binding for the RPi Firmware clocks Maxime Ripard
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Maxime Ripard @ 2020-06-15 8:40 UTC (permalink / raw)
To: Nicolas Saenz Julienne
Cc: linux-rpi-kernel, bcm-kernel-feedback-list, linux-arm-kernel,
linux-kernel, Dave Stevenson, Tim Gover, Phil Elwell,
Mike Turquette, Stephen Boyd, linux-clk, Philipp Zabel,
Maxime Ripard, devicetree, Kamal Dasu, Rob Herring
Hi,
Since the whole DRM/HDMI support began to grow fairly big, I've chosen
to split away the two discussions between the firmware clocks and the
HDMI support.
Let me know what you think,
Maxime
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: devicetree@vger.kernel.org
Cc: Kamal Dasu <kdasu.kdev@gmail.com>
Cc: linux-clk@vger.kernel.org
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Stephen Boyd <sboyd@kernel.org>
Changes from v4:
- Rebased on 5.8-rc1
- Added more tags
- Fixed a typo in a variable name
Changes from v3:
- Moved the firmware structure to the driver, and changed for u32
- Prevented cache issues with MMIO driver
- Removed message when discovering min and max rates
- Added the gathered tags
Changes from v2:
- Rebased on top of next-20200526
- Split away from the HDMI series
- Fixed an of_node leakage in the firmware driver
- Fixed an of_node leakage in the firmware clocks driver
- Added the min/max rate retrieval to all the firmware clocks
- Added proper name for the firmware clocks
- Removed the PLLB setup from the firmware clocks and moved it back to
the MMIO driver
Florian Fainelli (1):
dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML
Maxime Ripard (26):
dt-bindings: clock: Add a binding for the RPi Firmware clocks
firmware: rpi: Only create clocks device if we don't have a node for it
clk: bcm: rpi: Allow the driver to be probed by DT
clk: bcm: rpi: Statically init clk_init_data
clk: bcm: rpi: Use clk_hw_register for pllb_arm
clk: bcm: rpi: Remove global pllb_arm clock pointer
clk: bcm: rpi: Make sure pllb_arm is removed
clk: bcm: rpi: Remove pllb_arm_lookup global pointer
clk: bcm: rpi: Switch to clk_hw_register_clkdev
clk: bcm: rpi: Make sure the clkdev lookup is removed
clk: bcm: rpi: Use CCF boundaries instead of rolling our own
clk: bcm: rpi: Create a data structure for the clocks
clk: bcm: rpi: Add clock id to data
clk: bcm: rpi: Pass the clocks data to the firmware function
clk: bcm: rpi: Rename is_prepared function
clk: bcm: rpi: Split pllb clock hooks
clk: bcm: rpi: Make the PLLB registration function return a clk_hw
clk: bcm: rpi: Add DT provider for the clocks
clk: bcm: rpi: Add an enum for the firmware clocks
clk: bcm: rpi: Discover the firmware clocks
clk: bcm: rpi: Give firmware clocks a name
Revert "clk: bcm2835: remove pllb"
ARM: dts: bcm2711: Add firmware clocks node
clk: bcm2835: Allow custom CCF flags for the PLLs
clk: bcm2835: Don't cache the PLLB rate
clk: bcm: rpi: Remove the quirks for the CPU clock
Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.txt | 14 +---
Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml | 59 ++++++++++++++-
arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 5 +-
drivers/clk/bcm/clk-bcm2835.c | 34 ++++++--
drivers/clk/bcm/clk-raspberrypi.c | 311 +++++++++++++++++++++++++++++++++++++++++++-----------------------------
drivers/firmware/raspberrypi.c | 14 +++-
6 files changed, 294 insertions(+), 143 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.txt
create mode 100644 Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
base-commit: b3a9e3b9622ae10064826dccb4f7a52bd88c7407
--
git-series 0.9.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v5 02/27] dt-bindings: clock: Add a binding for the RPi Firmware clocks
2020-06-15 8:40 [PATCH v5 00/27] clk: bcm: rpi: Add support for BCM2711 firmware clocks Maxime Ripard
@ 2020-06-15 8:40 ` Maxime Ripard
2020-06-25 0:42 ` Stephen Boyd
2020-06-19 9:37 ` [PATCH v5 00/27] clk: bcm: rpi: Add support for BCM2711 firmware clocks Stephen Boyd
2020-06-25 1:15 ` Stephen Boyd
2 siblings, 1 reply; 11+ messages in thread
From: Maxime Ripard @ 2020-06-15 8:40 UTC (permalink / raw)
To: Nicolas Saenz Julienne
Cc: linux-rpi-kernel, bcm-kernel-feedback-list, linux-arm-kernel,
linux-kernel, Dave Stevenson, Tim Gover, Phil Elwell,
Mike Turquette, Stephen Boyd, linux-clk, Philipp Zabel,
Maxime Ripard, devicetree, Rob Herring
The firmware running on the RPi VideoCore can be used to discover and
change the various clocks running in the BCM2711. Since devices will
need to use them through the DT, let's add a pretty simple binding.
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: linux-clk@vger.kernel.org
Cc: devicetree@vger.kernel.org
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Reviewed-by: Rob Herring <robh+dt@kernel.org>
Tested-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
index cec540c052b6..b48ed875eb8e 100644
--- a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
+++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
@@ -22,6 +22,25 @@ properties:
Phandle to the firmware device's Mailbox.
(See: ../mailbox/mailbox.txt for more information)
+ clocks:
+ type: object
+
+ properties:
+ compatible:
+ const: raspberrypi,firmware-clocks
+
+ "#clock-cells":
+ const: 1
+ description: >
+ The argument is the ID of the clocks contained by the
+ firmware messages.
+
+ required:
+ - compatible
+ - "#clock-cells"
+
+ additionalProperties: false
+
required:
- compatible
- mboxes
@@ -31,5 +50,10 @@ examples:
firmware {
compatible = "raspberrypi,bcm2835-firmware", "simple-bus";
mboxes = <&mailbox>;
+
+ firmware_clocks: clocks {
+ compatible = "raspberrypi,firmware-clocks";
+ #clock-cells = <1>;
+ };
};
...
--
git-series 0.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v5 00/27] clk: bcm: rpi: Add support for BCM2711 firmware clocks
2020-06-15 8:40 [PATCH v5 00/27] clk: bcm: rpi: Add support for BCM2711 firmware clocks Maxime Ripard
2020-06-15 8:40 ` [PATCH v5 02/27] dt-bindings: clock: Add a binding for the RPi Firmware clocks Maxime Ripard
@ 2020-06-19 9:37 ` Stephen Boyd
2020-06-19 9:44 ` Nicolas Saenz Julienne
2020-06-19 11:52 ` Maxime Ripard
2020-06-25 1:15 ` Stephen Boyd
2 siblings, 2 replies; 11+ messages in thread
From: Stephen Boyd @ 2020-06-19 9:37 UTC (permalink / raw)
To: Maxime Ripard, Nicolas Saenz Julienne
Cc: linux-rpi-kernel, bcm-kernel-feedback-list, linux-arm-kernel,
linux-kernel, Dave Stevenson, Tim Gover, Phil Elwell,
Mike Turquette, linux-clk, Philipp Zabel, Maxime Ripard,
devicetree, Kamal Dasu, Rob Herring
Quoting Maxime Ripard (2020-06-15 01:40:40)
> Hi,
>
> Since the whole DRM/HDMI support began to grow fairly big, I've chosen
> to split away the two discussions between the firmware clocks and the
> HDMI support.
>
> Let me know what you think,
> Maxime
Do you want this to go through clk tree? Or looking for acks/review
tags?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5 00/27] clk: bcm: rpi: Add support for BCM2711 firmware clocks
2020-06-19 9:37 ` [PATCH v5 00/27] clk: bcm: rpi: Add support for BCM2711 firmware clocks Stephen Boyd
@ 2020-06-19 9:44 ` Nicolas Saenz Julienne
2020-06-19 23:57 ` Stephen Boyd
2020-06-19 11:52 ` Maxime Ripard
1 sibling, 1 reply; 11+ messages in thread
From: Nicolas Saenz Julienne @ 2020-06-19 9:44 UTC (permalink / raw)
To: Stephen Boyd, Maxime Ripard
Cc: devicetree, Tim Gover, Dave Stevenson, Mike Turquette,
Kamal Dasu, linux-kernel, linux-clk, Rob Herring,
bcm-kernel-feedback-list, linux-rpi-kernel, Philipp Zabel,
Phil Elwell, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 527 bytes --]
On Fri, 2020-06-19 at 02:37 -0700, Stephen Boyd wrote:
> Quoting Maxime Ripard (2020-06-15 01:40:40)
> > Hi,
> >
> > Since the whole DRM/HDMI support began to grow fairly big, I've chosen
> > to split away the two discussions between the firmware clocks and the
> > HDMI support.
> >
> > Let me know what you think,
> > Maxime
>
> Do you want this to go through clk tree? Or looking for acks/review
> tags?
>
FWIW I don't mind taking the device tree changes trough the RPi soc tree.
Regards,
Nicolas
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5 00/27] clk: bcm: rpi: Add support for BCM2711 firmware clocks
2020-06-19 9:37 ` [PATCH v5 00/27] clk: bcm: rpi: Add support for BCM2711 firmware clocks Stephen Boyd
2020-06-19 9:44 ` Nicolas Saenz Julienne
@ 2020-06-19 11:52 ` Maxime Ripard
2020-06-19 23:57 ` Stephen Boyd
1 sibling, 1 reply; 11+ messages in thread
From: Maxime Ripard @ 2020-06-19 11:52 UTC (permalink / raw)
To: Stephen Boyd
Cc: Nicolas Saenz Julienne, linux-rpi-kernel,
bcm-kernel-feedback-list, linux-arm-kernel, linux-kernel,
Dave Stevenson, Tim Gover, Phil Elwell, Mike Turquette,
linux-clk, Philipp Zabel, devicetree, Kamal Dasu, Rob Herring
[-- Attachment #1: Type: text/plain, Size: 593 bytes --]
Hi Stephen,
On Fri, Jun 19, 2020 at 02:37:37AM -0700, Stephen Boyd wrote:
> Quoting Maxime Ripard (2020-06-15 01:40:40)
> > Hi,
> >
> > Since the whole DRM/HDMI support began to grow fairly big, I've chosen
> > to split away the two discussions between the firmware clocks and the
> > HDMI support.
> >
> > Let me know what you think,
> > Maxime
>
> Do you want this to go through clk tree? Or looking for acks/review
> tags?
As far as I understood, you usually apply the bcm patches to the clk
tree directly, so if you could apply them it would be awesome :)
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5 00/27] clk: bcm: rpi: Add support for BCM2711 firmware clocks
2020-06-19 9:44 ` Nicolas Saenz Julienne
@ 2020-06-19 23:57 ` Stephen Boyd
2020-06-20 0:20 ` Stephen Boyd
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Boyd @ 2020-06-19 23:57 UTC (permalink / raw)
To: Maxime Ripard, Nicolas Saenz Julienne
Cc: devicetree, Tim Gover, Dave Stevenson, Mike Turquette,
Kamal Dasu, linux-kernel, linux-clk, Rob Herring,
bcm-kernel-feedback-list, linux-rpi-kernel, Philipp Zabel,
Phil Elwell, linux-arm-kernel
Quoting Nicolas Saenz Julienne (2020-06-19 02:44:54)
> On Fri, 2020-06-19 at 02:37 -0700, Stephen Boyd wrote:
> > Quoting Maxime Ripard (2020-06-15 01:40:40)
> > > Hi,
> > >
> > > Since the whole DRM/HDMI support began to grow fairly big, I've chosen
> > > to split away the two discussions between the firmware clocks and the
> > > HDMI support.
> > >
> > > Let me know what you think,
> > > Maxime
> >
> > Do you want this to go through clk tree? Or looking for acks/review
> > tags?
> >
>
> FWIW I don't mind taking the device tree changes trough the RPi soc tree.
>
Sounds good.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5 00/27] clk: bcm: rpi: Add support for BCM2711 firmware clocks
2020-06-19 11:52 ` Maxime Ripard
@ 2020-06-19 23:57 ` Stephen Boyd
0 siblings, 0 replies; 11+ messages in thread
From: Stephen Boyd @ 2020-06-19 23:57 UTC (permalink / raw)
To: Maxime Ripard
Cc: Nicolas Saenz Julienne, linux-rpi-kernel,
bcm-kernel-feedback-list, linux-arm-kernel, linux-kernel,
Dave Stevenson, Tim Gover, Phil Elwell, Mike Turquette,
linux-clk, Philipp Zabel, devicetree, Kamal Dasu, Rob Herring
Quoting Maxime Ripard (2020-06-19 04:52:55)
> Hi Stephen,
>
> On Fri, Jun 19, 2020 at 02:37:37AM -0700, Stephen Boyd wrote:
> > Quoting Maxime Ripard (2020-06-15 01:40:40)
> > > Hi,
> > >
> > > Since the whole DRM/HDMI support began to grow fairly big, I've chosen
> > > to split away the two discussions between the firmware clocks and the
> > > HDMI support.
> > >
> > > Let me know what you think,
> > > Maxime
> >
> > Do you want this to go through clk tree? Or looking for acks/review
> > tags?
>
> As far as I understood, you usually apply the bcm patches to the clk
> tree directly, so if you could apply them it would be awesome :)
>
Ok. Thanks for letting me know.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5 00/27] clk: bcm: rpi: Add support for BCM2711 firmware clocks
2020-06-19 23:57 ` Stephen Boyd
@ 2020-06-20 0:20 ` Stephen Boyd
2020-06-25 0:40 ` Stephen Boyd
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Boyd @ 2020-06-20 0:20 UTC (permalink / raw)
To: Maxime Ripard, Nicolas Saenz Julienne
Cc: devicetree, Tim Gover, Kamal Dasu, Mike Turquette,
Dave Stevenson, linux-kernel, Phil Elwell, Rob Herring,
bcm-kernel-feedback-list, linux-rpi-kernel, Philipp Zabel,
linux-clk, linux-arm-kernel
Quoting Stephen Boyd (2020-06-19 16:57:10)
> Quoting Nicolas Saenz Julienne (2020-06-19 02:44:54)
> > On Fri, 2020-06-19 at 02:37 -0700, Stephen Boyd wrote:
> > > Quoting Maxime Ripard (2020-06-15 01:40:40)
> > > > Hi,
> > > >
> > > > Since the whole DRM/HDMI support began to grow fairly big, I've chosen
> > > > to split away the two discussions between the firmware clocks and the
> > > > HDMI support.
> > > >
> > > > Let me know what you think,
> > > > Maxime
> > >
> > > Do you want this to go through clk tree? Or looking for acks/review
> > > tags?
> > >
> >
> > FWIW I don't mind taking the device tree changes trough the RPi soc tree.
> >
>
> Sounds good.
>
Just to clarify, that is just the dts patch? Or the binding patches too?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5 00/27] clk: bcm: rpi: Add support for BCM2711 firmware clocks
2020-06-20 0:20 ` Stephen Boyd
@ 2020-06-25 0:40 ` Stephen Boyd
0 siblings, 0 replies; 11+ messages in thread
From: Stephen Boyd @ 2020-06-25 0:40 UTC (permalink / raw)
To: Maxime Ripard, Nicolas Saenz Julienne
Cc: devicetree, Tim Gover, Kamal Dasu, Mike Turquette,
Dave Stevenson, linux-kernel, Phil Elwell, Rob Herring,
bcm-kernel-feedback-list, linux-rpi-kernel, Philipp Zabel,
linux-clk, linux-arm-kernel
Quoting Stephen Boyd (2020-06-19 17:20:24)
> Quoting Stephen Boyd (2020-06-19 16:57:10)
> > Quoting Nicolas Saenz Julienne (2020-06-19 02:44:54)
> > > On Fri, 2020-06-19 at 02:37 -0700, Stephen Boyd wrote:
> > > > Quoting Maxime Ripard (2020-06-15 01:40:40)
> > > > > Hi,
> > > > >
> > > > > Since the whole DRM/HDMI support began to grow fairly big, I've chosen
> > > > > to split away the two discussions between the firmware clocks and the
> > > > > HDMI support.
> > > > >
> > > > > Let me know what you think,
> > > > > Maxime
> > > >
> > > > Do you want this to go through clk tree? Or looking for acks/review
> > > > tags?
> > > >
> > >
> > > FWIW I don't mind taking the device tree changes trough the RPi soc tree.
> > >
> >
> > Sounds good.
> >
>
> Just to clarify, that is just the dts patch? Or the binding patches too?
Ok. I'll push everything out now and you can tell me to undo that if
it's wrong.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5 02/27] dt-bindings: clock: Add a binding for the RPi Firmware clocks
2020-06-15 8:40 ` [PATCH v5 02/27] dt-bindings: clock: Add a binding for the RPi Firmware clocks Maxime Ripard
@ 2020-06-25 0:42 ` Stephen Boyd
0 siblings, 0 replies; 11+ messages in thread
From: Stephen Boyd @ 2020-06-25 0:42 UTC (permalink / raw)
To: Maxime Ripard, Nicolas Saenz Julienne
Cc: linux-rpi-kernel, bcm-kernel-feedback-list, linux-arm-kernel,
linux-kernel, Dave Stevenson, Tim Gover, Phil Elwell,
Mike Turquette, linux-clk, Philipp Zabel, Maxime Ripard,
devicetree, Rob Herring
Quoting Maxime Ripard (2020-06-15 01:40:42)
> The firmware running on the RPi VideoCore can be used to discover and
> change the various clocks running in the BCM2711. Since devices will
> need to use them through the DT, let's add a pretty simple binding.
>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: linux-clk@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Reviewed-by: Stephen Boyd <sboyd@kernel.org>
> Reviewed-by: Rob Herring <robh+dt@kernel.org>
> Tested-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5 00/27] clk: bcm: rpi: Add support for BCM2711 firmware clocks
2020-06-15 8:40 [PATCH v5 00/27] clk: bcm: rpi: Add support for BCM2711 firmware clocks Maxime Ripard
2020-06-15 8:40 ` [PATCH v5 02/27] dt-bindings: clock: Add a binding for the RPi Firmware clocks Maxime Ripard
2020-06-19 9:37 ` [PATCH v5 00/27] clk: bcm: rpi: Add support for BCM2711 firmware clocks Stephen Boyd
@ 2020-06-25 1:15 ` Stephen Boyd
2 siblings, 0 replies; 11+ messages in thread
From: Stephen Boyd @ 2020-06-25 1:15 UTC (permalink / raw)
To: Maxime Ripard, Nicolas Saenz Julienne
Cc: linux-rpi-kernel, bcm-kernel-feedback-list, linux-arm-kernel,
linux-kernel, Dave Stevenson, Tim Gover, Phil Elwell,
Mike Turquette, linux-clk, Philipp Zabel, Maxime Ripard,
devicetree, Kamal Dasu, Rob Herring
Quoting Maxime Ripard (2020-06-15 01:40:40)
> Hi,
>
> Since the whole DRM/HDMI support began to grow fairly big, I've chosen
> to split away the two discussions between the firmware clocks and the
> HDMI support.
>
I see one problem.
WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/bcm/clk-bcm2711-dvp.o
Can you send a followup patch to fix this?
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-06-25 1:15 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-15 8:40 [PATCH v5 00/27] clk: bcm: rpi: Add support for BCM2711 firmware clocks Maxime Ripard
2020-06-15 8:40 ` [PATCH v5 02/27] dt-bindings: clock: Add a binding for the RPi Firmware clocks Maxime Ripard
2020-06-25 0:42 ` Stephen Boyd
2020-06-19 9:37 ` [PATCH v5 00/27] clk: bcm: rpi: Add support for BCM2711 firmware clocks Stephen Boyd
2020-06-19 9:44 ` Nicolas Saenz Julienne
2020-06-19 23:57 ` Stephen Boyd
2020-06-20 0:20 ` Stephen Boyd
2020-06-25 0:40 ` Stephen Boyd
2020-06-19 11:52 ` Maxime Ripard
2020-06-19 23:57 ` Stephen Boyd
2020-06-25 1:15 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).