From: Rob Herring <robh@kernel.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Dave Stevenson <dave.stevenson@raspberrypi.org>,
Eric Anholt <eric@anholt.net>,
Stefan Wahren <stefan.wahren@i2se.com>,
Linus Walleij <linus.walleij@linaro.org>,
devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
Michael Zoran <mzoran@crowfest.net>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH v3 2/4] dt-bindings: gpio: add raspberry pi GPIO expander binding
Date: Mon, 29 Jan 2018 10:11:34 -0600 [thread overview]
Message-ID: <20180129161134.tm6dhsygvbt3ogxf@rob-hp-laptop> (raw)
In-Reply-To: <248ce2c6c79b281261184a0ccde8513a9074af4c.1516105893.git.baruch@tkos.co.il>
On Tue, Jan 16, 2018 at 02:45:08PM +0200, Baruch Siach wrote:
> The Raspberry Pi 3 GPIO expander is controlled by the VC4 firmware over
> I2C. The firmware mailbox interface allows the ARM core to control the
> GPIO lines.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> v3:
> * Rename node name.
>
> v2:
> * Rename compatible string to raspberrypi,firmware-gpio
> ---
> .../bindings/gpio/raspberrypi,firmware-gpio.txt | 24 ++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/raspberrypi,firmware-gpio.txt
>
> diff --git a/Documentation/devicetree/bindings/gpio/raspberrypi,firmware-gpio.txt b/Documentation/devicetree/bindings/gpio/raspberrypi,firmware-gpio.txt
> new file mode 100644
> index 000000000000..936dc59eba12
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/raspberrypi,firmware-gpio.txt
> @@ -0,0 +1,24 @@
> +Raspberry Pi GPIO expander
> +
> +The Raspberry Pi 3 GPIO expander is controlled by the VC4 firmware. The
> +firmware exposes a mailbox interface that allows the ARM core to control the
> +GPIO lines on the expander.
> +
> +Required properties:
> +
> +- compatible : Should be "raspberrypi,firmware-gpio"
> +- gpio-controller : Marks the device node as a gpio controller
> +- #gpio-cells : Should be two. The first cell is the pin number, and
> + the second cell is used to specify the gpio polarity:
> + 0 = active high
> + 1 = active low
> +- firmware : Reference to the RPi firmware device node
> +
> +Example:
> +
> +expgpio: gpio-expander {
Still not right. The correct generic node name is "gpio".
> + compatible = "raspberrypi,firmware-gpio";
> + gpio-controller;
> + #gpio-cells = <2>;
> + firmware = <&firmware>;
Can you make this a child of the firmware node instead?
Rob
next prev parent reply other threads:[~2018-01-29 16:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 12:45 [PATCH v3 0/4] gpio: driver for the RPi3 GPIO expander Baruch Siach
2018-01-16 12:45 ` [PATCH v3 1/4] ARM: bcm2835: sync firmware properties with downstream Baruch Siach
[not found] ` <cover.1516105893.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2018-01-16 12:45 ` [PATCH v3 2/4] dt-bindings: gpio: add raspberry pi GPIO expander binding Baruch Siach
2018-01-29 16:11 ` Rob Herring [this message]
2018-01-29 16:30 ` Baruch Siach
2018-02-06 13:42 ` [PATCH v3 0/4] gpio: driver for the RPi3 GPIO expander Linus Walleij
[not found] ` <CACRpkdZAtVfAU-k9EUihH6peY2d1Ntn3jboVMBn9adReNLupow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-06 16:27 ` Baruch Siach
2018-02-07 9:13 ` Linus Walleij
2018-02-07 9:33 ` Stefan Wahren
[not found] ` <a3e4ba9a-60bf-5038-7385-8cb3d2667ed2-eS4NqCHxEME@public.gmane.org>
2018-02-07 9:38 ` Baruch Siach
2018-02-07 10:20 ` Stefan Wahren
2018-01-16 12:45 ` [PATCH v3 3/4] gpio: raspberrypi-exp: Driver for RPi3 GPIO expander via mailbox service Baruch Siach
[not found] ` <1a2829a6cb5edc951f9d8f322882916ab9cea67c.1516105893.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2018-01-19 18:50 ` Stefan Wahren
2018-01-16 12:45 ` [PATCH v3 4/4] ARM: dts: bcm2837-rpi-3-b: add GPIO expander Baruch Siach
2018-01-17 8:30 ` Stefan Wahren
[not found] ` <6c07ab6a-a2c6-284e-6205-58d2512d0256-eS4NqCHxEME@public.gmane.org>
2018-01-17 9:39 ` Linus Walleij
2018-01-19 18:52 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180129161134.tm6dhsygvbt3ogxf@rob-hp-laptop \
--to=robh@kernel.org \
--cc=baruch@tkos.co.il \
--cc=dave.stevenson@raspberrypi.org \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=frowand.list@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mzoran@crowfest.net \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).