devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
Cc: Dave Stevenson
	<dave.stevenson-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>,
	Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>,
	Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Michael Zoran <mzoran-O+n0w2l5AFbk1uMJSBkQmQ@public.gmane.org>,
	linux-rpi-kernel
	<linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	Linux ARM
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Frank Rowand
	<frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v3 0/4] gpio: driver for the RPi3 GPIO expander
Date: Tue, 6 Feb 2018 14:42:48 +0100	[thread overview]
Message-ID: <CACRpkdZAtVfAU-k9EUihH6peY2d1Ntn3jboVMBn9adReNLupow@mail.gmail.com> (raw)
In-Reply-To: <cover.1516105893.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>

On Tue, Jan 16, 2018 at 1:45 PM, Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org> wrote:

> The Raspberry Pi 3 has a GPIO expander that controls, among others, the
> activity LED, and the camera connector GPIOs. The GPIO expander on an I2C bus
> that is not directly controlled from the ARM core. The VC4 firmware controls
> the I2C bus, and allows the ARM core to set/get GPIO settings over its mailbox
> interface.
>
> This series adds support for the RPi3 expander.
>
> The driver is ported from the downstream kernel at
> https://github.com/raspberrypi/linux/, branch rpi-4.9.y.
>
> Changes in v3:
>
>   * Kconfig tweaks
>   * Check rpi_exp_gpio_get_polarity() return value
>   * Redundant header removal
>   * Redundant platform_set_drvdata() call removal
>   * Small coding style changes

All is looking pretty good. I see Rob had some last minute comments,
but please rebase and repost post v4.16-rc1 so we can get this merged,
we need to get this upstream.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2018-02-06 13:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-16 12:45 [PATCH v3 0/4] gpio: driver for the RPi3 GPIO expander Baruch Siach
2018-01-16 12:45 ` [PATCH v3 1/4] ARM: bcm2835: sync firmware properties with downstream Baruch Siach
     [not found] ` <cover.1516105893.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2018-01-16 12:45   ` [PATCH v3 2/4] dt-bindings: gpio: add raspberry pi GPIO expander binding Baruch Siach
2018-01-29 16:11     ` Rob Herring
2018-01-29 16:30       ` Baruch Siach
2018-02-06 13:42   ` Linus Walleij [this message]
     [not found]     ` <CACRpkdZAtVfAU-k9EUihH6peY2d1Ntn3jboVMBn9adReNLupow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-06 16:27       ` [PATCH v3 0/4] gpio: driver for the RPi3 GPIO expander Baruch Siach
2018-02-07  9:13         ` Linus Walleij
2018-02-07  9:33         ` Stefan Wahren
     [not found]           ` <a3e4ba9a-60bf-5038-7385-8cb3d2667ed2-eS4NqCHxEME@public.gmane.org>
2018-02-07  9:38             ` Baruch Siach
2018-02-07 10:20               ` Stefan Wahren
2018-01-16 12:45 ` [PATCH v3 3/4] gpio: raspberrypi-exp: Driver for RPi3 GPIO expander via mailbox service Baruch Siach
     [not found]   ` <1a2829a6cb5edc951f9d8f322882916ab9cea67c.1516105893.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2018-01-19 18:50     ` Stefan Wahren
2018-01-16 12:45 ` [PATCH v3 4/4] ARM: dts: bcm2837-rpi-3-b: add GPIO expander Baruch Siach
2018-01-17  8:30   ` Stefan Wahren
     [not found]     ` <6c07ab6a-a2c6-284e-6205-58d2512d0256-eS4NqCHxEME@public.gmane.org>
2018-01-17  9:39       ` Linus Walleij
2018-01-19 18:52   ` Stefan Wahren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdZAtVfAU-k9EUihH6peY2d1Ntn3jboVMBn9adReNLupow@mail.gmail.com \
    --to=linus.walleij-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
    --cc=baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org \
    --cc=dave.stevenson-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org \
    --cc=frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mzoran-O+n0w2l5AFbk1uMJSBkQmQ@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=stefan.wahren-eS4NqCHxEME@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).