From: Stephen Boyd <sboyd@kernel.org>
To: Brian Masney <masneyb@onstation.org>,
dmitry.torokhov@gmail.com, robh+dt@kernel.org
Cc: mark.rutland@arm.com, agross@kernel.org,
bjorn.andersson@linaro.org, mturquette@baylibre.com,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 4/7] dt-bindings: Input: introduce new clock vibrator bindings
Date: Sun, 05 Jan 2020 00:35:33 -0800 [thread overview]
Message-ID: <20200105083534.01EB12071A@mail.kernel.org> (raw)
In-Reply-To: <20191205002503.13088-5-masneyb@onstation.org>
Quoting Brian Masney (2019-12-04 16:25:00)
> diff --git a/Documentation/devicetree/bindings/input/clk-vibrator.yaml b/Documentation/devicetree/bindings/input/clk-vibrator.yaml
> new file mode 100644
> index 000000000000..2103a5694fad
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/clk-vibrator.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/bindings/input/clk-vibrator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Clock vibrator
> +
> +maintainers:
> + - Brian Masney <masneyb@onstation.org>
> +
> +description: |
> + Support for clock-based vibrator devices where the speed can be controlled
> + by changing the duty cycle.
> +
> +properties:
> + compatible:
> + const: clk-vibrator
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + description: output clock that controls the speed
> + items:
> + - const: core
> +
> + clock-frequency: true
Can you use assigned-clock-rates for this instead? Then the driver can
call clk_get_rate() if it wants to know the rate that was actually set
on the clk.
> +
> + enable-gpios:
> + maxItems: 1
> +
> + vcc-supply:
> + description: Regulator that provides power
> +
> +required:
> + - compatible
> + - clocks
> + - clock-names
> + - clock-frequency
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,mmcc-msm8974.h>
> + #include <dt-bindings/gpio/gpio.h>
> +
> + vibrator {
> + compatible = "clk-vibrator";
> +
> + vcc-supply = <&pm8941_l19>;
> +
> + clocks = <&mmcc CAMSS_GP1_CLK>;
> + clock-names = "core";
> + clock-frequency = <24000>;
> +
> + enable-gpios = <&msmgpio 60 GPIO_ACTIVE_HIGH>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&vibrator_pin>;
I'm still trying to wrap my head around this. I think we can have a pwm
provider in a clk controller node (so imagine &mmcc has #pwm-cells) and
then this 'clk-vibrator' binding wouldn't exist? Instead we would have
some sort of binding for a device that expects a pwm and whatever else
is required, like the enable gpio and power supply. Is there an actual
hardware block that is this way? Does it have a real product id and is
made by some company? Right now this looks a little too generic to not
just be a catch-all for something that buzzes.
next prev parent reply other threads:[~2020-01-05 8:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 0:24 [PATCH 0/7] qcom: add clk-vibrator driver Brian Masney
2019-12-05 0:24 ` [PATCH 1/7] clk: qcom: add support for setting the duty cycle Brian Masney
2019-12-10 4:47 ` Taniya Das
2020-02-12 23:23 ` Stephen Boyd
[not found] ` <0101016eee224b50-8a5545e2-837f-41c2-9574-b385e111a6b3-000000@us-west-2.amazonses.com>
2019-12-10 11:51 ` Brian Masney
2019-12-13 13:56 ` Linus Walleij
2019-12-05 0:24 ` [PATCH 2/7] dt-bindings: Input: drop msm-vibrator in favor of clk-vibrator Brian Masney
2019-12-17 14:11 ` Rob Herring
2019-12-05 0:24 ` [PATCH 3/7] Input: drop msm-vibrator in favor of clk-vibrator driver Brian Masney
2020-02-11 12:18 ` Brian Masney
2019-12-05 0:25 ` [PATCH 4/7] dt-bindings: Input: introduce new clock vibrator bindings Brian Masney
2019-12-05 13:56 ` Rob Herring
2019-12-09 0:54 ` Brian Masney
2019-12-09 16:16 ` Rob Herring
2019-12-09 16:55 ` Brian Masney
2020-01-05 8:35 ` Stephen Boyd [this message]
2020-01-07 12:03 ` Brian Masney
2020-01-07 17:52 ` Stephen Boyd
2020-01-07 23:18 ` Brian Masney
2019-12-05 0:25 ` [PATCH 5/7] Input: introduce new clock vibrator driver Brian Masney
2019-12-05 0:25 ` [PATCH 6/7] ARM: qcom_defconfig: drop msm-vibrator in favor of clk-vibrator driver Brian Masney
2019-12-05 0:25 ` [PATCH 7/7] ARM: dts: qcom: msm8974-hammerhead: add support for vibrator Brian Masney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200105083534.01EB12071A@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masneyb@onstation.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).