From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Jonathan Cameron <jic23@kernel.org>, <linux-iio@vger.kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
<devicetree@vger.kernel.org>, "Rob Herring" <robh@kernel.org>
Subject: Re: [PATCH] iio: st-sensors: Update ST Sensor bindings
Date: Mon, 12 Jul 2021 14:56:39 +0100 [thread overview]
Message-ID: <20210712145639.00004604@Huawei.com> (raw)
In-Reply-To: <20210712130444.bois24oukqmxpg27@gilmour>
On Mon, 12 Jul 2021 15:04:44 +0200
Maxime Ripard <maxime@cerno.tech> wrote:
> Hi,
>
> On Mon, Apr 12, 2021 at 02:23:31PM +0200, Linus Walleij wrote:
> > This adjusts the ST Sensor bindings with the more fine-grained
> > syntax checks that were proposed late in the last kernel cycle
> > and colliding with parallel work.
> >
> > Cc: devicetree@vger.kernel.org
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> I'm not really sure of how I supposed to fix this, but this creates an
> issue on the Pinephone
> (arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts) that has a
> LIS3MDL with only the DRDY pin routed and thus only has a single
> interrupt in the DT.
>
> One of the if condition in that patch enforces that there's two
> interrupts for the LIS3MDL, but it's not really clear to me why after
> looking at the datasheet?
It shouldn't be enforcing that 2 are specified rather that 2 'might' be
specified. maxItems is set, but not minItems.
Driver wise, at the moment it looks like we only handle one interrupt.
So to handle selection when two are possible and either 1 or 2 might
be wired up we need to add interrupt names (with default order so we
don't break anything before adding them to the binding).
Would that work for this device?
Jonathan
>
> Maxime
>
next prev parent reply other threads:[~2021-07-12 13:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 12:23 [PATCH] iio: st-sensors: Update ST Sensor bindings Linus Walleij
2021-04-18 10:09 ` Jonathan Cameron
2021-07-12 13:04 ` Maxime Ripard
2021-07-12 13:56 ` Jonathan Cameron [this message]
2021-07-12 14:16 ` Maxime Ripard
2021-07-12 14:28 ` Jonathan Cameron
2021-07-15 12:29 ` Maxime Ripard
2021-07-14 8:26 ` Linus Walleij
2021-07-15 12:21 ` Maxime Ripard
2022-01-26 14:59 ` Geert Uytterhoeven
2022-01-28 15:51 ` Linus Walleij
2022-01-28 15:57 ` Linus Walleij
2022-01-28 16:14 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2021-01-04 9:33 Linus Walleij
2021-01-09 21:49 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210712145639.00004604@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).