Re: [PATCH] iio: st-sensors: Update ST Sensor bindings

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Linus,

On Fri, Jan 28, 2022 at 4:57 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> On Fri, Jan 28, 2022 at 4:51 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> > On Wed, Jan 26, 2022 at 3:59 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > On Mon, Apr 12, 2021 at 2:24 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> >
> > > >    interrupts:
> > > > +    description: interrupt line(s) connected to the DRDY line(s) and/or the
> > > > +      Intertial interrupt lines INT1 and INT2 if these exist. This means up to
> > > > +      three interrupts, and the DRDY must be the first one if it exists on
> > >
> > > So this says three (the LSM9DS0 datasheet agrees)...
> > >
> > > > +      the package. The trigger edge of the interrupts is sometimes software
> > > > +      configurable in the hardware so the operating system should parse this
> > > > +      flag and set up the trigger edge as indicated in the device tree.
> > > >      minItems: 1
> > > > +    maxItems: 2
> > >
> > > ... while this says two?
> >
> > Looks like a bug, could you send a patch? (I'm a bit preoccupied right now.)
>
> Oh wait a minute, LSM9DS0 is one of those with more than one component
> inside it isn't it?

Yes it is. And thus it needs 2 device nodes in DT.

> While it is a bit awkward, we do bindings per-subcomponent on these, so
> for example lsm330dlc registers as "st,lsm330dlc-accel" and "st,lsm330dlc-gyro"
> and it makes a bit of sense because they each have different I2C addresses
> as well.
>
> I see it as two components just sharing a physical package rather than one
> component in a package.
>
> So the IRQs are per-subcomponent, not for the entire package.

OK, that makes sense.

> Does this influence the situation you have with LSM9DS0?

Yes, it does. Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds