[PATCH v4] Tegra: DT: add device tree binding doc for QSPI

[PATCH v4] Tegra: DT: add device tree binding doc for QSPI

[Tom Warren]

This patch adds the device tree binding doc for the Tegra
QSPI controller on Tegra210.

Signed-off-by: Tom Warren <twarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
Changes in v2:
- based it more on kernel's nvidia,tegra114-spi.txt binding
- changes based on prelim review by swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
Changes in v3:
- renamed to 'nvidia,tegra210-qspi.txt' to match kernel bindings
- more changes based on review from swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
Changes in v4:
- move 'clock' up under 'clock-names' entry

 Documentation/devicetree/bindings/spi/nvidia,tegra210-qspi.txt | 42 ++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/spi/nvidia,tegra210-qspi.txt

diff --git a/Documentation/devicetree/bindings/spi/nvidia,tegra210-qspi.txt b/Documentation/devicetree/bindings/spi/nvidia,tegra210-qspi.txt
new file mode 100644
index 0000000..fe1558f
--- /dev/null
+++ b/Documentation/devicetree/bindings/spi/nvidia,tegra210-qspi.txt
@@ -0,0 +1,42 @@
+NVIDIA Tegra QSPI controller.
+
+Required properties:
+- compatible : for Tegra210, must contain "nvidia,tegra210-qspi".
+- reg: Should contain QSPI registers location and length.
+- interrupts: Should contain QSPI interrupt.
+- clock-names : Must include the following entries:
+  - qspi
+- clocks : Must contain an entry for each entry in clock-names.
+  See ../clocks/clock-bindings.txt for details.
+- resets : Must contain an entry for each entry in reset-names.
+  See ../reset/reset.txt for details.
+- reset-names : Must include the following entries:
+  - qspi
+
+Optional properties:
+- dmas : Must contain an entry for each entry in clock-names.
+  See ../dma/dma.txt for details.
+- dma-names : Must include the following entries:
+  - rx
+  - tx
+
+Recommended properties:
+- spi-max-frequency: Definition as per spi-bus.txt
+
+Example:
+
+spi@70410000 {
+	compatible = "nvidia,tegra210-qspi";
+	reg = <0x0 0x70410000 0x0 0x1000>;
+	interrupts = <0 10 0x04>;
+	spi-max-frequency = <24000000>;
+	#address-cells = <1>;
+	#size-cells = <0>;
+	clocks = <&tegra_car 211>;
+	clock-names = "qspi";
+	resets = <&tegra_car 211>;
+	reset-names = "qspi";
+	dmas = <&apbdma 16>, <&apbdma 16>;
+	dma-names = "rx", "tx";
+	status = "disabled";
+};
-- 
1.8.2.1.610.g562af5b

Re: [PATCH v4] Tegra: DT: add device tree binding doc for QSPI

[Stephen Warren]

On 10/26/2015 04:22 PM, Tom Warren wrote:
> This patch adds the device tree binding doc for the Tegra
> QSPI controller on Tegra210.

Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

(I assume if others approve the binding, Thierry will take it through 
the Tegra tree)

Re: [PATCH v4] Tegra: DT: add device tree binding doc for QSPI

[Rob Herring]

On Mon, Oct 26, 2015 at 5:22 PM, Tom Warren <twarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> wrote:
> This patch adds the device tree binding doc for the Tegra
> QSPI controller on Tegra210.
>
> Signed-off-by: Tom Warren <twarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

> ---
> Changes in v2:
> - based it more on kernel's nvidia,tegra114-spi.txt binding
> - changes based on prelim review by swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
> Changes in v3:
> - renamed to 'nvidia,tegra210-qspi.txt' to match kernel bindings
> - more changes based on review from swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
> Changes in v4:
> - move 'clock' up under 'clock-names' entry
>
>  Documentation/devicetree/bindings/spi/nvidia,tegra210-qspi.txt | 42 ++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/spi/nvidia,tegra210-qspi.txt
>
> diff --git a/Documentation/devicetree/bindings/spi/nvidia,tegra210-qspi.txt b/Documentation/devicetree/bindings/spi/nvidia,tegra210-qspi.txt
> new file mode 100644
> index 0000000..fe1558f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/nvidia,tegra210-qspi.txt
> @@ -0,0 +1,42 @@
> +NVIDIA Tegra QSPI controller.
> +
> +Required properties:
> +- compatible : for Tegra210, must contain "nvidia,tegra210-qspi".
> +- reg: Should contain QSPI registers location and length.
> +- interrupts: Should contain QSPI interrupt.
> +- clock-names : Must include the following entries:
> +  - qspi
> +- clocks : Must contain an entry for each entry in clock-names.
> +  See ../clocks/clock-bindings.txt for details.
> +- resets : Must contain an entry for each entry in reset-names.
> +  See ../reset/reset.txt for details.
> +- reset-names : Must include the following entries:
> +  - qspi
> +
> +Optional properties:
> +- dmas : Must contain an entry for each entry in clock-names.
> +  See ../dma/dma.txt for details.
> +- dma-names : Must include the following entries:
> +  - rx
> +  - tx
> +
> +Recommended properties:
> +- spi-max-frequency: Definition as per spi-bus.txt
> +
> +Example:
> +
> +spi@70410000 {
> +       compatible = "nvidia,tegra210-qspi";
> +       reg = <0x0 0x70410000 0x0 0x1000>;
> +       interrupts = <0 10 0x04>;
> +       spi-max-frequency = <24000000>;
> +       #address-cells = <1>;
> +       #size-cells = <0>;
> +       clocks = <&tegra_car 211>;
> +       clock-names = "qspi";
> +       resets = <&tegra_car 211>;
> +       reset-names = "qspi";
> +       dmas = <&apbdma 16>, <&apbdma 16>;
> +       dma-names = "rx", "tx";
> +       status = "disabled";
> +};
> --
> 1.8.2.1.610.g562af5b
>

Re: [PATCH v4] Tegra: DT: add device tree binding doc for QSPI

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 567 bytes --]

On Mon, Oct 26, 2015 at 05:02:53PM -0600, Stephen Warren wrote:
> On 10/26/2015 04:22 PM, Tom Warren wrote:
> >This patch adds the device tree binding doc for the Tegra
> >QSPI controller on Tegra210.
> 
> Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> (I assume if others approve the binding, Thierry will take it through the
> Tegra tree)

Do we have a kernel driver and hardware where this can be tested? I'm
slightly reluctant to merge a binding through the Tegra tree without a
driver that implements it.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH v4] Tegra: DT: add device tree binding doc for QSPI

[Stephen Warren]

On 11/09/2015 05:45 AM, Thierry Reding wrote:
> On Mon, Oct 26, 2015 at 05:02:53PM -0600, Stephen Warren wrote:
>> On 10/26/2015 04:22 PM, Tom Warren wrote:
>>> This patch adds the device tree binding doc for the Tegra
>>> QSPI controller on Tegra210.
>>
>> Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>>
>> (I assume if others approve the binding, Thierry will take it through the
>> Tegra tree)
>
> Do we have a kernel driver and hardware where this can be tested? I'm
> slightly reluctant to merge a binding through the Tegra tree without a
> driver that implements it.

AFAIK, the only HW this can be tested on is a one-off modified version 
of p2571. The standard boards don't have this. I don't believe there's 
an (upstream at least) kernel driver for this. I'm sure downstream has a 
driver.