From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-pm@vger.kernel.org, linux-usb@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Brown <broonie@kernel.org>
Cc: tjakobi@math.uni-bielefeld.de, m.szyprowski@samsung.com,
hverkuil@xs4all.nl,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [RFC v2 11/13] usb: port: Parse pwrseq phandle from Device Tree
Date: Thu, 5 May 2016 16:10:04 -0400 [thread overview]
Message-ID: <e8f310b5-4fe8-3eb2-2d17-b1d9077daea2@osg.samsung.com> (raw)
In-Reply-To: <1462451666-17945-12-git-send-email-k.kozlowski@samsung.com>
Hello Krzysztof,
On 05/05/2016 08:34 AM, Krzysztof Kozlowski wrote:
> Parse usb-pwrseq property from Device Tree to get the phandle to pwrseq
> device. The pwrseq device will be used by USB hub to cycle the power
> before activating ports.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
[snip]
>
> @@ -532,6 +534,14 @@ int usb_hub_create_port_device(struct usb_hub *hub, int port1)
> return retval;
> }
>
> + port_dev->dev.of_node = usb_of_get_child_node(hub->hdev->dev.of_node, port1);
> + port_dev->pwrseq = pwrseq_alloc(&port_dev->dev);
> + if (IS_ERR(port_dev->pwrseq)) {
> + device_unregister(&port_dev->dev);
> + /* TODO: what about EPROBE_DEFER? */
I think it's OK since the call chain is:
hub_probe()
hub_configure()
usb_hub_create_port_device()
so the hub_probe() will be deferred if the usb-pwrseq was not registered yet.
Unless I misunderstood your question :)
Anyway, patch looks good to me:
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2016-05-05 20:10 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 12:34 [RFC v2 00/13] usb/mmc/power: Fix USB/LAN when TFTP booting Krzysztof Kozlowski
2016-05-05 12:34 ` [RFC v2 01/13] usb: misc: usb3503: Clean up on driver unbind Krzysztof Kozlowski
2016-05-05 18:32 ` Javier Martinez Canillas
2016-05-06 6:13 ` Krzysztof Kozlowski
2016-05-05 12:34 ` [RFC v2 02/13] power/mmc: Move pwrseq drivers to power/pwrseq Krzysztof Kozlowski
2016-05-05 18:44 ` Javier Martinez Canillas
2016-05-06 6:15 ` Krzysztof Kozlowski
2016-05-05 12:34 ` [RFC v2 03/13] MAINTAINERS: Retain Ulf Hansson as the same maintainer of pwrseq Krzysztof Kozlowski
2016-05-05 18:46 ` Javier Martinez Canillas
2016-05-05 12:34 ` [RFC v2 06/13] power: pwrseq: Generalize mmc_pwrseq operations by removing mmc prefix Krzysztof Kozlowski
[not found] ` <1462451666-17945-7-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-05-05 19:14 ` Javier Martinez Canillas
2016-05-05 12:34 ` [RFC v2 07/13] power: pwrseq: simple: Add support for toggling regulator Krzysztof Kozlowski
2016-05-05 19:31 ` Javier Martinez Canillas
2016-05-06 6:24 ` Krzysztof Kozlowski
2016-05-05 12:34 ` [RFC v2 08/13] usb: hub: Handle deferred probe Krzysztof Kozlowski
2016-05-05 19:33 ` Javier Martinez Canillas
2016-05-05 12:34 ` [RFC v2 09/13] power: pwrseq: Add support for USB hubs with external power Krzysztof Kozlowski
[not found] ` <1462451666-17945-10-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-05-05 19:52 ` Javier Martinez Canillas
2016-05-06 6:26 ` Krzysztof Kozlowski
2016-05-05 12:34 ` [RFC v2 10/13] usb: hub: Power sequence the ports on activation Krzysztof Kozlowski
[not found] ` <1462451666-17945-11-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-05-05 14:09 ` Alan Stern
2016-05-05 17:37 ` Krzysztof Kozlowski
2016-05-05 19:56 ` Javier Martinez Canillas
[not found] ` <1462451666-17945-1-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-05-05 12:34 ` [RFC v2 04/13] power: pwrseq: Enable COMPILE_TEST for drivers Krzysztof Kozlowski
[not found] ` <1462451666-17945-5-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-05-05 18:57 ` Javier Martinez Canillas
2016-05-05 12:34 ` [RFC v2 05/13] power: pwrseq: Remove mmc prefix from mmc_pwrseq Krzysztof Kozlowski
2016-05-05 19:09 ` Javier Martinez Canillas
2016-05-06 6:20 ` Krzysztof Kozlowski
2016-05-05 12:34 ` [RFC v2 11/13] usb: port: Parse pwrseq phandle from Device Tree Krzysztof Kozlowski
2016-05-05 20:10 ` Javier Martinez Canillas [this message]
2016-05-06 6:27 ` Krzysztof Kozlowski
2016-05-05 12:34 ` [RFC v2 12/13] ARM: dts: exynos: Switch the buck8 to GPIO mode on Odroid U3 Krzysztof Kozlowski
2016-05-05 20:11 ` Javier Martinez Canillas
2016-05-05 22:42 ` [RFC v2 00/13] usb/mmc/power: Fix USB/LAN when TFTP booting Rob Herring
2016-05-06 5:44 ` Peter Chen
2016-05-06 6:12 ` Krzysztof Kozlowski
[not found] ` <572C35C8.9080709-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-05-06 7:15 ` Peter Chen
2016-05-06 6:10 ` Krzysztof Kozlowski
2016-05-06 13:01 ` Rob Herring
2016-05-09 7:46 ` Ulf Hansson
2016-05-09 18:18 ` Rob Herring
2016-05-10 11:02 ` Ulf Hansson
[not found] ` <CAPDyKFq2=mqujFjvJSYxg2nVmK=OrBKLtFfb-ErNJO3Zr_LMVw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-05-28 3:36 ` Peter Chen
2016-05-31 0:58 ` Peter Chen
2016-05-31 11:54 ` Krzysztof Kozlowski
2016-05-05 12:34 ` [RFC v2 13/13] ARM: dts: exynos: Fix LAN and HUB after bootloader initialization on Odroid U3 Krzysztof Kozlowski
2016-05-05 20:16 ` Javier Martinez Canillas
2016-05-06 6:28 ` Krzysztof Kozlowski
2016-12-13 12:20 ` [RFC v2 00/13] usb/mmc/power: Fix USB/LAN when TFTP booting Hans Verkuil
2016-12-13 12:34 ` Hans Verkuil
2016-12-13 13:53 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8f310b5-4fe8-3eb2-2d17-b1d9077daea2@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=sre@kernel.org \
--cc=tjakobi@math.uni-bielefeld.de \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).