linux-edac.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* kernel 6.9-rc1 fails to compile if debugfs is disabled
@ 2024-03-25 15:10 A
  2024-03-25 15:17 ` Fw: " A
  2024-03-25 16:08 ` Borislav Petkov
  0 siblings, 2 replies; 5+ messages in thread
From: A @ 2024-03-25 15:10 UTC (permalink / raw)
  To: tony.luck, bp; +Cc: linux-edac

https://bugzilla.kernel.org/show_bug.cgi?id=218640

kernel 6.9-rc1 fails to compile if debugfs is disabled (CONFIG_DEBUG_FS):

it fails here:

```ERROR: modpost: "ras_get_debugfs_root" [drivers/ras/amd/fmpm.ko] undefined!
make[5]: *** [scripts/Makefile.modpost:145: Module.symvers] Error 1
make[4]: *** [Makefile:1871: modpost] Error 2
make[3]: *** [debian/rules:74: build-arch] Error 2
dpkg-buildpackage: error: make -f debian/rules binary subprocess returned exit status 2
make[2]: *** [scripts/Makefile.package:121: bindeb-pkg] Error 2
make[1]: *** [/ram/linux-6.9-rc1/Makefile:1541: bindeb-pkg] Error 2
make: *** [Makefile:240: __sub-make] Error 2```

if i enable debugfs, it compiles without failing.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Fw: kernel 6.9-rc1 fails to compile if debugfs is disabled
  2024-03-25 15:10 kernel 6.9-rc1 fails to compile if debugfs is disabled A
@ 2024-03-25 15:17 ` A
  2024-03-25 16:08 ` Borislav Petkov
  1 sibling, 0 replies; 5+ messages in thread
From: A @ 2024-03-25 15:17 UTC (permalink / raw)
  To: Yazen.Ghannam; +Cc: linux-edac

https://bugzilla.kernel.org/show_bug.cgi?id=218640

kernel 6.9-rc1 fails to compile if debugfs is disabled (CONFIG_DEBUG_FS):

it fails here:

ERROR: modpost: "ras_get_debugfs_root" [drivers/ras/amd/fmpm.ko] undefined! make[5]: *** [scripts/Makefile.modpost:145: Module.symvers] Error 1 make[4]: *** [Makefile:1871: modpost] Error 2 make[3]: *** [debian/rules:74: build-arch] Error 2 dpkg-buildpackage: error: make -f debian/rules binary subprocess returned exit status 2 make[2]: *** [scripts/Makefile.package:121: bindeb-pkg] Error 2 make[1]: *** [/ram/linux-6.9-rc1/Makefile:1541: bindeb-pkg] Error 2 make: *** [Makefile:240: __sub-make] Error 2`

if i enable debugfs, it compiles without failing.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: kernel 6.9-rc1 fails to compile if debugfs is disabled
  2024-03-25 15:10 kernel 6.9-rc1 fails to compile if debugfs is disabled A
  2024-03-25 15:17 ` Fw: " A
@ 2024-03-25 16:08 ` Borislav Petkov
  2024-03-25 16:49   ` A
  1 sibling, 1 reply; 5+ messages in thread
From: Borislav Petkov @ 2024-03-25 16:08 UTC (permalink / raw)
  To: A; +Cc: tony.luck, linux-edac

On Mon, Mar 25, 2024 at 03:10:25PM +0000, A wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=218640
> 
> kernel 6.9-rc1 fails to compile if debugfs is disabled (CONFIG_DEBUG_FS):

This should fix it:

---
diff --git a/drivers/ras/Kconfig b/drivers/ras/Kconfig
index fc4f4bb94a4c..41697e326fa6 100644
--- a/drivers/ras/Kconfig
+++ b/drivers/ras/Kconfig
@@ -37,7 +37,7 @@ source "drivers/ras/amd/atl/Kconfig"
 config RAS_FMPM
 	tristate "FRU Memory Poison Manager"
 	default m
-	depends on AMD_ATL && ACPI_APEI
+	depends on AMD_ATL && ACPI_APEI && DEBUG_FS
 	help
 	  Support saving and restoring memory error information across reboot
 	  using ACPI ERST as persistent storage. Error information is saved with


-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: kernel 6.9-rc1 fails to compile if debugfs is disabled
  2024-03-25 16:08 ` Borislav Petkov
@ 2024-03-25 16:49   ` A
  2024-03-25 17:38     ` Borislav Petkov
  0 siblings, 1 reply; 5+ messages in thread
From: A @ 2024-03-25 16:49 UTC (permalink / raw)
  To: Borislav Petkov; +Cc: tony.luck, linux-edac






On Monday, March 25th, 2024 at 16:08, Borislav Petkov <bp@alien8.de> wrote:

> 
> 
> On Mon, Mar 25, 2024 at 03:10:25PM +0000, A wrote:
> 
> > https://bugzilla.kernel.org/show_bug.cgi?id=218640
> > 
> > kernel 6.9-rc1 fails to compile if debugfs is disabled (CONFIG_DEBUG_FS):
> 
> 
> This should fix it:
> 
> ---
> diff --git a/drivers/ras/Kconfig b/drivers/ras/Kconfig
> index fc4f4bb94a4c..41697e326fa6 100644
> --- a/drivers/ras/Kconfig
> +++ b/drivers/ras/Kconfig
> @@ -37,7 +37,7 @@ source "drivers/ras/amd/atl/Kconfig"
> config RAS_FMPM
> tristate "FRU Memory Poison Manager"
> default m
> - depends on AMD_ATL && ACPI_APEI
> + depends on AMD_ATL && ACPI_APEI && DEBUG_FS
> help
> Support saving and restoring memory error information across reboot
> using ACPI ERST as persistent storage. Error information is saved with
> 
> 
> --
> Regards/Gruss,
> Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette

thanks, this works

kind regards,
anthony s.k.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: kernel 6.9-rc1 fails to compile if debugfs is disabled
  2024-03-25 16:49   ` A
@ 2024-03-25 17:38     ` Borislav Petkov
  0 siblings, 0 replies; 5+ messages in thread
From: Borislav Petkov @ 2024-03-25 17:38 UTC (permalink / raw)
  To: A; +Cc: tony.luck, linux-edac

On Mon, Mar 25, 2024 at 04:49:54PM +0000, A wrote:
> thanks, this works

Thanks for testing. Do you want me to add

Reported-by: akira.2020@protonmail.com

to the official fix?

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-03-25 17:39 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-25 15:10 kernel 6.9-rc1 fails to compile if debugfs is disabled A
2024-03-25 15:17 ` Fw: " A
2024-03-25 16:08 ` Borislav Petkov
2024-03-25 16:49   ` A
2024-03-25 17:38     ` Borislav Petkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).