linux-edac.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yazen Ghannam <yazen.ghannam@amd.com>
To: A <akira.2020@protonmail.com>, "bp@alien8.de" <bp@alien8.de>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
Cc: yazen.ghannam@amd.com,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] RAS/AMD/FMPM: Fix build when debugfs is not enabled
Date: Tue, 26 Mar 2024 10:29:36 -0400	[thread overview]
Message-ID: <656a7134-4984-4577-93eb-60c0c28adf93@amd.com> (raw)
In-Reply-To: <i2PhAcMufioQc2nhVgO9T23CcF8UsgJo8CWPOl_7lV3iF00GdywfpQa2Hu-yPX3bD4o5wpfUtIsRBIhFH1j3k9aNoUJfgGALNWUUjMokpFc=@protonmail.com>

On 3/26/24 10:20, A wrote:
[...]
>>
>> diff --git a/drivers/ras/debugfs.h b/drivers/ras/debugfs.h
>> index 4749ccdeeba1..ab95831e7710 100644
>> --- a/drivers/ras/debugfs.h
>> +++ b/drivers/ras/debugfs.h
>> @@ -4,6 +4,10 @@
>>
>> #include <linux/debugfs.h>
>>
>>
>> +#if IS_ENABLED(DEBUG_FS)
>> struct dentry *ras_get_debugfs_root(void);
>> +#else
>> +static inline struct dentry ras_get_debugfs_root(void) { return NULL; }
>> +#endif / DEBUG_FS /
>>
>> #endif / RAS_DEBUGFS_H */
> 
> this also works, just tested
> 
> this time round, `make oldconfig` asks if i want to build RAS_FMPM, i built it as module, compilation succeeds.
> 

Thanks for testing!

Would you mind including your "Tested-by" tag? I can include this when I 
send a proper patch.

Thanks,
Yazen

  reply	other threads:[~2024-03-26 14:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-25 18:37 [PATCH] RAS/AMD/FMPM: Fix build when debugfs is not enabled Borislav Petkov
2024-03-26 13:41 ` Yazen Ghannam
2024-03-26 14:07   ` Borislav Petkov
2024-03-26 14:22     ` Yazen Ghannam
2024-03-26 14:27       ` Borislav Petkov
2024-03-26 14:20   ` A
2024-03-26 14:29     ` Yazen Ghannam [this message]
2024-03-26 18:37       ` A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=656a7134-4984-4577-93eb-60c0c28adf93@amd.com \
    --to=yazen.ghannam@amd.com \
    --cc=akira.2020@protonmail.com \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).