linux-edac.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: yazen.ghannam@amd.com, linux-edac <linux-edac@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"anthony s . k ." <akira.2020@protonmail.com>
Subject: Re: [PATCH] RAS/AMD/FMPM: Fix build when debugfs is not enabled
Date: Tue, 26 Mar 2024 10:22:05 -0400	[thread overview]
Message-ID: <adacb412-a043-4512-a8d3-1a0f6f40e9f4@amd.com> (raw)
In-Reply-To: <20240326140759.GGZgLWv3UZVpHZ5c98@fat_crate.local>

On 3/26/24 10:07, Borislav Petkov wrote:
> On Tue, Mar 26, 2024 at 09:41:41AM -0400, Yazen Ghannam wrote:
>> This isn't true which is why the module doesn't fail to load if debugfs
>> is not available.
> 
> How useful is this thing really without debugfs to dump records?
>

The goal of the module is to save and restore records across reboots.

The debugfs thing came later and the commit message states that it is
optional.

7d19eea51757 ("RAS/AMD/FMPM: Add debugfs interface to print record entries")

>> This was my first thought too. However, besides not true as stated
>> above, this also leaves the issue open for others to hit.
> 
> The others to hit? I don't get that part.
>

Sorry, I mean that if there's another user of ras_get_debugfs_root()
that doesn't depend on CONFIG_DEBUG_FS.

>> I think the fix below (not tested) would be more appropriate.
>>
>> What do you think?
> 
> Sure, remove my fix and send me a tested version of yours and I'll swap
> them if the driver is useful without debugfs...

Okay, will do.

Thanks,
Yazen

  reply	other threads:[~2024-03-26 14:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-25 18:37 [PATCH] RAS/AMD/FMPM: Fix build when debugfs is not enabled Borislav Petkov
2024-03-26 13:41 ` Yazen Ghannam
2024-03-26 14:07   ` Borislav Petkov
2024-03-26 14:22     ` Yazen Ghannam [this message]
2024-03-26 14:27       ` Borislav Petkov
2024-03-26 14:20   ` A
2024-03-26 14:29     ` Yazen Ghannam
2024-03-26 18:37       ` A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adacb412-a043-4512-a8d3-1a0f6f40e9f4@amd.com \
    --to=yazen.ghannam@amd.com \
    --cc=akira.2020@protonmail.com \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).