* [PATCH v2] x86/efi: fix a -Wtype-limits compilation warning
@ 2019-06-19 17:47 Qian Cai
2019-06-19 17:53 ` Prakhya, Sai Praneeth
0 siblings, 1 reply; 3+ messages in thread
From: Qian Cai @ 2019-06-19 17:47 UTC (permalink / raw)
To: bp
Cc: ard.biesheuvel, akpm, dvhart, andy, tglx, mingo,
sai.praneeth.prakhya, hpa, x86, linux-efi, platform-driver-x86,
linux-kernel, Qian Cai
Compiling a kernel with W=1 generates this warning,
arch/x86/platform/efi/quirks.c:731:16: warning: comparison of unsigned
expression >= 0 is always true [-Wtype-limits]
Fixes: 3425d934fc03 ("efi/x86: Handle page faults occurring while running EFI runtime services")
Signed-off-by: Qian Cai <cai@lca.pw>
---
v2: Add a "Fixes" tag.
arch/x86/platform/efi/quirks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/platform/efi/quirks.c b/arch/x86/platform/efi/quirks.c
index 632b83885867..3b9fd679cea9 100644
--- a/arch/x86/platform/efi/quirks.c
+++ b/arch/x86/platform/efi/quirks.c
@@ -728,7 +728,7 @@ void efi_recover_from_page_fault(unsigned long phys_addr)
* Address range 0x0000 - 0x0fff is always mapped in the efi_pgd, so
* page faulting on these addresses isn't expected.
*/
- if (phys_addr >= 0x0000 && phys_addr <= 0x0fff)
+ if (phys_addr <= 0x0fff)
return;
/*
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH v2] x86/efi: fix a -Wtype-limits compilation warning
2019-06-19 17:47 [PATCH v2] x86/efi: fix a -Wtype-limits compilation warning Qian Cai
@ 2019-06-19 17:53 ` Prakhya, Sai Praneeth
2019-06-21 15:54 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Prakhya, Sai Praneeth @ 2019-06-19 17:53 UTC (permalink / raw)
To: Qian Cai, bp
Cc: ard.biesheuvel, akpm, dvhart, andy, tglx, mingo, hpa, x86,
linux-efi, platform-driver-x86, linux-kernel
> Compiling a kernel with W=1 generates this warning,
>
> arch/x86/platform/efi/quirks.c:731:16: warning: comparison of unsigned
> expression >= 0 is always true [-Wtype-limits]
>
> Fixes: 3425d934fc03 ("efi/x86: Handle page faults occurring while running EFI
> runtime services")
> Signed-off-by: Qian Cai <cai@lca.pw>
> ---
>
> v2: Add a "Fixes" tag.
Makes sense.
Thanks for the fix Qian Cai.
Regards,
Sai
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] x86/efi: fix a -Wtype-limits compilation warning
2019-06-19 17:53 ` Prakhya, Sai Praneeth
@ 2019-06-21 15:54 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2019-06-21 15:54 UTC (permalink / raw)
To: Prakhya, Sai Praneeth
Cc: Qian Cai, bp, akpm, dvhart, andy, tglx, mingo, hpa, x86,
linux-efi, platform-driver-x86, linux-kernel
On Wed, 19 Jun 2019 at 19:53, Prakhya, Sai Praneeth
<sai.praneeth.prakhya@intel.com> wrote:
>
> > Compiling a kernel with W=1 generates this warning,
> >
> > arch/x86/platform/efi/quirks.c:731:16: warning: comparison of unsigned
> > expression >= 0 is always true [-Wtype-limits]
> >
> > Fixes: 3425d934fc03 ("efi/x86: Handle page faults occurring while running EFI
> > runtime services")
> > Signed-off-by: Qian Cai <cai@lca.pw>
> > ---
> >
> > v2: Add a "Fixes" tag.
>
> Makes sense.
> Thanks for the fix Qian Cai.
>
Queued as a fix with Sai's ack
Thanks,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-21 15:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-19 17:47 [PATCH v2] x86/efi: fix a -Wtype-limits compilation warning Qian Cai
2019-06-19 17:53 ` Prakhya, Sai Praneeth
2019-06-21 15:54 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).