linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] EXT4: acl: Fix a style issue
       [not found] <20200416141456.1089-1-carlosteniswarrior@gmail.com>
@ 2020-05-07 14:58 ` Theodore Y. Ts'o
  0 siblings, 0 replies; 3+ messages in thread
From: Theodore Y. Ts'o @ 2020-05-07 14:58 UTC (permalink / raw)
  To: Carlos Guerrero Alvarez; +Cc: adilger.kernel, linux-ext4

On Thu, Apr 16, 2020 at 04:14:56PM +0200, Carlos Guerrero Alvarez wrote:
> From: Carlos Guerrero Álvarez <carlosteniswarrior@gmail.com>
> 
> Fixed an if statement where braces were not needed.
> 
> Signed-off-by: Carlos Guerrero Álvarez <carlosteniswarrior@gmail.com>

Applied, thanks.

					- Ted

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] EXT4: acl: Fix a style issue
@ 2020-04-14 22:54 root
  0 siblings, 0 replies; 3+ messages in thread
From: root @ 2020-04-14 22:54 UTC (permalink / raw)
  To: tytso
  Cc: adilger.kernel, linux-ext4, linux-kernel, Carlos Guerrero Álvarez

From: Carlos Guerrero Álvarez <carlosteniswarrior@gmail.com>

Fixed an if statement where braces were not needed.

Signed-off-by: Carlos Guerrero Álvarez <carlosteniswarrior@gmail.com>
---
 fs/ext4/acl.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/ext4/acl.c b/fs/ext4/acl.c
index 8c7bbf3e566d..b3eba92f38f5 100644
--- a/fs/ext4/acl.c
+++ b/fs/ext4/acl.c
@@ -215,9 +215,8 @@ __ext4_set_acl(handle_t *handle, struct inode *inode, int type,
 				      value, size, xattr_flags);
 
 	kfree(value);
-	if (!error) {
+	if (!error)
 		set_cached_acl(inode, type, acl);
-	}
 
 	return error;
 }
-- 
2.25.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] EXT4: acl: Fix a style issue
@ 2020-04-14 22:51 root
  0 siblings, 0 replies; 3+ messages in thread
From: root @ 2020-04-14 22:51 UTC (permalink / raw)
  To: tytso
  Cc: adilger.kernel, linux-ext4, linux-kernel, Carlos Guerrero Álvarez

From: Carlos Guerrero Álvarez <carlosteniswarrior@gmail.com>

Fixed an if statement where braces were not needed.

Signed-off-by: Carlos Guerrero Álvarez <carlosteniswarrior@gmail.com>
---
 fs/ext4/acl.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/ext4/acl.c b/fs/ext4/acl.c
index 8c7bbf3e566d..b3eba92f38f5 100644
--- a/fs/ext4/acl.c
+++ b/fs/ext4/acl.c
@@ -215,9 +215,8 @@ __ext4_set_acl(handle_t *handle, struct inode *inode, int type,
 				      value, size, xattr_flags);
 
 	kfree(value);
-	if (!error) {
+	if (!error)
 		set_cached_acl(inode, type, acl);
-	}
 
 	return error;
 }
-- 
2.25.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-07 14:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200416141456.1089-1-carlosteniswarrior@gmail.com>
2020-05-07 14:58 ` [PATCH] EXT4: acl: Fix a style issue Theodore Y. Ts'o
2020-04-14 22:54 root
  -- strict thread matches above, loose matches on Subject: below --
2020-04-14 22:51 root

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).