linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] unicode: Allow building kunit test suite as a module
@ 2020-05-19  5:03 Gabriel Krisman Bertazi
  0 siblings, 0 replies; only message in thread
From: Gabriel Krisman Bertazi @ 2020-05-19  5:03 UTC (permalink / raw)
  To: linux-ext4
  Cc: tytso, kernel, Gabriel Krisman Bertazi, Ricardo Cañuelo,
	kbuild test robot

Starting on commit c475c77d5b56 ("kunit: allow kunit tests to be loaded
as a module") kunit testsuites need to be buildable as modules, to
prevent the undefined references below, in case KUNIT itself was made a
module:

utf8-test.c:(.text+0x48): undefined reference to `kunit_ptr_not_err_assert_format'
>> sparc64-linux-ld: utf8-test.c:(.text+0x50): undefined reference to `kunit_ptr_not_err_assert_format'
>> sparc64-linux-ld: utf8-test.c:(.text+0xb4): undefined reference to `kunit_do_assertion'
>> sparc64-linux-ld: utf8-test.c:(.text+0xbc): undefined reference to
`kunit_binary_assert_format'

This was found by 0-day on linux-next and fixes the allmodconfig build

CC: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
Fixes: d269543a1dcb ("unicode: implement utf8 unit tests as a KUnit test suite")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
---
 fs/unicode/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/unicode/Kconfig b/fs/unicode/Kconfig
index a8865891c3bd..eb30ef469567 100644
--- a/fs/unicode/Kconfig
+++ b/fs/unicode/Kconfig
@@ -9,7 +9,7 @@ config UNICODE
 	  support.
 
 config UNICODE_KUNIT_TESTS
-	bool "KUnit tests for Unicode normalization and casefolding support"
+	tristate "KUnit tests for Unicode normalization and casefolding support"
 	depends on UNICODE && KUNIT
 	default n
 	help
-- 
2.26.2


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-05-19  5:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-19  5:03 [PATCH] unicode: Allow building kunit test suite as a module Gabriel Krisman Bertazi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).