linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 3/4] e2fsck: use the right conversion specifier in e2fsck_allocate_memory()
Date: Thu, 1 Oct 2020 16:49:43 -0400	[thread overview]
Message-ID: <20201001204943.GP23474@mit.edu> (raw)
In-Reply-To: <20200605081442.13428-3-lczerner@redhat.com>

Thanks, I had fixed this in one place, but the fix under the #ifdef
DEBUG_ALLOCATE_MEMORY needed, so that part has been applied.

		      	      	 - Ted
				 



On Fri, Jun 05, 2020 at 10:14:41AM +0200, Lukas Czerner wrote:
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> ---
>  e2fsck/util.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/e2fsck/util.c b/e2fsck/util.c
> index 88e0ea8a..79916928 100644
> --- a/e2fsck/util.c
> +++ b/e2fsck/util.c
> @@ -123,10 +123,10 @@ void *e2fsck_allocate_memory(e2fsck_t ctx, unsigned long size,
>  	char buf[256];
>  
>  #ifdef DEBUG_ALLOCATE_MEMORY
> -	printf("Allocating %u bytes for %s...\n", size, description);
> +	printf("Allocating %lu bytes for %s...\n", size, description);
>  #endif
>  	if (ext2fs_get_memzero(size, &ret)) {
> -		sprintf(buf, "Can't allocate %u bytes for %s\n",
> +		sprintf(buf, "Can't allocate %lu bytes for %s\n",
>  			size, description);
>  		fatal_error(ctx, buf);
>  	}
> -- 
> 2.21.3
> 

  parent reply	other threads:[~2020-10-01 20:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-05  8:14 [PATCH 1/4] e2fsck: remove unused variable 'new_array' Lukas Czerner
2020-06-05  8:14 ` [PATCH 2/4] e2fsck: use size_t instead of int in string_copy() Lukas Czerner
2020-06-05 21:26   ` Andreas Dilger
2020-10-01 20:43   ` Theodore Y. Ts'o
2020-06-05  8:14 ` [PATCH 3/4] e2fsck: use the right conversion specifier in e2fsck_allocate_memory() Lukas Czerner
2020-06-05 20:42   ` Andreas Dilger
2020-10-01 20:49   ` Theodore Y. Ts'o [this message]
2020-06-05  8:14 ` [PATCH 4/4] ext2fs: remove unused variable 'left' Lukas Czerner
2020-06-05 20:48   ` Andreas Dilger
2020-10-01 20:51   ` Theodore Y. Ts'o
2020-06-05 20:36 ` [PATCH 1/4] e2fsck: remove unused variable 'new_array' Andreas Dilger
2020-06-05 20:38 ` Andreas Dilger
2020-09-22 12:37 ` Lukas Czerner
2020-10-01 20:43 ` Theodore Y. Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201001204943.GP23474@mit.edu \
    --to=tytso@mit.edu \
    --cc=lczerner@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).