From: Andreas Dilger <adilger@dilger.ca>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/4] e2fsck: remove unused variable 'new_array'
Date: Fri, 5 Jun 2020 14:38:33 -0600 [thread overview]
Message-ID: <4204B3A3-A7FF-41AB-8F24-F8B8363FB1A6@dilger.ca> (raw)
In-Reply-To: <20200605081442.13428-1-lczerner@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 751 bytes --]
> On Jun 5, 2020, at 2:14 AM, Lukas Czerner <lczerner@redhat.com> wrote:
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> ---
> e2fsck/rehash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/e2fsck/rehash.c b/e2fsck/rehash.c
> index 1616d07a..b356b92d 100644
> --- a/e2fsck/rehash.c
> +++ b/e2fsck/rehash.c
> @@ -109,7 +109,7 @@ static int fill_dir_block(ext2_filsys fs,
> void *priv_data)
> {
> struct fill_dir_struct *fd = (struct fill_dir_struct *) priv_data;
> - struct hash_entry *new_array, *ent;
> + struct hash_entry *ent;
PS - there is a space before the tab after "hash_entry" that could be removed.
Ted could fix this when the patch is applied.
Cheers, Andreas
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 873 bytes --]
next prev parent reply other threads:[~2020-06-05 20:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 8:14 [PATCH 1/4] e2fsck: remove unused variable 'new_array' Lukas Czerner
2020-06-05 8:14 ` [PATCH 2/4] e2fsck: use size_t instead of int in string_copy() Lukas Czerner
2020-06-05 21:26 ` Andreas Dilger
2020-10-01 20:43 ` Theodore Y. Ts'o
2020-06-05 8:14 ` [PATCH 3/4] e2fsck: use the right conversion specifier in e2fsck_allocate_memory() Lukas Czerner
2020-06-05 20:42 ` Andreas Dilger
2020-10-01 20:49 ` Theodore Y. Ts'o
2020-06-05 8:14 ` [PATCH 4/4] ext2fs: remove unused variable 'left' Lukas Czerner
2020-06-05 20:48 ` Andreas Dilger
2020-10-01 20:51 ` Theodore Y. Ts'o
2020-06-05 20:36 ` [PATCH 1/4] e2fsck: remove unused variable 'new_array' Andreas Dilger
2020-06-05 20:38 ` Andreas Dilger [this message]
2020-09-22 12:37 ` Lukas Czerner
2020-10-01 20:43 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4204B3A3-A7FF-41AB-8F24-F8B8363FB1A6@dilger.ca \
--to=adilger@dilger.ca \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).