From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Xiao Yang <yangx.jy@cn.fujitsu.com>
Cc: linux-ext4@vger.kernel.org, darrick.wong@oracle.com,
ira.weiny@intel.com, jack@suse.cz
Subject: Re: [PATCH v2] ext4: Disallow modifying DAX inode flag if inline_data has been set
Date: Sat, 3 Oct 2020 00:13:21 -0400 [thread overview]
Message-ID: <20201003041321.GB23474@mit.edu> (raw)
In-Reply-To: <20200828084330.15776-1-yangx.jy@cn.fujitsu.com>
On Fri, Aug 28, 2020 at 04:43:30PM +0800, Xiao Yang wrote:
> inline_data is mutually exclusive to DAX so enabling both of them triggers
> the following issue:
> ------------------------------------------
> # mkfs.ext4 -F -O inline_data /dev/pmem1
> ...
> # mount /dev/pmem1 /mnt
> # echo 'test' >/mnt/file
> # lsattr -l /mnt/file
> /mnt/file Inline_Data
> # xfs_io -c "chattr +x" /mnt/file
> # xfs_io -c "lsattr -v" /mnt/file
> [dax] /mnt/file
> # umount /mnt
> # mount /dev/pmem1 /mnt
> # cat /mnt/file
> cat: /mnt/file: Numerical result out of range
> ------------------------------------------
>
> Fixes: b383a73f2b83 ("fs/ext4: Introduce DAX inode flag")
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
Applied, thanks.
- Ted
prev parent reply other threads:[~2020-10-03 4:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 8:43 [PATCH v2] ext4: Disallow modifying DAX inode flag if inline_data has been set Xiao Yang
2020-08-28 17:57 ` Ira Weiny
2020-08-29 7:27 ` Andreas Dilger
2020-09-17 3:29 ` Xiao Yang
2020-10-03 4:13 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201003041321.GB23474@mit.edu \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=yangx.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).