From: Andreas Dilger <adilger@dilger.ca>
To: Xiao Yang <yangx.jy@cn.fujitsu.com>
Cc: linux-ext4@vger.kernel.org, darrick.wong@oracle.com,
ira.weiny@intel.com, tytso@mit.edu, jack@suse.cz
Subject: Re: [PATCH v2] ext4: Disallow modifying DAX inode flag if inline_data has been set
Date: Sat, 29 Aug 2020 01:27:29 -0600 [thread overview]
Message-ID: <900D8400-83F4-464A-88A4-32235B9A0DC8@dilger.ca> (raw)
In-Reply-To: <20200828084330.15776-1-yangx.jy@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 1487 bytes --]
On Aug 28, 2020, at 2:43 AM, Xiao Yang <yangx.jy@cn.fujitsu.com> wrote:
>
> inline_data is mutually exclusive to DAX so enabling both of them triggers
> the following issue:
> ------------------------------------------
> # mkfs.ext4 -F -O inline_data /dev/pmem1
> ...
> # mount /dev/pmem1 /mnt
> # echo 'test' >/mnt/file
> # lsattr -l /mnt/file
> /mnt/file Inline_Data
> # xfs_io -c "chattr +x" /mnt/file
> # xfs_io -c "lsattr -v" /mnt/file
> [dax] /mnt/file
> # umount /mnt
> # mount /dev/pmem1 /mnt
> # cat /mnt/file
> cat: /mnt/file: Numerical result out of range
> ------------------------------------------
>
> Fixes: b383a73f2b83 ("fs/ext4: Introduce DAX inode flag")
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
> ---
> fs/ext4/ext4.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 523e00d7b392..69187b6205b2 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -492,7 +492,7 @@ struct flex_groups {
>
> /* Flags which are mutually exclusive to DAX */
> #define EXT4_DAX_MUT_EXCL (EXT4_VERITY_FL | EXT4_ENCRYPT_FL |\
> - EXT4_JOURNAL_DATA_FL)
> + EXT4_JOURNAL_DATA_FL | EXT4_INLINE_DATA_FL)
>
> /* Mask out flags that are inappropriate for the given type of inode. */
> static inline __u32 ext4_mask_flags(umode_t mode, __u32 flags)
> --
> 2.25.1
>
>
>
Cheers, Andreas
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 873 bytes --]
next prev parent reply other threads:[~2020-08-29 7:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 8:43 [PATCH v2] ext4: Disallow modifying DAX inode flag if inline_data has been set Xiao Yang
2020-08-28 17:57 ` Ira Weiny
2020-08-29 7:27 ` Andreas Dilger [this message]
2020-09-17 3:29 ` Xiao Yang
2020-10-03 4:13 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=900D8400-83F4-464A-88A4-32235B9A0DC8@dilger.ca \
--to=adilger@dilger.ca \
--cc=darrick.wong@oracle.com \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yangx.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).