From: Zhiqiang Liu <liuzhiqiang26@huawei.com>
To: <linux-ext4@vger.kernel.org>, "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: harshad shirwadkar <harshadshirwadkar@gmail.com>,
linfeilong <linfeilong@huawei.com>,
lihaotian <lihaotian9@huawei.com>, <liuzhiqiang26@huawei.com>
Subject: [PATCH] misc: remove useless code in set_inode_xattr()
Date: Fri, 26 Feb 2021 09:22:58 +0800 [thread overview]
Message-ID: <283210da-b281-2dd7-6ef7-b31e81e72e01@huawei.com> (raw)
In set_inode_xattr(), there are two returns as follows,
-
return retval;
return 0;
-
Here, we remove useless 'return 0;' code.
Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
---
misc/create_inode.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/misc/create_inode.c b/misc/create_inode.c
index 54d8d343..d62e1cb4 100644
--- a/misc/create_inode.c
+++ b/misc/create_inode.c
@@ -234,7 +234,6 @@ static errcode_t set_inode_xattr(ext2_filsys fs, ext2_ino_t ino,
retval = retval ? retval : close_retval;
}
return retval;
- return 0;
}
#else /* HAVE_LLISTXATTR */
static errcode_t set_inode_xattr(ext2_filsys fs EXT2FS_ATTR((unused)),
--
2.19.1
next reply other threads:[~2021-02-26 1:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 1:22 Zhiqiang Liu [this message]
2021-03-03 0:51 ` [PATCH] misc: remove useless code in set_inode_xattr() Zhiqiang Liu
2021-03-03 20:20 ` Andreas Dilger
2021-04-02 19:57 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=283210da-b281-2dd7-6ef7-b31e81e72e01@huawei.com \
--to=liuzhiqiang26@huawei.com \
--cc=harshadshirwadkar@gmail.com \
--cc=lihaotian9@huawei.com \
--cc=linfeilong@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).