From: "Theodore Ts'o" <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Zhiqiang Liu <liuzhiqiang26@huawei.com>,
linux-ext4@vger.kernel.org,
harshad shirwadkar <harshadshirwadkar@gmail.com>,
linfeilong <linfeilong@huawei.com>,
lihaotian <lihaotian9@huawei.com>
Subject: Re: [PATCH] misc: remove useless code in set_inode_xattr()
Date: Fri, 2 Apr 2021 15:57:26 -0400 [thread overview]
Message-ID: <YGd3JmrmFtAHrWE4@mit.edu> (raw)
In-Reply-To: <F8991EA4-20AB-4785-83A6-8BC159EF3970@dilger.ca>
On Wed, Mar 03, 2021 at 01:20:33PM -0700, Andreas Dilger wrote:
> On 2021/2/26 9:22, Zhiqiang Liu wrote:
> >
> > In set_inode_xattr(), there are two returns as follows,
> > -
> > return retval;
> > return 0;
> > -
> > Here, we remove useless 'return 0;' code.
> >
> > Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
>
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Thanks, applied.
- Ted
prev parent reply other threads:[~2021-04-02 19:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 1:22 [PATCH] misc: remove useless code in set_inode_xattr() Zhiqiang Liu
2021-03-03 0:51 ` Zhiqiang Liu
2021-03-03 20:20 ` Andreas Dilger
2021-04-02 19:57 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGd3JmrmFtAHrWE4@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=harshadshirwadkar@gmail.com \
--cc=lihaotian9@huawei.com \
--cc=linfeilong@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=liuzhiqiang26@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).