[f2fs-dev] [PATCH v2] f2fs: remove useless truncate in f2fs_collapse_range()

[f2fs-dev] [PATCH v2] f2fs: remove useless truncate in f2fs_collapse_range()

[Wei Fang]

Since offset < new_size, no need to do truncate_pagecache() again
with new_size.

Signed-off-by: Wei Fang <fangwei1@huawei.com>
---
v2: remove the lock coverage change

 fs/f2fs/file.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 3268f8dd59bb..98721f9bef25 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -1373,8 +1373,6 @@ static int f2fs_collapse_range(struct inode *inode, loff_t offset, loff_t len)
 	truncate_pagecache(inode, offset);
 
 	new_size = i_size_read(inode) - len;
-	truncate_pagecache(inode, new_size);
-
 	ret = f2fs_truncate_blocks(inode, new_size, true);
 	up_write(&F2FS_I(inode)->i_mmap_sem);
 	if (!ret)
-- 
2.21.3



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH v2] f2fs: remove useless truncate in f2fs_collapse_range()

[Chao Yu]

On 2020/6/15 16:11, Wei Fang wrote:
> Since offset < new_size, no need to do truncate_pagecache() again
> with new_size.
> 
> Signed-off-by: Wei Fang <fangwei1@huawei.com>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel