* [f2fs-dev] [PATCH -next] f2fs: make __allocate_new_segment() static
@ 2020-07-01 15:28 Wei Yongjun
2020-07-01 16:16 ` Jaegeuk Kim
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2020-07-01 15:28 UTC (permalink / raw)
To: hulkcommits, Jaegeuk Kim, Chao Yu
Cc: Hulk Robot, linux-kernel, linux-f2fs-devel
From: Hulk Robot <hulkci@huawei.com>
From: Hulk Robot <hulkci@huawei.com>
Fix sparse build warning:
fs/f2fs/segment.c:2736:6: warning:
symbol '__allocate_new_segment' was not declared. Should it be static?
Signed-off-by: Hulk Robot <hulkci@huawei.com>
---
fs/f2fs/segment.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index b45e473508a9..c35614d255e1 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -2733,7 +2733,7 @@ void f2fs_allocate_segment_for_resize(struct f2fs_sb_info *sbi, int type,
up_read(&SM_I(sbi)->curseg_lock);
}
-void __allocate_new_segment(struct f2fs_sb_info *sbi, int type)
+static void __allocate_new_segment(struct f2fs_sb_info *sbi, int type)
{
struct curseg_info *curseg = CURSEG_I(sbi, type);
unsigned int old_segno;
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [f2fs-dev] [PATCH -next] f2fs: make __allocate_new_segment() static
2020-07-01 15:28 [f2fs-dev] [PATCH -next] f2fs: make __allocate_new_segment() static Wei Yongjun
@ 2020-07-01 16:16 ` Jaegeuk Kim
0 siblings, 0 replies; 2+ messages in thread
From: Jaegeuk Kim @ 2020-07-01 16:16 UTC (permalink / raw)
To: Wei Yongjun; +Cc: hulkcommits, Hulk Robot, linux-kernel, linux-f2fs-devel
On 07/01, Wei Yongjun wrote:
> From: Hulk Robot <hulkci@huawei.com>
>
> From: Hulk Robot <hulkci@huawei.com>
>
> Fix sparse build warning:
>
> fs/f2fs/segment.c:2736:6: warning:
> symbol '__allocate_new_segment' was not declared. Should it be static?
It was fixed.
https://lore.kernel.org/linux-f2fs-devel/20200701042222.GA1539525@google.com/T/#m9667447e4d37672e26dee7e30896d129eac1c479
>
> Signed-off-by: Hulk Robot <hulkci@huawei.com>
> ---
> fs/f2fs/segment.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index b45e473508a9..c35614d255e1 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -2733,7 +2733,7 @@ void f2fs_allocate_segment_for_resize(struct f2fs_sb_info *sbi, int type,
> up_read(&SM_I(sbi)->curseg_lock);
> }
>
> -void __allocate_new_segment(struct f2fs_sb_info *sbi, int type)
> +static void __allocate_new_segment(struct f2fs_sb_info *sbi, int type)
> {
> struct curseg_info *curseg = CURSEG_I(sbi, type);
> unsigned int old_segno;
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-01 16:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-01 15:28 [f2fs-dev] [PATCH -next] f2fs: make __allocate_new_segment() static Wei Yongjun
2020-07-01 16:16 ` Jaegeuk Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).