From: Sam Ravnborg <sam@ravnborg.org> To: Qinglang Miao <miaoqinglang@huawei.com> Cc: linux-fbdev@vger.kernel.org, linux-gpio@vger.kernel.org, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Bartosz Golaszewski <bgolaszewski@baylibre.com>, linux-omap@vger.kernel.org Subject: Re: [PATCH -next] omapfb: connector-hdmi: simplify the return expression of hdmic_connect Date: Fri, 16 Oct 2020 21:19:43 +0000 [thread overview] Message-ID: <20201016211943.GG1496366@ravnborg.org> (raw) In-Reply-To: <20200921131051.92661-1-miaoqinglang@huawei.com> Hi Qinglang Miao On Mon, Sep 21, 2020 at 09:10:51PM +0800, Qinglang Miao wrote: > Simplify the return expression. > > Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com> I dropped the changes to gpio-cs5535.c when I applied this patch to drm-misc-next. It looks like an accident that it was included here. Sam > --- > drivers/gpio/gpio-cs5535.c | 6 +----- > drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c | 7 +------ > 2 files changed, 2 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpio/gpio-cs5535.c b/drivers/gpio/gpio-cs5535.c > index 53b24e3ae..57b9ddffd 100644 > --- a/drivers/gpio/gpio-cs5535.c > +++ b/drivers/gpio/gpio-cs5535.c > @@ -345,12 +345,8 @@ static int cs5535_gpio_probe(struct platform_device *pdev) > mask_orig, mask); > > /* finally, register with the generic GPIO API */ > - err = devm_gpiochip_add_data(&pdev->dev, &cs5535_gpio_chip.chip, > + return devm_gpiochip_add_data(&pdev->dev, &cs5535_gpio_chip.chip, > &cs5535_gpio_chip); > - if (err) > - return err; > - > - return 0; > } > > static struct platform_driver cs5535_gpio_driver = { > diff --git a/drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c b/drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c > index 49551afbd..670b9c6eb 100644 > --- a/drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c > +++ b/drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c > @@ -50,18 +50,13 @@ static int hdmic_connect(struct omap_dss_device *dssdev) > { > struct panel_drv_data *ddata = to_panel_data(dssdev); > struct omap_dss_device *in = ddata->in; > - int r; > > dev_dbg(ddata->dev, "connect\n"); > > if (omapdss_device_is_connected(dssdev)) > return 0; > > - r = in->ops.hdmi->connect(in, dssdev); > - if (r) > - return r; > - > - return 0; > + return in->ops.hdmi->connect(in, dssdev); > } > > static void hdmic_disconnect(struct omap_dss_device *dssdev) > -- > 2.23.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org> To: Qinglang Miao <miaoqinglang@huawei.com> Cc: Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org Subject: Re: [PATCH -next] omapfb: connector-hdmi: simplify the return expression of hdmic_connect Date: Fri, 16 Oct 2020 23:19:43 +0200 [thread overview] Message-ID: <20201016211943.GG1496366@ravnborg.org> (raw) Message-ID: <20201016211943._CKqmSp5wrOiBmh5oOrRzd-RvD5GlM0o_oREaWND4gI@z> (raw) In-Reply-To: <20200921131051.92661-1-miaoqinglang@huawei.com> Hi Qinglang Miao On Mon, Sep 21, 2020 at 09:10:51PM +0800, Qinglang Miao wrote: > Simplify the return expression. > > Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com> I dropped the changes to gpio-cs5535.c when I applied this patch to drm-misc-next. It looks like an accident that it was included here. Sam > --- > drivers/gpio/gpio-cs5535.c | 6 +----- > drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c | 7 +------ > 2 files changed, 2 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpio/gpio-cs5535.c b/drivers/gpio/gpio-cs5535.c > index 53b24e3ae..57b9ddffd 100644 > --- a/drivers/gpio/gpio-cs5535.c > +++ b/drivers/gpio/gpio-cs5535.c > @@ -345,12 +345,8 @@ static int cs5535_gpio_probe(struct platform_device *pdev) > mask_orig, mask); > > /* finally, register with the generic GPIO API */ > - err = devm_gpiochip_add_data(&pdev->dev, &cs5535_gpio_chip.chip, > + return devm_gpiochip_add_data(&pdev->dev, &cs5535_gpio_chip.chip, > &cs5535_gpio_chip); > - if (err) > - return err; > - > - return 0; > } > > static struct platform_driver cs5535_gpio_driver = { > diff --git a/drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c b/drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c > index 49551afbd..670b9c6eb 100644 > --- a/drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c > +++ b/drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c > @@ -50,18 +50,13 @@ static int hdmic_connect(struct omap_dss_device *dssdev) > { > struct panel_drv_data *ddata = to_panel_data(dssdev); > struct omap_dss_device *in = ddata->in; > - int r; > > dev_dbg(ddata->dev, "connect\n"); > > if (omapdss_device_is_connected(dssdev)) > return 0; > > - r = in->ops.hdmi->connect(in, dssdev); > - if (r) > - return r; > - > - return 0; > + return in->ops.hdmi->connect(in, dssdev); > } > > static void hdmic_disconnect(struct omap_dss_device *dssdev) > -- > 2.23.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-10-16 21:19 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-21 13:10 [PATCH -next] omapfb: connector-hdmi: simplify the return expression of hdmic_connect Qinglang Miao 2020-10-16 21:19 ` Sam Ravnborg [this message] 2020-10-16 21:19 ` Sam Ravnborg
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201016211943.GG1496366@ravnborg.org \ --to=sam@ravnborg.org \ --cc=b.zolnierkie@samsung.com \ --cc=bgolaszewski@baylibre.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=miaoqinglang@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).