From: Sam Ravnborg <sam@ravnborg.org> To: Liu Shixin <liushixin2@huawei.com> Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Subject: Re: [PATCH -next] omapfb: connector-dvi: simplify the return expression of dvic_connect() Date: Sat, 17 Oct 2020 06:20:45 +0000 [thread overview] Message-ID: <20201017062045.GF2242298@ravnborg.org> (raw) In-Reply-To: <20200915032627.1772517-1-liushixin2@huawei.com> Hi Liu. On Tue, Sep 15, 2020 at 11:26:27AM +0800, Liu Shixin wrote: > Simplify the return expression. > > Signed-off-by: Liu Shixin <liushixin2@huawei.com> Thanks, also applied. If you have other drm/fbdev patches pending then I have missed them. So please resend if this is the case. Sam > --- > drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c b/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c > index b4a1aefff766..2fa436475b40 100644 > --- a/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c > +++ b/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c > @@ -51,16 +51,11 @@ static int dvic_connect(struct omap_dss_device *dssdev) > { > struct panel_drv_data *ddata = to_panel_data(dssdev); > struct omap_dss_device *in = ddata->in; > - int r; > > if (omapdss_device_is_connected(dssdev)) > return 0; > > - r = in->ops.dvi->connect(in, dssdev); > - if (r) > - return r; > - > - return 0; > + return in->ops.dvi->connect(in, dssdev); > } > > static void dvic_disconnect(struct omap_dss_device *dssdev) > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org> To: Liu Shixin <liushixin2@huawei.com> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH -next] omapfb: connector-dvi: simplify the return expression of dvic_connect() Date: Sat, 17 Oct 2020 08:20:45 +0200 [thread overview] Message-ID: <20201017062045.GF2242298@ravnborg.org> (raw) Message-ID: <20201017062045.z1ewdoj2reFhxPGkoEKuCWW_qefnEZj9WU0O5sC1xjs@z> (raw) In-Reply-To: <20200915032627.1772517-1-liushixin2@huawei.com> Hi Liu. On Tue, Sep 15, 2020 at 11:26:27AM +0800, Liu Shixin wrote: > Simplify the return expression. > > Signed-off-by: Liu Shixin <liushixin2@huawei.com> Thanks, also applied. If you have other drm/fbdev patches pending then I have missed them. So please resend if this is the case. Sam > --- > drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c b/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c > index b4a1aefff766..2fa436475b40 100644 > --- a/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c > +++ b/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c > @@ -51,16 +51,11 @@ static int dvic_connect(struct omap_dss_device *dssdev) > { > struct panel_drv_data *ddata = to_panel_data(dssdev); > struct omap_dss_device *in = ddata->in; > - int r; > > if (omapdss_device_is_connected(dssdev)) > return 0; > > - r = in->ops.dvi->connect(in, dssdev); > - if (r) > - return r; > - > - return 0; > + return in->ops.dvi->connect(in, dssdev); > } > > static void dvic_disconnect(struct omap_dss_device *dssdev) > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-10-17 6:20 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-15 3:26 [PATCH -next] omapfb: connector-dvi: simplify the return expression of dvic_connect() Liu Shixin 2020-10-17 6:20 ` Sam Ravnborg [this message] 2020-10-17 6:20 ` Sam Ravnborg
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201017062045.GF2242298@ravnborg.org \ --to=sam@ravnborg.org \ --cc=b.zolnierkie@samsung.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=liushixin2@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).