From: Larry Finger <Larry.Finger@lwfinger.net>
To: Reto Schneider <code@reto-schneider.ch>, linux-firmware@kernel.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: v88 firmware files for rtl8192cu
Date: Mon, 23 Mar 2020 09:57:55 -0500 [thread overview]
Message-ID: <83f99512-ac72-642e-e336-c2cdce62634c@lwfinger.net> (raw)
Message-ID: <20200323145755.K2R7JgcxbWxjGWkJv9xTJqJu6g7vwj8R6FkC7c4om7U@z> (raw)
In-Reply-To: <20200323024500.4090-1-code@reto-schneider.ch>
On 3/22/20 9:45 PM, Reto Schneider wrote:
> The vendor driver v4.0.1_6911.20130308 includes new firmware files.
> These were extracted from data statements in that driver to form these
> files.
>
> Signed-off-by: Reto Schneider <code@reto-schneider.ch>
> ---
> WHENCE | 20 ++++++++++++++++++--
> rtlwifi/rtl8192cufw_A.bin | Bin 16116 -> 16126 bytes
> rtlwifi/rtl8192cufw_B.bin | Bin 16096 -> 16096 bytes
> rtlwifi/rtl8192cufw_TMSC.bin | Bin 16116 -> 16126 bytes
> 4 files changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/WHENCE b/WHENCE
> index 6265e03..d5bde95 100644
> --- a/WHENCE
> +++ b/WHENCE
> @@ -2738,14 +2738,30 @@ Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
>
> --------------------------------------------------------------------------
>
> -Driver: rtl8192cu - Realtek 802.11n WLAN driver for RTL8192CU
> +Driver: rtl8192cu - Realtek 802.11n WLAN driver for RTL8192CU (fallback)
>
> File: rtlwifi/rtl8192cufw.bin
> +
> +Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
> +
> +--------------------------------------------------------------------------
> +
> +Driver: rtl8192cu - Realtek 802.11n WLAN driver for RTL8192CU
> +
> File: rtlwifi/rtl8192cufw_A.bin
> File: rtlwifi/rtl8192cufw_B.bin
> File: rtlwifi/rtl8192cufw_TMSC.bin
> +Info: From Vendor's rtl8188C_8192C_usb_linux_v4.0.1_6911.20130308 driver
> + All files extracted from driver/hal/rtl8192c/usb/Hal8192CUHWImg.c
> + Relevant variables (CONFIG_BT_COEXISTENCE not set):
> + - rtlwifi/rtl8192cufw_A.bin: Rtl8192CUFwUMCACutImgArray
> + - rtlwifi/rtl8192cufw_B.bin: Rtl8192CUFwUMCBCutImgArray
> + - rtlwifi/rtl8192cufw_TMSC.bin: Rtl8192CUFwTSMCImgArray
>
> -Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
> +Licence: Allegedly GPLv2, but no source visible.
No, do not change this line. The firmware is NOT GPLv2; however, it can be
redistributed as LICENCE.rtlwiifi says.
NACK.
Larry
next prev parent reply other threads:[~2020-03-23 14:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 2:45 [PATCH] rtlwifi: v88 firmware files for rtl8192cu Reto Schneider
2020-03-23 2:45 ` Reto Schneider
2020-03-23 14:57 ` Larry Finger [this message]
2020-03-23 14:57 ` Larry Finger
2020-03-23 22:58 ` [PATCH v2 0/1] Updating RTL8192CU firmware Reto Schneider
2020-03-23 22:58 ` Reto Schneider
2020-03-23 22:58 ` [PATCH v2 1/1] rtlwifi: v88.2 firmware files for RTL8192CU Reto Schneider
2020-03-23 22:58 ` Reto Schneider
2020-09-06 3:39 ` Chris Chiu
2020-09-06 3:39 ` Chris Chiu
2020-09-14 13:19 ` Josh Boyer
2020-09-20 3:00 ` Reto Schneider
2020-09-03 17:57 ` [PATCH v2 0/1] Updating RTL8192CU firmware Reto Schneider
2020-09-03 17:57 ` Reto Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83f99512-ac72-642e-e336-c2cdce62634c@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=code@reto-schneider.ch \
--cc=linux-firmware@kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).