From: Xu Yilun <yilun.xu@intel.com>
To: trix@redhat.com
Cc: mdf@kernel.org, hao.wu@intel.com, michal.simek@xilinx.com,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 4/4] fpga: use reimage ops in fpga_mgr_load()
Date: Mon, 28 Jun 2021 15:03:15 +0800 [thread overview]
Message-ID: <20210628070315.GF72330@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <20210625195849.837976-6-trix@redhat.com>
On Fri, Jun 25, 2021 at 12:58:49PM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> If the fpga_image_info flags FPGA_MGR_REIMAGE bit is set
> swap out the reconfig ops for the reimage ops and do
> the load.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/fpga/fpga-mgr.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c
> index c8a6bfa037933..5e53a0508087a 100644
> --- a/drivers/fpga/fpga-mgr.c
> +++ b/drivers/fpga/fpga-mgr.c
> @@ -419,6 +419,9 @@ int fpga_mgr_load(struct fpga_manager *mgr, struct fpga_image_info *info)
> {
> const struct fpga_manager_update_ops *uops = &mgr->mops->reconfig;
>
> + if (info->flags & FPGA_MGR_REIMAGE)
> + uops = &mgr->mops->reimage;
> +
So seems there is no big difference on processing 'reconfig' & 'reimage'
in FPGA mgr framework. We may not have to introduce 2 sets of ops in
fpga_mgr.
Could we just reuse the fpga_mgr_ops for reimage? The
fpga_mgr_ops.write_init() will pass the fpga_image_info to device driver,
and driver could be aware of the REIMAGE flag. Just like the handling of
other flags in fpga_image_info.
Thanks,
Yilun
> if (info->sgt)
> return fpga_mgr_buf_load_sg(mgr, info, info->sgt, uops);
> if (info->buf && info->count)
> --
> 2.26.3
prev parent reply other threads:[~2021-06-28 7:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 19:58 [PATCH v5 0/4] generalize fpga_mgr_load trix
2021-06-25 19:58 ` [PATCH v5 1/4] fpga: generalize updating the card trix
2021-06-28 18:44 ` Moritz Fischer
2021-06-28 20:55 ` Tom Rix
2021-06-25 19:58 ` [PATCH v5 2/4] fpga: add FPGA_MGR_REIMAGE flag trix
2021-06-28 7:35 ` Martin Hundebøll
2021-06-25 19:58 ` [PATCH v5 3/4] fpga: pass fpga_manager_update_ops to the fpga_manager_write functions trix
2021-06-28 7:42 ` Martin Hundebøll
2021-06-25 19:58 ` [PATCH v5 4/4] fpga: use reimage ops in fpga_mgr_load() trix
2021-06-28 7:03 ` Xu Yilun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210628070315.GF72330@yilunxu-OptiPlex-7050 \
--to=yilun.xu@intel.com \
--cc=hao.wu@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).