From: "Martin Hundebøll" <mhu@silicom.dk>
To: trix@redhat.com, mdf@kernel.org, hao.wu@intel.com,
michal.simek@xilinx.com
Cc: linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 3/4] fpga: pass fpga_manager_update_ops to the fpga_manager_write functions
Date: Mon, 28 Jun 2021 09:42:30 +0200 [thread overview]
Message-ID: <f80e3d42-31dc-d9eb-90ec-8e740e2e4237@silicom.dk> (raw)
In-Reply-To: <20210625195849.837976-5-trix@redhat.com>
On 25/06/2021 21.58, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Refactor fpga_manager_write* functions for reimaging, pass
> the update_ops as a parameter. Continue the passing of the update_ops
> to the write wrapper functions. Only do the reconfig ops.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/fpga/fpga-mgr.c | 90 ++++++++++++++++++++++++-----------------
> 1 file changed, 53 insertions(+), 37 deletions(-)
>
> diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c
> index 31c51d7e07cc8..c8a6bfa037933 100644
> --- a/drivers/fpga/fpga-mgr.c
> +++ b/drivers/fpga/fpga-mgr.c
> @@ -45,10 +45,12 @@ static inline u64 fpga_mgr_status(struct fpga_manager *mgr)
> return 0;
> }
>
> -static inline int fpga_mgr_write(struct fpga_manager *mgr, const char *buf, size_t count)
> +static inline int fpga_mgr_write(struct fpga_manager *mgr,
> + const char *buf, size_t count,
> + const struct fpga_manager_update_ops *uops)
> {
> if (mgr->mops->reconfig.write)
Shouldn't this check be
if (uops->write)
return ...
?
> - return mgr->mops->reconfig.write(mgr, buf, count);
> + return uops->write(mgr, buf, count);
> return -EOPNOTSUPP;
> }
>
<snip>
> @@ -208,6 +215,7 @@ static int fpga_mgr_write_init_sg(struct fpga_manager *mgr,
> * @mgr: fpga manager
> * @info: fpga image specific information
> * @sgt: scatterlist table
> + * @uops: which update ops to use
Tabs vs. spaces.
> *
> * Step the low level fpga manager through the device-specific steps of getting
> * an FPGA ready to be configured, writing the image to it, then doing whatever
<snip>
> @@ -285,6 +295,7 @@ static int fpga_mgr_buf_load_mapped(struct fpga_manager *mgr,
> * @info: fpga image info
> * @buf: buffer contain fpga image
> * @count: byte count of buf
> + * @uops: which update ops to use
Tabs vs. spaces.
> *
> * Step the low level fpga manager through the device-specific steps of getting
> * an FPGA ready to be configured, writing the image to it, then doing whatever
<snip>
> @@ -356,6 +368,7 @@ static int fpga_mgr_buf_load(struct fpga_manager *mgr,
> * @mgr: fpga manager
> * @info: fpga image specific information
> * @image_name: name of image file on the firmware search path
> + * @uops: which update ops to use
Tabs vs. spaces.
> *
> * Request an FPGA image using the firmware class, then write out to the FPGA.
> * Update the state before each step to provide info on what step failed if
// Martin
next prev parent reply other threads:[~2021-06-28 7:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 19:58 [PATCH v5 0/4] generalize fpga_mgr_load trix
2021-06-25 19:58 ` [PATCH v5 1/4] fpga: generalize updating the card trix
2021-06-28 18:44 ` Moritz Fischer
2021-06-28 20:55 ` Tom Rix
2021-06-25 19:58 ` [PATCH v5 2/4] fpga: add FPGA_MGR_REIMAGE flag trix
2021-06-28 7:35 ` Martin Hundebøll
2021-06-25 19:58 ` [PATCH v5 3/4] fpga: pass fpga_manager_update_ops to the fpga_manager_write functions trix
2021-06-28 7:42 ` Martin Hundebøll [this message]
2021-06-25 19:58 ` [PATCH v5 4/4] fpga: use reimage ops in fpga_mgr_load() trix
2021-06-28 7:03 ` Xu Yilun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f80e3d42-31dc-d9eb-90ec-8e740e2e4237@silicom.dk \
--to=mhu@silicom.dk \
--cc=hao.wu@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).