From: Tom Rix <trix@redhat.com>
To: "Martin Hundebøll" <mhu@silicom.dk>, "Wu Hao" <hao.wu@intel.com>,
"Moritz Fischer" <mdf@kernel.org>,
"Xu Yilun" <yilun.xu@intel.com>,
"Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Lee Jones" <lee.jones@linaro.org>,
"Mark Brown" <broonie@kernel.org>
Cc: "Martin Hundebøll" <mhu@geanix.com>,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-spi@vger.kernel.org,
"Debarati Biswas" <debaratix.biswas@intel.com>,
"Russ Weight" <russell.h.weight@intel.com>
Subject: Re: [PATCH 2/4] fpga: dfl: Move DFH header register macros to linux/dfl.h
Date: Wed, 23 Jun 2021 06:38:06 -0700 [thread overview]
Message-ID: <77aa43c1-6d94-bf08-13cf-ec405916b4b7@redhat.com> (raw)
In-Reply-To: <7c6021cc-69c5-7c3f-9e37-30c933535835@silicom.dk>
On 6/23/21 4:44 AM, Martin Hundebøll wrote:
> On 21/06/2021 15.56, Tom Rix wrote:
>>
>> On 6/21/21 12:06 AM, Martin Hundebøll wrote:
>>> From: Debarati Biswas <debaratix.biswas@intel.com>
>>>
>>> Device Feature List (DFL) drivers may be defined in subdirectories
>>> other
>>> than drivers/fpga, and each DFL driver should have access to the Device
>>> Feature Header (DFH) register, which contains revision and type
>>> information. This change moves the macros specific to the DFH register
>>> from drivers/fpga/dfl.h to include/linux/dfl.h.
>>>
>>> Signed-off-by: Debarati Biswas <debaratix.biswas@intel.com>
>>> Signed-off-by: Russ Weight <russell.h.weight@intel.com>
>>> Signed-off-by: Martin Hundebøll <mhu@silicom.dk>
>>> ---
>>> drivers/fpga/dfl.h | 48 +----------------------------------------
>>> include/linux/dfl.h | 52
>>> +++++++++++++++++++++++++++++++++++++++++++++
>>> 2 files changed, 53 insertions(+), 47 deletions(-)
>>>
>>> diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h
>>> index 2b82c96ba56c..6ed0353e9a99 100644
>>> --- a/drivers/fpga/dfl.h
>>> +++ b/drivers/fpga/dfl.h
>>> @@ -17,6 +17,7 @@
>>> #include <linux/bitfield.h>
>>
>> bitfield.h was added to linux/dfl.h
>>
>> Likely both aren't needed, try removing this one.
>
> After this patch both headers use GENMASK_ULL() and BIT_ULL(), which
> are both defined in linux/bits.h, so I would expect both to include
> that instead. A lot of the users of dfl.h uses FIELD_GET(), which is
> defined in linux/bitfield.h, so I would expect that to be included
> there instead.
>
> I can prepare a patch to fix that up, if you like?
A rule of thumb, if your commit says 'A and B' , likely it should only be A.
Remove the the linux/bitfield.h from drivers/fpga/dfl.h
Leave the linux/bitfield.h as-is in include/linux/dfl.h
If you feel include/linux/dfl.h can be optimized by the reduction of
linux/bitfield.h to linux/bits.h, do that as a follow on patchset.
Tom
>
> // Martin
>
next prev parent reply other threads:[~2021-06-23 13:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 7:06 [PATCH 0/4] fpga/mfd/hwmon: Initial support for Silicom N5010 PAC Martin Hundebøll
2021-06-21 7:06 ` [PATCH 1/4] fpga: dfl: pci: add device IDs for Silicom N501x PAC cards Martin Hundebøll
2021-06-21 9:57 ` Wu, Hao
2021-06-21 7:06 ` [PATCH 2/4] fpga: dfl: Move DFH header register macros to linux/dfl.h Martin Hundebøll
2021-06-21 10:19 ` Wu, Hao
2021-06-22 5:22 ` Xu Yilun
2021-06-22 7:39 ` Wu, Hao
2021-06-23 11:56 ` Martin Hundebøll
2021-06-24 3:01 ` Xu Yilun
2021-06-24 4:45 ` Wu, Hao
2021-06-21 13:56 ` Tom Rix
2021-06-22 4:56 ` Xu Yilun
2021-06-22 12:31 ` Tom Rix
2021-06-23 6:37 ` Xu Yilun
2021-06-23 11:44 ` Martin Hundebøll
2021-06-23 13:38 ` Tom Rix [this message]
2021-06-21 19:33 ` kernel test robot
2021-06-21 7:06 ` [PATCH 3/4] spi: spi-altera-dfl: support n5010 feature revision Martin Hundebøll
2021-06-21 7:06 ` [PATCH 4/4] hwmon: intel-m10-bmc: add sensor support for Silicom N5010 card Martin Hundebøll
2021-06-21 8:55 ` Lee Jones
2021-06-21 8:38 ` [PATCH 0/4] fpga/mfd/hwmon: Initial support for Silicom N5010 PAC Xu Yilun
2021-06-25 7:11 ` Martin Hundebøll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77aa43c1-6d94-bf08-13cf-ec405916b4b7@redhat.com \
--to=trix@redhat.com \
--cc=broonie@kernel.org \
--cc=debaratix.biswas@intel.com \
--cc=hao.wu@intel.com \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mdf@kernel.org \
--cc=mhu@geanix.com \
--cc=mhu@silicom.dk \
--cc=russell.h.weight@intel.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).