From: "Wu, Hao" <hao.wu@intel.com>
To: "Xu, Yilun" <yilun.xu@intel.com>, "Martin Hundebøll" <mhu@silicom.dk>
Cc: "Tom Rix" <trix@redhat.com>, "Moritz Fischer" <mdf@kernel.org>,
"Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Lee Jones" <lee.jones@linaro.org>,
"Mark Brown" <broonie@kernel.org>,
"Martin Hundebøll" <mhu@geanix.com>,
"linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"Debarati Biswas" <debaratix.biswas@intel.com>,
"Weight, Russell H" <russell.h.weight@intel.com>
Subject: RE: [PATCH 2/4] fpga: dfl: Move DFH header register macros to linux/dfl.h
Date: Thu, 24 Jun 2021 04:45:43 +0000 [thread overview]
Message-ID: <DM6PR11MB3819B96AC0E54AF96EDE728485079@DM6PR11MB3819.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210624030120.GA42039@yilunxu-OptiPlex-7050>
> On Wed, Jun 23, 2021 at 01:56:59PM +0200, Martin Hundebøll wrote:
> >
> >
> > On 22/06/2021 09.39, Wu, Hao wrote:
> > > > On Mon, Jun 21, 2021 at 06:19:15PM +0800, Wu, Hao wrote:
> > > > > > Subject: [PATCH 2/4] fpga: dfl: Move DFH header register macros to
> > > > linux/dfl.h
> > > > > >
> > > > > > From: Debarati Biswas <debaratix.biswas@intel.com>
> > > > > >
> > > > > > Device Feature List (DFL) drivers may be defined in subdirectories other
> > > > > > than drivers/fpga, and each DFL driver should have access to the Device
> > > > > > Feature Header (DFH) register, which contains revision and type
> > > > > > information. This change moves the macros specific to the DFH register
> > > > > > from drivers/fpga/dfl.h to include/linux/dfl.h.
> > > > >
> > > > > Looks like it requires to access the revision info in the next patch,
> because
> > > > > current dfl_device doesn't expose related information.
> > > > >
> > > > > @Yilun, do you have any concern to expose those info via dfl_device?
> > > >
> > > > Exposing these header register definitions are good to me. These registers
> > > > are in DFL device's MMIO region, so it is good to share these info with
> > > > all DFL drivers.
> > >
> > > I mean expose revision via dfl_device, as dfl core already reads the DFL
> > > header, it sounds duplicate read in each dfl device driver. And if we
> > > consider this as a common need from dfl device driver, then the code
> > > can be moved to a common place as well.
> > >
> > > I hope from dfl device driver side, it doesn't need to know details of
> > > how DFH register is defined, only simple way from dfl device data
> > > structure or some simple helper function, then dfl device driver could
> > > know all common information from DFH.
> > >
> > > How do you think?
>
> It's good idea.
>
> >
> > struct dfl_device {} already has "u16 type" and "u16 feature_id", so it would
> make sense to add "u8 feature_rev" as well?
>
> I think we may name it "u8 revision".
Sounds good.
Then we don't have to expose detailed registers information to such header file.
dfl_device data structure + helper function should be enough. : )
Thanks
Hao
>
> Thanks,
> Yilun
>
> >
> > // Martin
next prev parent reply other threads:[~2021-06-24 4:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 7:06 [PATCH 0/4] fpga/mfd/hwmon: Initial support for Silicom N5010 PAC Martin Hundebøll
2021-06-21 7:06 ` [PATCH 1/4] fpga: dfl: pci: add device IDs for Silicom N501x PAC cards Martin Hundebøll
2021-06-21 9:57 ` Wu, Hao
2021-06-21 7:06 ` [PATCH 2/4] fpga: dfl: Move DFH header register macros to linux/dfl.h Martin Hundebøll
2021-06-21 10:19 ` Wu, Hao
2021-06-22 5:22 ` Xu Yilun
2021-06-22 7:39 ` Wu, Hao
2021-06-23 11:56 ` Martin Hundebøll
2021-06-24 3:01 ` Xu Yilun
2021-06-24 4:45 ` Wu, Hao [this message]
2021-06-21 13:56 ` Tom Rix
2021-06-22 4:56 ` Xu Yilun
2021-06-22 12:31 ` Tom Rix
2021-06-23 6:37 ` Xu Yilun
2021-06-23 11:44 ` Martin Hundebøll
2021-06-23 13:38 ` Tom Rix
2021-06-21 19:33 ` kernel test robot
2021-06-21 7:06 ` [PATCH 3/4] spi: spi-altera-dfl: support n5010 feature revision Martin Hundebøll
2021-06-21 7:06 ` [PATCH 4/4] hwmon: intel-m10-bmc: add sensor support for Silicom N5010 card Martin Hundebøll
2021-06-21 8:55 ` Lee Jones
2021-06-21 8:38 ` [PATCH 0/4] fpga/mfd/hwmon: Initial support for Silicom N5010 PAC Xu Yilun
2021-06-25 7:11 ` Martin Hundebøll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB3819B96AC0E54AF96EDE728485079@DM6PR11MB3819.namprd11.prod.outlook.com \
--to=hao.wu@intel.com \
--cc=broonie@kernel.org \
--cc=debaratix.biswas@intel.com \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mdf@kernel.org \
--cc=mhu@geanix.com \
--cc=mhu@silicom.dk \
--cc=russell.h.weight@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).