* [xfstests-bld PATCH] android-xfstests: create /dev/fd on the Android device
@ 2020-12-09 4:33 Eric Biggers
2020-12-10 19:19 ` Theodore Y. Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Eric Biggers @ 2020-12-09 4:33 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: linux-fscrypt, Satya Tangirala
From: Eric Biggers <ebiggers@google.com>
In order for bash process substitution (the syntax like "<(list)" or
">(list)") to work, /dev/fd has to be a symlink to /proc/self/fd.
/dev/fd doesn't exist on Android, so create it if it's missing.
This fixes xfstest generic/576.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
kvm-xfstests/android-xfstests | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/kvm-xfstests/android-xfstests b/kvm-xfstests/android-xfstests
index a8f9be9..7741162 100755
--- a/kvm-xfstests/android-xfstests
+++ b/kvm-xfstests/android-xfstests
@@ -244,6 +244,11 @@ if ! cut -d' ' -f2 /proc/mounts 2>/dev/null | grep -q '^$CHROOT_DIR/results$'; t
mount --bind $RESULTS_DIR $CHROOT_DIR/results
fi
+# /dev/fd needs to exist in order for bash process substitution to work.
+if [ ! -e /dev/fd ]; then
+ ln -s /proc/self/fd /dev/fd
+fi
+
# Android puts loopback device nodes in /dev/block/ instead of /dev/.
# But losetup can only find them in /dev/, so create them there too.
for i in \`seq 0 7\`; do
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [xfstests-bld PATCH] android-xfstests: create /dev/fd on the Android device
2020-12-09 4:33 [xfstests-bld PATCH] android-xfstests: create /dev/fd on the Android device Eric Biggers
@ 2020-12-10 19:19 ` Theodore Y. Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Y. Ts'o @ 2020-12-10 19:19 UTC (permalink / raw)
To: Eric Biggers; +Cc: linux-fscrypt, Satya Tangirala
On Tue, Dec 08, 2020 at 08:33:05PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> In order for bash process substitution (the syntax like "<(list)" or
> ">(list)") to work, /dev/fd has to be a symlink to /proc/self/fd.
> /dev/fd doesn't exist on Android, so create it if it's missing.
>
> This fixes xfstest generic/576.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-10 19:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-09 4:33 [xfstests-bld PATCH] android-xfstests: create /dev/fd on the Android device Eric Biggers
2020-12-10 19:19 ` Theodore Y. Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).