From: "Alastair D'Silva" <alastair@d-silva.org>
To: "'David Laight'" <David.Laight@ACULAB.COM>,
"'Petr Mladek'" <pmladek@suse.com>
Cc: "'Jani Nikula'" <jani.nikula@linux.intel.com>,
"'Joonas Lahtinen'" <joonas.lahtinen@linux.intel.com>,
"'Rodrigo Vivi'" <rodrigo.vivi@intel.com>,
"'David Airlie'" <airlied@linux.ie>,
"'Daniel Vetter'" <daniel@ffwll.ch>,
"'Karsten Keil'" <isdn@linux-pingi.de>,
"'Jassi Brar'" <jassisinghbrar@gmail.com>,
"'Tom Lendacky'" <thomas.lendacky@amd.com>,
"'David S. Miller'" <davem@davemloft.net>,
"'Jose Abreu'" <Jose.Abreu@synopsys.com>,
"'Kalle Valo'" <kvalo@codeaurora.org>,
"'Stanislaw Gruszka'" <sgruszka@redhat.com>,
"'Benson Leung'" <bleung@chromium.org>,
"'Enric Balletbo i Serra'" <enric.balletbo@collabora.com>,
"'James E.J. Bottomley'" <jejb@linux.ibm.com>,
"'Martin K. Petersen'" <martin.petersen@oracle.com>,
"'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>,
"'Alexander Viro'" <viro@zeniv.linux.org.uk>,
"'Sergey Senozhatsky'" <sergey.senozhatsky@gmail.com>,
"'Steven Rostedt'" <rostedt@goodmis.org>,
"'Andrew Morton'" <akpm@linux-foundation.org>,
<intel-gfx@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <ath10k@lists.infradead.org>,
<linux-wireless@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<linux-fbdev@vger.kernel.org>, <devel@driverdev.osuosl.org>,
<linux-fsdevel@vger.kernel.org>
Subject: RE: [PATCH 1/4] lib/hexdump.c: Allow 64 bytes per line
Date: Mon, 15 Apr 2019 20:59:36 +1000 [thread overview]
Message-ID: <0dc901d4f37a$52733a70$f759af50$@d-silva.org> (raw)
In-Reply-To: <6912ef2d83d34c9299d5a5ad120c276f@AcuMS.aculab.com>
> From: Alastair D'Silva
> > Sent: 15 April 2019 11:29
> ...
> > I do, and I believe the choice of the output length should be in the
> > hands of the caller.
> >
> > On further thought, it would make more sense to remove the hardcoded
> > list of sizes and just enforce a power of 2. The function shouldn't
> > dictate what the caller can and can't do beyond the technical limits of it's
> implementation.
>
> Why powers of two?
> You may want the length to match sizeof (struct foo).
> You might even want the address increment to be larger that the number of
> lines dumped.
Good point, the base requirement is that it should be a multiple of groupsize.
--
Alastair D'Silva mob: 0423 762 819
skype: alastair_dsilva msn: alastair@d-silva.org
blog: http://alastair.d-silva.org Twitter: @EvilDeece
next prev parent reply other threads:[~2019-04-15 10:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 3:17 [PATCH 0/4] Hexdump enhancements Alastair D'Silva
2019-04-10 3:17 ` [PATCH 1/4] lib/hexdump.c: Allow 64 bytes per line Alastair D'Silva
2019-04-12 13:48 ` Petr Mladek
2019-04-12 23:22 ` Alastair D'Silva
2019-04-15 9:02 ` Petr Mladek
2019-04-15 10:29 ` Alastair D'Silva
2019-04-15 10:56 ` David Laight
2019-04-15 10:59 ` Alastair D'Silva [this message]
2019-04-10 3:17 ` [PATCH 2/4] lib/hexdump.c: Optionally suppress lines of filler bytes Alastair D'Silva
2019-04-10 3:32 ` Alastair D'Silva
2019-04-12 14:03 ` Petr Mladek
2019-04-12 23:28 ` Alastair D'Silva
2019-04-15 9:18 ` Petr Mladek
2019-04-15 10:33 ` Alastair D'Silva
2019-04-10 3:17 ` [PATCH 3/4] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags Alastair D'Silva
2019-04-10 6:56 ` Dan Carpenter
2019-04-12 14:12 ` Petr Mladek
2019-04-12 23:31 ` Alastair D'Silva
2019-04-15 9:24 ` Petr Mladek
2019-04-15 10:07 ` Alastair D'Silva
2019-04-15 10:20 ` David Laight
2019-04-15 10:44 ` Alastair D'Silva
2019-04-15 11:03 ` David Laight
2019-04-15 11:12 ` Alastair D'Silva
2019-04-12 14:47 ` [Intel-gfx] " Tvrtko Ursulin
2019-04-10 3:17 ` [PATCH 4/4] lib/hexdump.c: Allow multiple groups to be separated by lines '|' Alastair D'Silva
2019-04-10 8:45 ` David Laight
2019-04-10 9:52 ` Alastair D'Silva
2019-04-10 8:53 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0dc901d4f37a$52733a70$f759af50$@d-silva.org' \
--to=alastair@d-silva.org \
--cc=David.Laight@ACULAB.COM \
--cc=Jose.Abreu@synopsys.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=ath10k@lists.infradead.org \
--cc=bleung@chromium.org \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=isdn@linux-pingi.de \
--cc=jani.nikula@linux.intel.com \
--cc=jassisinghbrar@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rodrigo.vivi@intel.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=sgruszka@redhat.com \
--cc=thomas.lendacky@amd.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).