linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [GIT PULL] fix overlayfs deadlock in file_remove_privs()
@ 2016-08-03 16:30 Miklos Szeredi
  2016-08-03 17:32 ` Al Viro
  0 siblings, 1 reply; 2+ messages in thread
From: Miklos Szeredi @ 2016-08-03 16:30 UTC (permalink / raw)
  To: Al Viro; +Cc: linux-kernel, linux-fsdevel, linux-unionfs

Hi Al,

Please pull from:

  git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git for-viro

This fixes the deadlock introduced by making the suid removal actually work on
overlayfs.

Responsible commit 07a2daab49c5 ("ovl: Copy up underlying inode's ->i_mode to
overlay inode") unfortunately slipped through my testing and 4.7 was released
with this bug.

Two more patches are cleaning away unneeded exports of related helpers.

Thanks,
Miklos

---
Miklos Szeredi (3):
      vfs: fix deadlock in file_remove_privs() on overlayfs
      vfs: remove file_needs_remove_privs()
      vfs: make dentry_needs_remove_privs() internal

---
 fs/inode.c         | 7 +++----
 fs/internal.h      | 1 +
 include/linux/fs.h | 5 -----
 3 files changed, 4 insertions(+), 9 deletions(-)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [GIT PULL] fix overlayfs deadlock in file_remove_privs()
  2016-08-03 16:30 [GIT PULL] fix overlayfs deadlock in file_remove_privs() Miklos Szeredi
@ 2016-08-03 17:32 ` Al Viro
  0 siblings, 0 replies; 2+ messages in thread
From: Al Viro @ 2016-08-03 17:32 UTC (permalink / raw)
  To: Miklos Szeredi; +Cc: linux-kernel, linux-fsdevel, linux-unionfs

On Wed, Aug 03, 2016 at 06:30:29PM +0200, Miklos Szeredi wrote:
> Hi Al,
> 
> Please pull from:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git for-viro
> 
> This fixes the deadlock introduced by making the suid removal actually work on
> overlayfs.
> 
> Responsible commit 07a2daab49c5 ("ovl: Copy up underlying inode's ->i_mode to
> overlay inode") unfortunately slipped through my testing and 4.7 was released
> with this bug.
> 
> Two more patches are cleaning away unneeded exports of related helpers.

Pulled, will push tonight.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-08-03 17:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-03 16:30 [GIT PULL] fix overlayfs deadlock in file_remove_privs() Miklos Szeredi
2016-08-03 17:32 ` Al Viro

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).