From: Mark Fasheh <mfasheh@suse.de>
To: Zygo Blaxell <ce3g8jdj@umail.furryterror.org>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] vfs: dedupe should return EPERM if permission is not granted
Date: Fri, 18 May 2018 01:03:00 +0200 [thread overview]
Message-ID: <20180517230300.GB28045@wotan.suse.de> (raw)
In-Reply-To: <20180517051550.GB22356@hungrycats.org>
On Thu, May 17, 2018 at 01:15:51AM -0400, Zygo Blaxell wrote:
> On Sun, May 13, 2018 at 11:26:39AM -0700, Darrick J. Wong wrote:
> > On Sun, May 13, 2018 at 06:21:52PM +0000, Mark Fasheh wrote:
> > > On Fri, May 11, 2018 at 05:06:34PM -0700, Darrick J. Wong wrote:
> > > > On Fri, May 11, 2018 at 12:26:51PM -0700, Mark Fasheh wrote:
> > > > > Right now we return EINVAL if a process does not have permission to dedupe a
> > > > > file. This was an oversight on my part. EPERM gives a true description of
> > > > > the nature of our error, and EINVAL is already used for the case that the
> > > > > filesystem does not support dedupe.
> > > > >
> > > > > Signed-off-by: Mark Fasheh <mfasheh@suse.de>
> > > > > ---
> > > > > fs/read_write.c | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/fs/read_write.c b/fs/read_write.c
> > > > > index 77986a2e2a3b..8edef43a182c 100644
> > > > > --- a/fs/read_write.c
> > > > > +++ b/fs/read_write.c
> > > > > @@ -2038,7 +2038,7 @@ int vfs_dedupe_file_range(struct file *file, struct file_dedupe_range *same)
> > > > > info->status = -EINVAL;
> > > > > } else if (!(is_admin || (dst_file->f_mode & FMODE_WRITE) ||
> > > > > uid_eq(current_fsuid(), dst->i_uid))) {
> > > > > - info->status = -EINVAL;
> > > > > + info->status = -EPERM;
> > > >
> > > > Hmm, are we allowed to change this aspect of the kabi after the fact?
> > > >
> > > > Granted, we're only trading one error code for another, but will the
> > > > existing users of this care? xfs_io won't and I assume duperemove won't
> > > > either, but what about bees? :)
> > >
> > > Yeah if you see my initial e-mail I check bees and also rust-btrfs. I think
> > > this is fine as we're simply expanding on an error code return. There's no
> > > magic behavior expected with respect to these error codes either.
> >
> > Ok. No objections from me, then.
> >
> > Acked-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> For what it's worth, no objection from me either. ;)
>
> bees runs only with admin privilege and will never hit the modified line.
Awesome, thanks for the review Zygo.
--Mark
next prev parent reply other threads:[~2018-05-17 23:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 19:26 [PATCH 0/2] vfs: better dedupe permission check Mark Fasheh
2018-05-11 19:26 ` [PATCH 1/2] vfs: allow dedupe of user owned read-only files Mark Fasheh
2018-05-11 23:58 ` Darrick J. Wong
2018-05-12 2:49 ` Adam Borowski
2018-05-13 18:16 ` Mark Fasheh
2018-05-13 20:50 ` Adam Borowski
2018-05-17 23:01 ` Mark Fasheh
2018-05-11 19:26 ` [PATCH 2/2] vfs: dedupe should return EPERM if permission is not granted Mark Fasheh
2018-05-12 0:06 ` Darrick J. Wong
2018-05-12 4:15 ` Amir Goldstein
2018-05-12 4:37 ` Duncan
2018-05-13 14:30 ` Adam Borowski
2018-05-13 18:21 ` Mark Fasheh
2018-05-13 18:26 ` Darrick J. Wong
2018-05-17 5:15 ` Zygo Blaxell
2018-05-17 23:03 ` Mark Fasheh [this message]
2018-05-14 14:58 ` David Sterba
2018-09-10 23:21 [PATCH v6 0/2] vfs: fix dedupe permission check Mark Fasheh
2018-09-10 23:21 ` [PATCH 2/2] vfs: dedupe should return EPERM if permission is not granted Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517230300.GB28045@wotan.suse.de \
--to=mfasheh@suse.de \
--cc=ce3g8jdj@umail.furryterror.org \
--cc=darrick.wong@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).